1433667 - When window control placement is "left", CSD displays window controls to right

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Asif Youssuff]

Attachment: left-mate-csd.png

Steps to reproduce:

1. Ensure you are using MATE
2. Install or launch MATE Tweak and ensure that Windows: Appearance is set to "left" for Window control placement. This moves the close, minimize, restore buttons in windows to the left side of windows, like macOS.
3. Enable CSD (customize > disable title bar).

What happens:

Window controls appear on right side of window. 

Expected result:

Window controls should appear on left. 

Screenshots attached.

Comment 1

[Asif Youssuff]

Attachment: left-mate-default.png

Comment 4

[Underpass]

Today a user of the Italian Support Forum told that the same thing happens even using GNOME as Desktop Environment.

Comment 5

[Massimiliano]

I can confirm this issue on Gnome in Ubuntu 18.04 

Comment 6

[jacob.alzen]

I can confirm that this is the case for Budgie on Solus Budgie too...

Comment 9

[13xps]

In addition, in 18.04, the buttons on the right side with Ubuntu 18.04 are slightly blurry and seem to not scale correctly when the title bar is removed.

https://bugzilla.mozilla.org/show_bug.cgi?id=1487586

Comment 10

[Martin Stránský [:stransky] (ni? me)]

There's some help at https://support.mozilla.org/en-US/questions/1222872

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: wip.patch

Dao, what do you think about this approach?

I'm not sure if this is the best way, especially the size computation is hacky, but I can't find anything better. Do you know how is that done on MacOS for instance?

Thanks.

Comment 12

[Dão Gottwald [:dao]]

(In reply to Martin Stránský [:stransky] from comment #11)
> Created attachment 9014403 [details] [diff] [review]
> wip.patch
> 
> Dao, what do you think about this approach?
> 
> I'm not sure if this is the best way, especially the size computation is
> hacky, but I can't find anything better.

Mike is rewriting that in bug 1356920.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

(In reply to Dão Gottwald [::dao] from comment #12)
> (In reply to Martin Stránský [:stransky] from comment #11)
> > Created attachment 9014403 [details] [diff] [review]
> > wip.patch
> > 
> > Dao, what do you think about this approach?
> > 
> > I'm not sure if this is the best way, especially the size computation is
> > hacky, but I can't find anything better.
> 
> Mike is rewriting that in bug 1356920.

Good to know, Thanks!

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 9014403 [details] [diff] [review]
wip.patch

We'll need to look into this once bug 1356920 is done.

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1433667 - Honour system titlebar button left/right placement, r=dao

Comment 16

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb6bff1d159ed6671296fd95a5d7ae4dbf60dfc9

Comment 17

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b5a8864f5a6c03dc43973d270d4494ecdd5a882

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d151a27de64
Honour system titlebar button left/right placement, r=dao

Comment 19

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7d151a27de64

Comment 20

[Richard Marti (:Paenglab)]

On Ubuntu 18.10 with the theme Yaru, and all other themes i have, and with Gnome Teaks placed the buttons on the left, every program moves the buttons to left except Firefox (today Nightly). Am I doing something wrong or this this worth a new bug?

Comment 21

[Philip Langdale]

The current heuristic of looking for where the 'menu' element is placed in the GTK layout doesn't work if there is no 'menu' element at all, and that seems pretty normal in contemporary distros. The default Ubuntu layout when reversed doesn't include it, nor does the GNOME default. (This is why comment #20 is not seeing it working). I think the heuristic needs to go a bit deeper and evaluate which elements are on the left and right of the ':' and then decide whether to treat it as reversed or not.

Comment 22

[Richard Marti (:Paenglab)]

Comment 20 is fixed for me since landing of bug 1521310.

Comment 23

[Philip Langdale]

Ah, I missed that. Glad it's already handled!