Port bug 1433667: Honour system titlebar button left/right placement on Linux

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 66.0
All
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 months ago

Bug 1433667 makes it possible to place the titlebar buttons (min/max/close) on the left side.

(Assignee)

Comment 1

4 months ago

This should do it. It doesn't break without the m-c patch.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9037698 - Flags: review?(geoff)
(Assignee)

Updated

4 months ago
Depends on: 1433667
(Assignee)

Comment 2

4 months ago

Now I was able to test this. This patch works now after changing two classes to IDs in the CSS.

Under Ubuntu it doesn't change the position automatically. But you can test this by setting a new string pref ui.GtkCSDReversedPlacement to 0.

Attachment #9037698 - Attachment is obsolete: true
Attachment #9037698 - Flags: review?(geoff)
Attachment #9037787 - Flags: review?(geoff)
Comment on attachment 9037787 [details] [diff] [review]
1521199-linux-titlebar-button-placement.patch

Review of attachment 9037787 [details] [diff] [review]:
-----------------------------------------------------------------

I can't make this work at all on 16.04, pref or no pref. Bug 1521310 says integer pref where you said string pref but that doesn't work for me either. 

That said, I don't have any concerns with the code changes, and it's not the fault of this patch that it doesn't work here, so r+, I guess.
Attachment #9037787 - Flags: review?(geoff) → review+
(Assignee)

Comment 4

4 months ago

Thanks. I have the "string" pref from an other bug and it works for me.

Keywords: checkin-needed

Comment 5

4 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1b078853f30d
Port bug 1433667: Honour system titlebar button left/right placement on Linux. r=darktrojan

Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

4 months ago
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.