1521199 - Port bug 1433667: Honour system titlebar button left/right placement on Linux

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Bug 1433667 makes it possible to place the titlebar buttons (min/max/close) on the left side.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1521199-linux-titlebar-button-placement.patch

This should do it. It doesn't break without the m-c patch.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1521199-linux-titlebar-button-placement.patch

Now I was able to test this. This patch works now after changing two classes to IDs in the CSS.

Under Ubuntu it doesn't change the position automatically. But you can test this by setting a new string pref ui.GtkCSDReversedPlacement to 0.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9037787 [details] [diff] [review]
1521199-linux-titlebar-button-placement.patch

Review of attachment 9037787 [details] [diff] [review]:
-----------------------------------------------------------------

I can't make this work at all on 16.04, pref or no pref. Bug 1521310 says integer pref where you said string pref but that doesn't work for me either. 

That said, I don't have any concerns with the code changes, and it's not the fault of this patch that it doesn't work here, so r+, I guess.

Comment 4

[Richard Marti (:Paenglab)]

Thanks. I have the "string" pref from an other bug and it works for me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1b078853f30d
Port bug 1433667: Honour system titlebar button left/right placement on Linux. r=darktrojan