Closed
Bug 1521199
Opened 5 years ago
Closed 5 years ago
Port bug 1433667: Honour system titlebar button left/right placement on Linux
Categories
(Thunderbird :: Theme, task)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file, 1 obsolete file)
3.46 KB,
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
Bug 1433667 makes it possible to place the titlebar buttons (min/max/close) on the left side.
Assignee | ||
Comment 1•5 years ago
|
||
This should do it. It doesn't break without the m-c patch.
Assignee | ||
Comment 2•5 years ago
|
||
Now I was able to test this. This patch works now after changing two classes to IDs in the CSS.
Under Ubuntu it doesn't change the position automatically. But you can test this by setting a new string pref ui.GtkCSDReversedPlacement to 0.
Attachment #9037698 -
Attachment is obsolete: true
Attachment #9037698 -
Flags: review?(geoff)
Attachment #9037787 -
Flags: review?(geoff)
Comment 3•5 years ago
|
||
Comment on attachment 9037787 [details] [diff] [review] 1521199-linux-titlebar-button-placement.patch Review of attachment 9037787 [details] [diff] [review]: ----------------------------------------------------------------- I can't make this work at all on 16.04, pref or no pref. Bug 1521310 says integer pref where you said string pref but that doesn't work for me either. That said, I don't have any concerns with the code changes, and it's not the fault of this patch that it doesn't work here, so r+, I guess.
Attachment #9037787 -
Flags: review?(geoff) → review+
Assignee | ||
Comment 4•5 years ago
|
||
Thanks. I have the "string" pref from an other bug and it works for me.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1b078853f30d
Port bug 1433667: Honour system titlebar button left/right placement on Linux. r=darktrojan
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 66.0
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•