1434288 - Update webrender to e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1433567 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ b6e69a8efbcd8dc3e0c0a8a9925e6a9355635de3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ea0e50f426552229ab5746ed3f5ab1c9ebf0561
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a84c52a5e2fb8ea537b36e3bb8e154a3771ab78

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 87c6a6ba7e75d8ed0b2ddeeb5fa4e363482f7f86

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7801945b00e7eac75e8bdf9d64869a9c284599de
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99f6ac25d94f3d05f682588f84aa4adac2fb565d

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c0c3731146b887aee16b7f84b01f12259299133
https://treeherder.mozilla.org/#/jobs?repo=try&revision=552b58431414a60cde3b5aee4828f06742932734

Bustage, but I need to apply martin's gecko-side ExternalClipId patches, presumably that will fix it.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56, with the fixes

https://treeherder.mozilla.org/#/jobs?repo=try&revision=62ab4844535a8ae2194ee6b7e43c1f9f05bb1511
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddc1c6e7c0cf06962d6cf3f2f3d543b9ce73b983

Looking good

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Gonna put the patches here just for convenience, in case anybody else wants them. I also need to rebase some other stuff on top of this so it makes it easier for me.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1434288 - Update webrender to commit e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56.

Review commit: https://reviewboard.mozilla.org/r/216936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216936/

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1434288 - Update gecko for API changes in WR PR 2315.

Review commit: https://reviewboard.mozilla.org/r/216938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216938/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8947166 [details]
Bug 1434288 - Update gecko for API changes in WR PR 2315.

https://reviewboard.mozilla.org/r/216938/#review222798

In addition to the correctness issue below I found a bunch of nits to clean up. I'm just going to do that locally rather than listing them all here.

::: gfx/webrender_bindings/WebRenderAPI.cpp:797
(Diff revision 1)
>    if (aAncestorClipId) {
>      ancestorClipId = &(aAncestorClipId.ref().id);
>    }
> +  const uint64_t* ancestorScrollId = nullptr;
> +  if (aAncestorScrollId) {
> +    ancestorClipId = &(aAncestorScrollId.ref().id);

This should be ancestorScrollId

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Here's a try push with my cleanups as well: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1c8eb40a089172e3eff6d678ab029627d201a1c

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Actually I might as well land this since otherwise rebasing gets trickier.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8947165 [details]
Bug 1434288 - Update webrender to commit e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216936/diff/1-2/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8947166 [details]
Bug 1434288 - Update gecko for API changes in WR PR 2315.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216938/diff/1-2/

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8947166 [details]
Bug 1434288 - Update gecko for API changes in WR PR 2315.

https://reviewboard.mozilla.org/r/216938/#review222834

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8947165 [details]
Bug 1434288 - Update webrender to commit e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56.

https://reviewboard.mozilla.org/r/216936/#review222856

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e99f6587c86e
Update webrender to commit e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/3940b5d8f135
Update gecko for API changes in WR PR 2315. r=kats

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e99f6587c86e
https://hg.mozilla.org/mozilla-central/rev/3940b5d8f135