Closed Bug 1434288 Opened 2 years ago Closed 2 years ago

Update webrender to e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1433567 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c0c3731146b887aee16b7f84b01f12259299133
https://treeherder.mozilla.org/#/jobs?repo=try&revision=552b58431414a60cde3b5aee4828f06742932734

Bustage, but I need to apply martin's gecko-side ExternalClipId patches, presumably that will fix it.
Gonna put the patches here just for convenience, in case anybody else wants them. I also need to rebase some other stuff on top of this so it makes it easier for me.
Comment on attachment 8947166 [details]
Bug 1434288 - Update gecko for API changes in WR PR 2315.

https://reviewboard.mozilla.org/r/216938/#review222798

In addition to the correctness issue below I found a bunch of nits to clean up. I'm just going to do that locally rather than listing them all here.

::: gfx/webrender_bindings/WebRenderAPI.cpp:797
(Diff revision 1)
>    if (aAncestorClipId) {
>      ancestorClipId = &(aAncestorClipId.ref().id);
>    }
> +  const uint64_t* ancestorScrollId = nullptr;
> +  if (aAncestorScrollId) {
> +    ancestorClipId = &(aAncestorScrollId.ref().id);

This should be ancestorScrollId
Attachment #8947166 - Flags: review-
Actually I might as well land this since otherwise rebasing gets trickier.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56
Comment on attachment 8947166 [details]
Bug 1434288 - Update gecko for API changes in WR PR 2315.

https://reviewboard.mozilla.org/r/216938/#review222834
Attachment #8947166 - Flags: review?(bugmail) → review+
Comment on attachment 8947165 [details]
Bug 1434288 - Update webrender to commit e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56.

https://reviewboard.mozilla.org/r/216936/#review222856
Attachment #8947165 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e99f6587c86e
Update webrender to commit e772c3cb8ea0a35e6477e9dc8dd2144e2de87b56. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/3940b5d8f135
Update gecko for API changes in WR PR 2315. r=kats
https://hg.mozilla.org/mozilla-central/rev/e99f6587c86e
https://hg.mozilla.org/mozilla-central/rev/3940b5d8f135
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.