Bug 1435746 (SM2492-RELNOTE)

Create/Update 2.49.2 Release Notes and website

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: frg, Assigned: frg)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(3 attachments, 2 obsolete attachments)

+++ This bug was initially created as a clone of Bug #1385792 +++

SeaMonkey 2.49.2 release builds are currently in progress
Alias: SM2492-RELNOTE
Just the skeleton copied over from 2.49.1
Posted patch 1435746-seamonkey-2492.patch (obsolete) — Splinter Review
Rip it apart :) Not sure if the fixed problems sections isn't too technical. Advice/corrections welcome. The release seems to be already complete in candidate so the earlier the better.

ewong does Bug 1259941 need to be addressed in this release? Any news about updates? I left the paragraph in for now.
Attachment #8948430 - Attachment is obsolete: true
Attachment #8948732 - Flags: review?(iann_bugzilla)
Attachment #8948732 - Flags: feedback?(stefanh)
Attachment #8948732 - Flags: feedback?(rsx11m.pub)
Attachment #8948732 - Flags: feedback?(ewong)
Attachment #8948732 - Flags: feedback?(antoine.mechelynck)
Comment on attachment 8948732 [details] [diff] [review]
1435746-seamonkey-2492.patch

I don't think it is too technical r=me
Attachment #8948732 - Flags: review?(iann_bugzilla) → review+
(In reply to Frank-Rainer Grahl (:frg) from comment #2)
> Created attachment 8948732 [details] [diff] [review]
> 1435746-seamonkey-2492.patch
> 
> Rip it apart :) Not sure if the fixed problems sections isn't too technical.
> Advice/corrections welcome. The release seems to be already complete in
> candidate so the earlier the better.
> 
> ewong does Bug 1259941 need to be addressed in this release? Any news about
> updates? I left the paragraph in for now.

that bug really isn't much of a priority, imo.  The updates are still the same.  manual.
Comment on attachment 8948732 [details] [diff] [review]
1435746-seamonkey-2492.patch

Sorry for slow reaction.

After looking at the patch in diff mode, nothing obviously objectionable strikes my mind but I don't find really qualified to judge this.

IOW, from my POV it's certainly not f- but I don't feel qualified to give f+. Seeing that you wrote it and that Ian gave you r+ is good enough for me.
Attachment #8948732 - Flags: feedback?(antoine.mechelynck)
Comment on attachment 8948732 [details] [diff] [review]
1435746-seamonkey-2492.patch

>+++ b/src/news.en.xml

>+The SeaMonkey project is proud to present SeaMonkey 2.49.2: The new *major*
>+release of the all-in-one Internet suite is

Technically, it's a "minor" release ("dot") only, security and bug fixes.  ;-)

>+<font size="+2" color="#ff0000"><b>Automatic upgrades from previous versions
>+are, for most configurations, disabled for this release. If you need to

I'm wondering if we still have to yell this <font size++ color><b> at the user like this, or if we could tune it down a bit here and elsewhere, depending on the level of attention needed in a particular occurrence?

>+++ b/src/releases/seamonkey2.49.2/index.en.html

>     <a href="https://archive.mozilla.org/pub/seamonkey/releases/2.49.*1*/distributed/inspector@mozilla.org.xpi">DOM Inspector 2.0.17.1</a>.

More a question for ewong: Should this be copied to releases/2.49.2/distributed as well to have the 2.49.2 release self-contained?

>+  <li>Under Linux using some themes the menulist- and history-dropmarker
>+    didn't show. It was actually there but only 1 pixel wide. The problem,
>+    tracked in
>+    <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1331208">bug 1331208</a>,
>+    has been fixed. As a result the dropmarker in the location bar is now also
>+    shown a little wider under Windows.

Users may confuse this with menu borders and arrows for menus on GTK3 per bug 1267982 and bug 1334679, which aren't fixed yet but don't seem to be mentioned anywhere in the relnotes.

Other than that, looks fine. Let's ship it!
Attachment #8948732 - Flags: feedback?(rsx11m.pub) → feedback+
Thanks, will look at the suggestions.

> I'm wondering if we still have to yell this <font size++ color><b> at the user like this,...

After doing the patch I noticed that we would end up with 2 places on the front place. I will remove the second one. 

Given how many people even seem to overlook the current notice we should better do not de-emphasize this :) Naybe for the next release if updates still not work.
Updated patch taking feedback from rsx11m into account. r+ from IanN retained.

> Technically, it's a "minor" release

Now a release.

> I'm wondering if we still have to yell this <font size++ color><b>

Yelling +1 not +2 now :) Removed the 2.49.1 one from the news page.

> Users may confuse this with menu borders and arrows for menus on GTK3

Moved the general bug up in the list. Fixed a lissing /li.

Minor corrections in the text.
Attachment #8948732 - Attachment is obsolete: true
Attachment #8948732 - Flags: feedback?(stefanh)
Attachment #8948732 - Flags: feedback?(ewong)
Attachment #8950059 - Flags: review+
Interdiff before I did the qrefresh. If someone could a brief grammar check I would be glad.
(In reply to Frank-Rainer Grahl (:frg) from comment #10)
> Interdiff before I did the qrefresh. If someone could a brief grammar check I would be glad.

LGTM, don't see anything wrong.
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/13fbcd9f5088af6895dd95981e93a5e1d248eba8

Now lets see if it needs a follow-up :)
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Forgot to mention the grippy patch.
Attachment #8951847 - Flags: review?(iann_bugzilla)
Comment on attachment 8951847 [details] [diff] [review]
1435746-grippies.patch

LGTM r=me
Attachment #8951847 - Flags: review?(iann_bugzilla) → review+
Product: Websites → SeaMonkey
You need to log in before you can comment on or make changes to this bug.