1436511 - Building libaom fails on ARMv7 GNU/Linux

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Playback, defect, P5)

Description

[Henri Sivonen (:hsivonen)]

When building with --disable-debug --enable-optimize --enable-release (didn't try debug) on ARMv7 GNU/Linux (Ubuntu 16.04 running on Chrome OS kernel thanks to Crouton), the build fails with:

7:58.60 make[4]: *** No rule to make target '../../third_party/aom/aom_dsp/arm/aom_convolve8_avg_neon_asm.asm.S', needed by 'aom_convolve8_avg_neon_asm.asm.o'.  Stop.
 7:58.60 make[4]: *** Waiting for unfinished jobs....
 7:58.85 /var/host/media/removable/gecko/gecko/mozilla-central-ea00596eb02e/config/recurse.mk:73: recipe for target 'media/libaom/target' failed
 7:58.85 make[3]: *** [media/libaom/target] Error 2

Comment 1

[Ralph Giles (:rillian)]

Sounds like the build system is expecting to do asm format conversion, which I don't think is necessary. Maybe the source lists aren't correct, or we need an config def check in moz.build.

armv7-linux-gnu isn't tier-1 and I don't have time to look at the moment, so I'm afraid this one is 'patches welcome'.

Comment 2

[Ralph Giles (:rillian)]

NB you can also pass --disable-av1 to configure in your builds as a work-around.

Comment 3

[johannkoenig]

All neon assembly has been removed from libaom:

commit 4e8027cce86aa451320a1997e5d42dd4d505be07
Author: Johann <[e-mail]>
Date:   Thu May 31 08:11:42 2018 -0700

    arm: remove unused assembly
    
    loopfilter and convolve functions are not hooked up.
    
    intrapred has intrinsic versions.
    
    Remove infrastructure for supporting arm assembly.
    
    Change-Id: Iba53a1a5433fe2ec39e28f886f26e2f479e22473

Comment 4

[tt_1]

good news is, there are plans to erradicate libaom and to replace it with dav1d

Comment 5

[Darkspirit]

Closing. This bug is P5 and bug 1635296 will remove libaom.