Closed Bug 1437269 Opened 6 years ago Closed 6 years ago

Port bug 1436508 to C-C: Massive Mozmill test failure on 2018-02-09: 98 failed Mozmill tests (Friday bustage)

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 60.0

People

(Reporter: jorgk-bmo, Assigned: aceman)

References

Details

(Whiteboard: [Thunderbird-testfailure: Z all])

Attachments

(4 files)

1437269.patch
11.88 KB, patch
jorgk-bmo
: review+
masayuki
: feedback+
Details | Diff | Splinter Review
1437269-cal.patch
5.19 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
1437269-kke.patch
904 bytes, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
1437269-cal2.patch
8.08 KB, patch
Fallen
: review+
Details | Diff | Splinter Review 
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/compose/test/unit/test_smtpProxy.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/imap/test/unit/test_imapProxy.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/local/test/unit/test_pop3Proxy.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/news/test/unit/test_nntpProxy.js | Test timed out

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-account-actions.js | test-account-actions.js::test_account_actions
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-account-port-setting.js | test-account-port-setting.js::test_account_port_setting
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-account-settings-infrastructure.js | test-account-settings-infrastructure.js::test_account_onchange_handler
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-archive-options.js | test-archive-options.js::test_save_archive_options
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-mail-account-setup-wizard.js | test-mail-account-setup-wizard.js::test_mail_account_setup
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-mail-account-setup-wizard.js | test-mail-account-setup-wizard.js::test_bad_password_uses_old_settings
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-mail-account-setup-wizard.js | test-mail-account-setup-wizard.js::test_remember_password
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\account\test-retest-config.js | test-retest-config.js::test_re_test_config
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\addrbook\test-address-book-panes.js | test-address-book-panes.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\addrbook\test-address-book-panes.js | test-address-book-panes.js::teardownModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\addrbook\test-address-book.js | test-address-book.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\addrbook\test-update-mailing-list.js | test-update-mailing-list.js::test_contact_in_mailing_list_updated
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-events.js | test-attachment-events.js::test_attachments_added_on_single
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-events.js | test-attachment-events.js::test_attachments_added_on_multiple
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-events.js | test-attachment-events.js::test_attachments_removed_on_single
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-events.js | test-attachment-events.js::test_attachments_removed_on_multiple
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-events.js | test-attachment-events.js::test_no_attachments_removed_on_none
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-events.js | test-attachment-events.js::test_attachment_renamed
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-events.js | test-attachment-events.js::test_no_attachment_renamed_on_blank
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_regular_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_detached_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_detached_attachment_with_missing_file
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_deleted_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_multiple_attachments
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_multiple_attachments_one_detached
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_multiple_attachments_one_detached_with_missing_file
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_multiple_attachments_one_deleted
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_multiple_attachments_all_detached
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_multiple_attachments_all_detached_with_missing_files
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment-menus.js | test-attachment-menus.js::test_multiple_attachments_all_deleted
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment.js | test-attachment.js::test_attachment_right_click_single
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment.js | test-attachment.js::test_attachment_right_click_multiple
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment.js | test-attachment.js::test_select_all_attachments_key
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment.js | test-attachment.js::test_delete_attachment_key
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\attachment\test-attachment.js | test-attachment.js::test_attachments_compose_menu
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testAnnualRecurrence.js | testAnnualRecurrence.js::testAnnualRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testBiweeklyRecurrence.js | testBiweeklyRecurrence.js::testBiweeklyRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testDailyRecurrence.js | testDailyRecurrence.js::testDailyRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testLastDayOfMonthRecurrence.js | testLastDayOfMonthRecurrence.js::testLastDayOfMonthRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testWeeklyNRecurrence.js | testWeeklyNRecurrence.js::testWeeklyNRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testWeeklyUntilRecurrence.js | testWeeklyUntilRecurrence.js::testWeeklyUntilRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testWeeklyWithExceptionRecurrence.js | testWeeklyWithExceptionRecurrence.js::testWeeklyWithExceptionRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-address-widgets.js | test-address-widgets.js::test_address_types
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_dismissal
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_with_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_aggressive_pref
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_no_send_now_sends
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_manual_automatic_attachment_reminder_interaction
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_vs_filelink_reminder
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_in_subject
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_in_subject_and_body
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_disabled_attachment_reminder
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_reminder_in_draft
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment-reminder.js | test-attachment-reminder.js::test_disabling_attachment_reminder
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_file_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_webpage_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_multiple_attachments
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_delete_attachments
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_rename_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_open_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_forward_raw_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-attachment.js | test-attachment.js::test_forward_b64_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-blocked-content.js | test-blocked-content.js::test_paste_file_urls
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-charset-edit.js | test-charset-edit.js::test_wrong_reply_charset
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-charset-edit.js | test-charset-edit.js::test_no_mojibake
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-charset-upgrade.js | test-charset-upgrade.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-draft-identity.js | test-draft-identity.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-draft-identity.js | test-draft-identity.js::teardownModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-drafts.js | test-drafts.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-eml-actions.js | test-eml-actions.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-focus.js | test-focus.js::test_f6_no_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-focus.js | test-focus.js::test_f6_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-focus.js | test-focus.js::test_ctrl_tab_no_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-focus.js | test-focus.js::test_ctrl_tab_attachment
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forward-headers.js | test-forward-headers.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forward-rfc822-attach.js | test-forward-rfc822-attach.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forward-utf8.js | test-forward-utf8.js::test_utf8_forwarding_from_opened_file
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forward-utf8.js | test-forward-utf8.js::test_utf8_forwarding_from_via_folder
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forwarded-content.js | test-forwarded-content.js::test_forwarded_subj
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forwarded-eml-actions.js | test-forwarded-eml-actions.js::test_reply_to_attached_eml
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forwarded-eml-actions.js | test-forwarded-eml-actions.js::test_forward_attached_eml
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-image-display.js | test-image-display.js::test_cid_image_load
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-image-display.js | test-image-display.js::test_cid_image_compose
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-image-insertion-dialog.js | test-image-insertion-dialog.js::test_image_insertion_dialog_persist
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-multipart-related.js | test-multipart-related.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-newmsg-compose-identity.js | test-newmsg-compose-identity.js::setupModule
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-addresses.js | test-reply-addresses.js::testReplyToMungedReplyToList
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-addresses.js | test-reply-addresses.js::testToCcReply
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-addresses.js | test-reply-addresses.js::testToCcReplyAll
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-addresses.js | test-reply-addresses.js::testToCcReplyAllInternational
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-addresses.js | test-reply-addresses.js::testToCcReplyWhenReplyToSet
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-addresses.js | test-reply-addresses.js::testToCcReplyAllWhenReplyToSet
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-addresses.js | test-reply-addresses.js::testReplyToList 

M-C last good: d49553765a743ebbd4f08e92a93c9d811e
M-C first bad: c2cddb0cbb20f02b839a6b7bfdbc1f766b
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d49553765a743ebbd4f08e92a93c9d811e&tochange=c2cddb0cbb20f02b839a6b7bfdbc1f766b
Ignore the four Xpcshell test failures at the beginning of comment #0, they belong in bug 1437270.
Briefly looking at
https://public-artifacts.taskcluster.net/FN2eGhzQTIaSsMyZ6G-e3w/0/public/logs/live_backing.log
I see:
INFO -    EXCEPTION: Components.interfaces.nsIDOMKeyEvent is undefined
INFO -      at: EventUtils.js line 1068
and later:
INFO -    EXCEPTION: KeyEvent is undefined
INFO -      at: EventUtils.js line 1199

So this is from bug 1436508. Aceman, looks like this one is for you.
Blocks: 1436508
Flags: needinfo?(acelists)
Summary: Massive Mozmill test failure on 2018-02-09: 98 failed Mozmill tests (Friday bustage) → Port bug 1436508 to C-C: Massive Mozmill test failure on 2018-02-09: 98 failed Mozmill tests (Friday bustage)
Attached patch 1437269.patch — — Splinter Review 
This seems to work:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fbf43bba7d5d4e0d3b32816f2bdce6b6b2708f68

Changes according to https://hg.mozilla.org/integration/mozilla-inbound/rev/b01bd36c3899
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Flags: needinfo?(acelists)
Attachment #8949977 - Flags: review?(jorgk)
Attachment #8949977 - Flags: feedback?(masayuki)
Possible fixes for calendar, untested.
Attachment #8949978 - Flags: review?(philipp)
Keywords: leave-open
Comment on attachment 8949977 [details] [diff] [review]
1437269.patch

Looks good. Why is it OK to remove the parameter defaulting |aWindow = window|?

I suppose the remaining test failure account\test-account-port-setting.js is unrelated and the calendar functions that won't work any more are not covered by tests.
Attachment #8949977 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) from comment #5)
> Comment on attachment 8949977 [details] [diff] [review]
> 1437269.patch
> 
> Looks good. Why is it OK to remove the parameter defaulting |aWindow =
> window|?

Somehow this file (in contrast to the m-c version) runs in way that there never is any 'window' defined. So I removed those defaults to not misleade us we have non-null aWindow in any case. Those defaults were copied from the m-c version where 'window' is defined. Due to this I also had to add the window argument to _computeKeyCodeFromChar() which makes us now to diverge from m-c in this part. I don't know why this happens, maybe that mozmill's EventUtils.js behaves like a jsm.
Comment on attachment 8949978 [details] [diff] [review]
1437269-cal.patch

I'm stealing this review. The existing code is 100% busted and this is the correct replacement.
Attachment #8949978 - Flags: review?(philipp) → review+
I've changed my mind about leaving this open.
Keywords: leave-open
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8c5c4421a947
port bug 1436508: replace use of nsIDOMKeyEvent with KeyboardEvent. r=jorgk
https://hg.mozilla.org/comm-central/rev/ec75a986c090
port bug 1436508: replace use of nsIDOMKeyEvent with KeyboardEvent (in calendar). r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I've pushed this now since we're not likely to get other reviews/feedback on the weekend and we're badly busted to a point where sheriffing is impossible.
Target Milestone: --- → Thunderbird 60.0
Running
mozmake SOLO_TEST=account/test-account-port-setting.js mozmill-one
the test passes for me. Oh, I'm at M-C rev c2cddb0cbb20.

So another bustage between c2cddb0cbb20 and currently a8e153c55eeee93a11e87d325fb20c6444.
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c2cddb0cbb20&tochange=a8e153c55eeee93a11e87d325fb20c6444

I'll file another bug.
Attachment #8949977 - Flags: feedback?(masayuki) → feedback+
You messed one now unused kKE
Attachment #8950052 - Flags: review?(jorgk)
Comment on attachment 8950052 [details] [diff] [review]
1437269-kke.patch

Grrr. Thanks! I'll get it landed.
Attachment #8950052 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fdbbb8fee229
Follow-up: Remove reference to nsIDOMKeyEvent (missed previously). r=jorgk DONTBUILD
Comment on attachment 8949978 [details] [diff] [review]
1437269-cal.patch

Review of attachment 8949978 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, I'd prefer we change this to use event.key instead since keyCode is also deprecated. aceman, can you prepare a patch?
(In reply to Philipp Kewisch [:Fallen]  from comment #15)
> Actually, I'd prefer we change this to use event.key instead since keyCode
> is also deprecated. aceman, can you prepare a patch?

No, sorry, I don't know what the difference is.
Flags: needinfo?(philipp)
(In reply to :aceman from bug 1438825 comment #8)
> May event.key be the key name we want?

Yes. I don't understand it, since event.keyCode is widely used in M-C:
https://searchfox.org/mozilla-central/search?q=event.keyCode+%3D&case=false&regexp=false&path=

event.key is not:
https://searchfox.org/mozilla-central/search?q=event.key+%3D&case=false&regexp=false&path=

Surely an integer comparison is also more efficient than a string compare.
event.key is a string name of the key, e.g. "Backspace", event.keyCode is 8 (probably event.DOM_VK_BACKSPACE).
So should I redo to compare the key names, per https://developer.mozilla.org/cs/docs/Web/API/KeyboardEvent/key/Key_Values ?
Yes, that would be super, thanks!

        Attachment #8951897 -
        Flags: review?(philipp)

    
    

    
  
Comment on attachment 8951897 [details] [diff] [review]
1437269-cal2.patch

Review of attachment 8951897 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

        Attachment #8951897 -
        Flags: review?(philipp) → review+
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---

    
  
Blocks: 1427481

    
    

    
  
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d491a134fae3
Follow-up: use event.key instead of event.keyCode at some places in Calendar. r=philipp
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: