1440014 - [css-text-decor-4] Implement text-decoration-width for controlling underline thickness

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement, P3)

Description

[Vincent Bernat]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180129103850

Steps to reproduce:

Use the following CSS:

a { text-decoration-width: 0.2em; }

As per:
 - https://github.com/w3c/csswg-drafts/issues/239#issuecomment-341840169
 - https://drafts.csswg.org/css-text-decor-4/#text-decoration-width-property


Actual results:

Underline stroke is still 1px.


Expected results:

Underline stroke should be around 3px.

Comment 1

[Emil Pasca [:emilpasca]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

I have tested this issue on Ubuntu 16.04 x64 and Windows 10 x64 with the latest Firefox release (58.0.2) and the latest Nightly (60.0a1-20180226100105) and haven't managed to reproduce it.

I have created the following test-case: https://jsfiddle.net/3b08o0zq/2/ and when inspecting the element the "text-decoration-width" propriety hasn't been aplied to the text.

Can you please provide a simplified test-case in order to better observe the issue you are describing?

Comment 2

[Vincent Bernat]

Hello Emil,

Yes, that's the current issue: Firefox doesn't recognize this property. This is a request to implement it.

Comment 3

[Emil Pasca [:emilpasca]]

Based on comment 2, I will assign the "Core: CSS Parsing and Computation" component for this issue.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Tantek, do we have any bug for tracking css-text-decor-4?

Comment 5

[Tantek Çelik]

Yes, added. In general we have bug shortnames for drafts.csswg.org path shortnames (like /css-text-decor-4). Feel free to needsinfo me if we seem to be missing any. Thanks!

Comment 6

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1440014: Part 1: Implemented rendering for text-decoration-width CSS property r?jfkthame

reftests will be added later

Comment 7

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1818fa24595126d1603b170a04cb90e6dc6ed286

Comment 8

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1440014: Part 2: Added reftests for text-decoration-width r?dholbert

Comment 9

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2f9053a82dd6aaef208c2d5a51f828aa8157ab8

Comment 10

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=108d470ef9bb8de9460e20d95dafea0b23e33bd5

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d82e7b564cec
Part 1: Implemented rendering for text-decoration-width CSS property r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/40986c1d78aa
Part 2: Added reftests for text-decoration-width r=dholbert

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d82e7b564cec
https://hg.mozilla.org/mozilla-central/rev/40986c1d78aa

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17715 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged