Closed Bug 1440014 Opened 6 years ago Closed 5 years ago

[css-text-decor-4] Implement text-decoration-width for controlling underline thickness

Categories

(Core :: Layout: Text and Fonts, enhancement, P3)

Product:
Core
Component:
Layout: Text and Fonts
Version:
58 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- wontfix
firefox69 --- fixed

People

(Reporter: bernat, Assigned: cmarlow)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: dev-doc-needed, Whiteboard: [layout:backlog:2019q3][wptsync upstream])

Attachments

(2 files)

Bug 1440014: Part 1: Implemented rendering for text-decoration-width CSS property r?jfkthame
47 bytes, text/x-phabricator-request
Details | Review
Bug 1440014: Part 2: Added reftests for text-decoration-width r?dholbert
47 bytes, text/x-phabricator-request
Details | Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180129103850

Steps to reproduce:

Use the following CSS:

a { text-decoration-width: 0.2em; }

As per:
 - https://github.com/w3c/csswg-drafts/issues/239#issuecomment-341840169
 - https://drafts.csswg.org/css-text-decor-4/#text-decoration-width-property


Actual results:

Underline stroke is still 1px.


Expected results:

Underline stroke should be around 3px.
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

I have tested this issue on Ubuntu 16.04 x64 and Windows 10 x64 with the latest Firefox release (58.0.2) and the latest Nightly (60.0a1-20180226100105) and haven't managed to reproduce it.

I have created the following test-case: https://jsfiddle.net/3b08o0zq/2/ and when inspecting the element the "text-decoration-width" propriety hasn't been aplied to the text.

Can you please provide a simplified test-case in order to better observe the issue you are describing?
Flags: needinfo?(bernat)
Hello Emil,

Yes, that's the current issue: Firefox doesn't recognize this property. This is a request to implement it.
Flags: needinfo?(bernat)
Based on comment 2, I will assign the "Core: CSS Parsing and Computation" component for this issue.
Status: UNCONFIRMED → NEW
status-firefox58: --- → affected
status-firefox59: --- → affected
status-firefox60: --- → affected
Component: Untriaged → CSS Parsing and Computation
Ever confirmed: true
Product: Firefox → Core
Version: 59 Branch → 58 Branch
Tantek, do we have any bug for tracking css-text-decor-4?
Component: CSS Parsing and Computation → Layout: Text
Flags: needinfo?(tantek)
Yes, added. In general we have bug shortnames for drafts.csswg.org path shortnames (like /css-text-decor-4). Feel free to needsinfo me if we seem to be missing any. Thanks!
Blocks: css-text-decor-4
URL: https://drafts.csswg.org/css-text-dec...
Flags: needinfo?(tantek)
Summary: Implement text-decoration-width for controlling underline thickness → [css-text-decor-4] Implement text-decoration-width for controlling underline thickness
Priority: -- → P3
Whiteboard: [layout:backlog:2019q3]
Type: defect → enhancement
Assignee: nobody → charles.w.marlow
Depends on: 1555865
Depends on: 1555863
No longer depends on: 1555865
Depends on: 1552062
Attachment #9070698 - Attachment description: Bug 1440014: Implemented text-decoration-width CSS property r?jfkthame,dholbert → Bug 1440014: Implemented text-decoration-width CSS property r?jfkthame
Attachment #9070698 - Attachment description: Bug 1440014: Implemented text-decoration-width CSS property r?jfkthame → Bug 1440014: Implemented rendering for text-decoration-width CSS property r?jfkthame
Blocks: 1558899
Attachment #9070698 - Attachment description: Bug 1440014: Implemented rendering for text-decoration-width CSS property r?jfkthame → Bug 1440014: Part 1: Implemented rendering for text-decoration-width CSS property r?jfkthame
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d82e7b564cec
Part 1: Implemented rendering for text-decoration-width CSS property r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/40986c1d78aa
Part 2: Added reftests for text-decoration-width r=dholbert

https://hg.mozilla.org/mozilla-central/rev/d82e7b564cec
https://hg.mozilla.org/mozilla-central/rev/40986c1d78aa

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17715 for changes under testing/web-platform/tests
Whiteboard: [layout:backlog:2019q3] → [layout:backlog:2019q3][wptsync upstream]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: