1555865 - adding support for text-decoration subproperty text-decoration-width (or rather, text-decoration-thickness) in the style system

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Charlie Marlow [:cmarlow]]

Adding support for the following spec: https://drafts.csswg.org/css-text-decor-4/#line-position
This property is also a longhand property. Support for this property is filed under bug 1555863.
This bug is specifically adding the subproperty 'text-decoration-width' to 'text-decoration'

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Wrong paste. :/

Comment 2

[Charlie Marlow [:cmarlow]]

Waiting on resolution for this spec issue: https://github.com/w3c/csswg-drafts/issues/3993

Comment 3

[Jen Simmons [:jensimmons]]

Testing text-decoration-thickness in this demo: https://codepen.io/jensimmons/pen/ZgzgWa?editors=1100
I realized that we are implementing the wrong name / the older name for this property. Currently text-decoration-width is what works in Nightly.

The property was named -width, and still is in the First Public Working Draft: https://www.w3.org/TR/css-text-decor-4/#text-decoration-width-property; but the CSSWG resolved to rename the property from text-decoration-width to text-decoration-thickness here:
https://github.com/w3c/csswg-drafts/issues/3118#issuecomment-432301016

And you can see the change in the Editor's Draft: https://drafts.csswg.org/css-text-decor-4/#text-decoration-width-property

Comment 4

[Daniel Holbert [:dholbert]]

I spun off bug 1567282 for comment 3.

Comment 5

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1555865: added text-decoration-thickness to the text-decoration shorthands r?emilio

Comment 6

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1555865: Part 2: Added reftests for text-decoration-skip-ink r?jfkthame

Comment 7

[Phabricator Automation]

Comment on attachment 9083133 [details]
Bug 1555865: Part 2: Added reftests for text-decoration-skip-ink r?jfkthame

Revision D40707 was moved to bug 1411922. Setting attachment 9083133 [details] to obsolete.

Comment 8

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c76961335eab9383b9e94e2655274e46ff7d97e5&selectedJob=260243546

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd2c60c98be9
added text-decoration-thickness to the text-decoration shorthands r=emilio

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18321 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cd2c60c98be9

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged