1555863 - adding support for text-decoration-width (longhands) to the style system

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Charlie Marlow [:cmarlow]]

Adding support for the following spec: https://drafts.csswg.org/css-text-decor-4/#line-position
This property is also a sub-property of text-decoration shorthand. Adding this feature will be included in a separate bug report.
This bug is specifically adding the longhand CSS property 'text-decoration-width'

Comment 1

[Charlie Marlow [:cmarlow]]

The shorthand feature bug report is in bug 1555865

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Presumably this should be enhancement

Comment 3

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1555863 added text-decoration-width support to style system including mochitests and web platform tests r?emilio,dholbert

from-font support will be added later

Comment 4

[Charlie Marlow [:cmarlow]]

https://hg.mozilla.org/try/rev/396951e932b5cafaebaa386cebf61c91edcfc53e

Comment 5

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7084f265edbe5fdcad3c0302e69e45c0c8edeb02

Comment 6

[Cosmin Sabou [:CosminS]]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp6xfedy\npatching file devtools/shared/css/generated/properties-db.js\nHunk #1 FAILED at 3189\nHunk #2 succeeded at 10738 with fuzz 1 (offset -3 lines).\n1 out of 2 hunks FAILED -- saving rejects to file devtools/shared/css/generated/properties-db.js.rej\npatching file devtools/server/actors/animation-type-longhand.js\nHunk #1 FAILED at 341\n1 out of 1 hunks FAILED -- saving rejects to file devtools/server/actors/animation-type-longhand.js.rej\nabort: patch failed to apply', '')

Comment 7

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f846b0129a26c79175e9dee9aab60bb67408b63f

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e6197f4291e
added text-decoration-width support to style system including mochitests and web platform tests r=emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17220 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5e6197f4291e

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged