Closed Bug 1555863 Opened 1 year ago Closed 1 year ago

adding support for text-decoration-width (longhands) to the style system

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: cmarlow, Assigned: cmarlow, Mentored)

References

Details

Attachments

(1 file)

Bug 1555863 added text-decoration-width support to style system including mochitests and web platform tests r?emilio,dholbert
47 bytes, text/x-phabricator-request
Details | Review

Adding support for the following spec: https://drafts.csswg.org/css-text-decor-4/#line-position
This property is also a sub-property of text-decoration shorthand. Adding this feature will be included in a separate bug report.
This bug is specifically adding the longhand CSS property 'text-decoration-width'

The shorthand feature bug report is in bug 1555865

Presumably this should be enhancement

Blocks: 1555865
Type: defect → enhancement
Summary: adding support for text-underline-width (longhands) to the style system → adding support for text-decoration-width (longhands) to the style system
Attachment #9069151 - Attachment description: Bug 1555863 added text-underline-width support to style system including mochitests and web platform tests r?emilio,dholbert → Bug 1555863 added text-decoration-width support to style system including mochitests and web platform tests r?emilio,dholbert
Depends on: 1555150, 1556041
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp6xfedy\npatching file devtools/shared/css/generated/properties-db.js\nHunk #1 FAILED at 3189\nHunk #2 succeeded at 10738 with fuzz 1 (offset -3 lines).\n1 out of 2 hunks FAILED -- saving rejects to file devtools/shared/css/generated/properties-db.js.rej\npatching file devtools/server/actors/animation-type-longhand.js\nHunk #1 FAILED at 341\n1 out of 1 hunks FAILED -- saving rejects to file devtools/server/actors/animation-type-longhand.js.rej\nabort: patch failed to apply', '')

Flags: needinfo?(charles.w.marlow)
Keywords: checkin-needed
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5e6197f4291e
added text-decoration-width support to style system including mochitests and web platform tests r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17220 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/5e6197f4291e

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.