1552062 - [css-text-decor-4] Implement text-underline-offset

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement, P3)

Description

[Sean Voisen (:svoisen)]

Text Decoration 4 introduces the text-underline-offset property for setting the offset of an underline from its normal position.

Comment 1

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1552062: Part 1: Added text underline offset member variable to LineDecorations struct r?jfkthame,emilio

Comment 2

[Charlie Marlow [:cmarlow]]

Part 1 - Added text underline offset member variable to LineDecorations struct
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18f1c690dbf077cc8ae38c43c6d48cb9eee55493
https://phabricator.services.mozilla.com/D33882

Comment 3

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1552062: Part 2: Implemented rendering for text-underline-offset in nsTextFrame r?jfkthame

Comment 4

[Charlie Marlow [:cmarlow]]

Part 2 - Adding implementation of text-underline-offset
https://phabricator.services.mozilla.com/D34019
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e24c4dd83a466946abeb8148f9247b52fd125593&selectedJob=250435614

Comment 5

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1552062: Part 3: Added reftests for text-underline-offset r?dholbert

Comment 6

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8756580f16063f06da32a2cba7fb5051a0445eb

Comment 7

[Daniel Holbert [:dholbert]]

Latest try run is https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ab9fe8865b2754f10dcbe1587742f1371422b8a and its test-failures look unrelated, so I went ahead and triggered autoland.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d78fbd5f029
Part 1: Added text underline offset member variable to LineDecorations struct r=dholbert
https://hg.mozilla.org/integration/autoland/rev/810c7587e8b4
Part 2: Implemented rendering for text-underline-offset in nsTextFrame r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/ca87f718ec92
Part 3: Added reftests for text-underline-offset r=dholbert

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17335 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3d78fbd5f029
https://hg.mozilla.org/mozilla-central/rev/810c7587e8b4
https://hg.mozilla.org/mozilla-central/rev/ca87f718ec92

Comment 13

[Sebastian Zartner [:sebo]]

I've added a note for this new property at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#text-underline-offset and created bug 1559762 to ship it once it's ready.

Sebastian