Closed Bug 1552062 Opened 3 months ago Closed 2 months ago

[css-text-decor-4] Implement text-underline-offset

Categories

(Core :: Layout: Text and Fonts, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: svoisen, Assigned: cmarlow)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

(Keywords: dev-doc-needed, Whiteboard: [layout:backlog:2019q3][wptsync upstream])

Attachments

(3 files)

Text Decoration 4 introduces the text-underline-offset property for setting the offset of an underline from its normal position.

Whiteboard: [layout:backlog:2019q3]
Assignee: nobody → charles.w.marlow
No longer depends on: 1555865
Attachment #9070117 - Attachment description: Bug 1552062: Part 1: Added text underline offset member variable to LineDecorations struct r?dholbert → Bug 1552062: Part 1: Added text underline offset member variable to LineDecorations struct r?dholbert,jfkthame
Attachment #9070372 - Attachment description: Bug 1552062: Part 2: Implemented text-underline-offset in nsTextFrame → Bug 1552062: Part 2: Implemented text-underline-offset in nsTextFrame r?dholbert,jfkthame
Blocks: 1440014
Attachment #9070372 - Attachment description: Bug 1552062: Part 2: Implemented text-underline-offset in nsTextFrame r?dholbert,jfkthame → Bug 1552062: Part 2: Implemented text-underline-offset in nsTextFrame r?jfkthame
Attachment #9070117 - Attachment description: Bug 1552062: Part 1: Added text underline offset member variable to LineDecorations struct r?dholbert,jfkthame → Bug 1552062: Part 1: Added text underline offset member variable to LineDecorations struct r?jfkthame,emilio
Attachment #9070372 - Attachment description: Bug 1552062: Part 2: Implemented text-underline-offset in nsTextFrame r?jfkthame → Bug 1552062: Part 2: Implemented rendering for text-underline-offset in nsTextFrame r?jfkthame

Latest try run is https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ab9fe8865b2754f10dcbe1587742f1371422b8a and its test-failures look unrelated, so I went ahead and triggered autoland.

Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d78fbd5f029
Part 1: Added text underline offset member variable to LineDecorations struct r=dholbert
https://hg.mozilla.org/integration/autoland/rev/810c7587e8b4
Part 2: Implemented rendering for text-underline-offset in nsTextFrame r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/ca87f718ec92
Part 3: Added reftests for text-underline-offset r=dholbert
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17335 for changes under testing/web-platform/tests
Whiteboard: [layout:backlog:2019q3] → [layout:backlog:2019q3][wptsync upstream]
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
Depends on: 1559762

I've added a note for this new property at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#text-underline-offset and created bug 1559762 to ship it once it's ready.

Sebastian

You need to log in before you can comment on or make changes to this bug.