[css-text-decor-4] Implement text-underline-offset
Categories
(Core :: Layout: Text and Fonts, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: svoisen, Assigned: cmarlow)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-needed, Whiteboard: [layout:backlog:2019q3][wptsync upstream])
Attachments
(3 files)
Text Decoration 4 introduces the text-underline-offset property for setting the offset of an underline from its normal position.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Part 1 - Added text underline offset member variable to LineDecorations struct
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18f1c690dbf077cc8ae38c43c6d48cb9eee55493
https://phabricator.services.mozilla.com/D33882
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Part 2 - Adding implementation of text-underline-offset
https://phabricator.services.mozilla.com/D34019
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e24c4dd83a466946abeb8148f9247b52fd125593&selectedJob=250435614
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Comment 7•5 years ago
|
||
Latest try run is https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ab9fe8865b2754f10dcbe1587742f1371422b8a and its test-failures look unrelated, so I went ahead and triggered autoland.
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d78fbd5f029 Part 1: Added text underline offset member variable to LineDecorations struct r=dholbert https://hg.mozilla.org/integration/autoland/rev/810c7587e8b4 Part 2: Implemented rendering for text-underline-offset in nsTextFrame r=jfkthame https://hg.mozilla.org/integration/autoland/rev/ca87f718ec92 Part 3: Added reftests for text-underline-offset r=dholbert
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17335 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
Comment 12•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3d78fbd5f029
https://hg.mozilla.org/mozilla-central/rev/810c7587e8b4
https://hg.mozilla.org/mozilla-central/rev/ca87f718ec92
Comment 13•5 years ago
|
||
I've added a note for this new property at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#text-underline-offset and created bug 1559762 to ship it once it's ready.
Sebastian
Description
•