Closed Bug 1444946 Opened 3 years ago Closed 3 years ago

Update webrender to 486ee5f3aefb0172c2c5703e19f833e63eb295b9

Categories

(Core :: Graphics: WebRender, enhancement, P3)

61 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1444380 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Alias: wr-future-update
Blocks: 1441667
MozReview-Commit-ID: 4SDcygeCQpm
Attachment #8959063 - Flags: review?(kinetik)
Kats,

The attached patch is needed in addition to updating audioipc to commit b.933866
Flags: needinfo?(bugmail)
Try run with extra patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0304f92a497ffce981a7ebeec90a6256f99567c4&selectedJob=168137359

Don't why xpcshell tests fail. They're passing locally.
Comment on attachment 8959063 [details] [diff] [review]
Add prefs to control audioipc client thread pool. r?kinetik

Review of attachment 8959063 [details] [diff] [review]:
-----------------------------------------------------------------

Need to link this bug with bug 1443930.

r+ with the changes I mentioned

::: dom/media/CubebUtils.cpp
@@ +479,5 @@
>      }
>    }
>  
> +  AudioIpcInitParams init_params;
> +  init_params.pool_size = Preferences::GetUint(PREF_AUDIOIPC_POOL_SIZE,

The Preferences API is main-thread only IIRC, so you'll need to pre-read via PrefChanged like the rest of the prefs in this file.

::: dom/media/MediaPrefs.h
@@ +200,5 @@
>    DECL_MEDIA_PREF("media.resume-bkgnd-video-on-tabhover",     ResumeVideoDecodingOnTabHover, bool, false);
>  
>    // Enable sandboxing support for cubeb
>    DECL_MEDIA_PREF("media.cubeb.sandbox",                      CubebSandbox, bool, false);
> +  DECL_MEDIA_PREF("media.audioipc.pool_size",                 AudioIpcPoolSize, uint32_t, 4);

These (like media.cubeb.sandbox) don't need to be here unless they're being used via the MediaPref API, which the current patch isn't doing.
Attachment #8959063 - Flags: review?(kinetik) → review+
Thanks for the patch! The try push is still all orange though. It might be better if I just update audioipc to the bincode update and then you guys can do another update at your leisure to include the constructor signature change.

Also right now the WR patch queue is stuck so I'm not sure when the bincode update will actually merge into WR. :/
Flags: needinfo?(bugmail)
WR @ 511e9d12aa1ad57949bd6c8fe856e4b2a9e5fccc

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4050998d75ecaaeca2048be6e45d1893ce2a4d82
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdeb3d9439a0dc969b47e2fd743c2fc595538448

Green

I'll probably do an update tomorrow. Unless it lands tonight it doesn't look like bincode-1.0 will make it in this one.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #10)
> Thanks for the patch! The try push is still all orange though. It might be
> better if I just update audioipc to the bincode update and then you guys can
> do another update at your leisure to include the constructor signature
> change.
> 
> Also right now the WR patch queue is stuck so I'm not sure when the bincode
> update will actually merge into WR. :/

Kats,  I'm happy if you want to update to just the bincode update and :kinetik and I can update the API changes in another bug.
Blocks: 1446233
Comment on attachment 8959063 [details] [diff] [review]
Add prefs to control audioipc client thread pool. r?kinetik

Obsoleting this patch
Attachment #8959063 - Attachment is obsolete: true
Alias: wr-future-update
Assignee: nobody → bugmail
No longer blocks: 1446233
Summary: Future webrender update bug → Update webrender to 486ee5f3aefb0172c2c5703e19f833e63eb295b9
Version: unspecified → 61 Branch
Comment on attachment 8959516 [details]
Bug 1444946 - Update reftest annotations for changes from WR PR 2523.

https://reviewboard.mozilla.org/r/228322/#review234150
Attachment #8959516 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8959515 [details]
Bug 1444946 - Update webrender to commit 486ee5f3aefb0172c2c5703e19f833e63eb295b9.

https://reviewboard.mozilla.org/r/228320/#review234152
Attachment #8959515 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0cf3b5e216da
Update webrender to commit 486ee5f3aefb0172c2c5703e19f833e63eb295b9. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/db3858c71406
Update reftest annotations for changes from WR PR 2523. r=jrmuizel
Blocks: 1441025
https://hg.mozilla.org/mozilla-central/rev/0cf3b5e216da
https://hg.mozilla.org/mozilla-central/rev/db3858c71406
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Blocks: 1442921
Blocks: 1441392
Update from comment 20 brought big perf improvements! \o/

== Change summary for alert #12210 (as of Fri, 16 Mar 2018 12:12:27 GMT) ==

Improvements:

 50%  Resident Memory linux64-qr opt stylo     2,785,834,440.55 -> 1,404,398,213.31
 34%  Heap Unclassified linux64-qr opt stylo   798,375,154.22 -> 527,144,509.74
 27%  Explicit Memory linux64-qr opt stylo     1,089,027,660.77 -> 793,254,100.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12210
By Bug 1447245 Comment 1, this seems to be culprit of Bug 1447245.
Depends on: 1447245
You need to log in before you can comment on or make changes to this bug.