Closed
Bug 1444946
Opened 6 years ago
Closed 6 years ago
Update webrender to 486ee5f3aefb0172c2c5703e19f833e63eb295b9
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1444380 +++ I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages. When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update". [1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Assignee | ||
Updated•6 years ago
|
Alias: wr-future-update
Assignee | ||
Comment 1•6 years ago
|
||
WR @ 4ccaede43b3944199f89a42f49093d93409c7f61 https://treeherder.mozilla.org/#/jobs?repo=try&revision=712b53d0feabbabbaaae1c51f7ccdf6d0dda3dc7 https://treeherder.mozilla.org/#/jobs?repo=try&revision=802478674a8174737ab727349dea32d4fc69466e Green
Assignee | ||
Comment 2•6 years ago
|
||
WR @ f5cf72c6196ec0a7743d9d626cdc360ec0c569a1 https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a102986a3fd9d3bc2aad198d5244cb7fc967b1c https://treeherder.mozilla.org/#/jobs?repo=try&revision=42164529c3460e3f76c69301eed9205d41a0cfc8 Green so far
Assignee | ||
Comment 3•6 years ago
|
||
WR @ 1de1c0c8efda98fd3450e74c915ea392a9996eaf https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd8ae9480fb28ff31b42a3eb415918d4240a9f23 https://treeherder.mozilla.org/#/jobs?repo=try&revision=f350f8993088bee96fe557c2ff1cb8ef83b18d83 Green so far
Assignee | ||
Comment 4•6 years ago
|
||
WR @ 50c0cad255092f48784d9a142ea2069b121e7c13 https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1c9ac9bf5f755d809d08ea81fc0536c179b2216 https://treeherder.mozilla.org/#/jobs?repo=try&revision=42dda8629f4bcc3321979dcc6ab16320daa1b973 Green so far
Assignee | ||
Comment 5•6 years ago
|
||
WR @ 50c0cad255092f48784d9a142ea2069b121e7c13 https://treeherder.mozilla.org/#/jobs?repo=try&revision=71bad4a9edb6ebe30ae86a3b70e563eebc5f9510 https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca0235f16a43ad79e23bd5b15c947e044a82d7fc Green
MozReview-Commit-ID: 4SDcygeCQpm
Attachment #8959063 -
Flags: review?(kinetik)
Kats, The attached patch is needed in addition to updating audioipc to commit b.933866
Flags: needinfo?(bugmail)
Try run with extra patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0304f92a497ffce981a7ebeec90a6256f99567c4&selectedJob=168137359 Don't why xpcshell tests fail. They're passing locally.
Comment 9•6 years ago
|
||
Comment on attachment 8959063 [details] [diff] [review] Add prefs to control audioipc client thread pool. r?kinetik Review of attachment 8959063 [details] [diff] [review]: ----------------------------------------------------------------- Need to link this bug with bug 1443930. r+ with the changes I mentioned ::: dom/media/CubebUtils.cpp @@ +479,5 @@ > } > } > > + AudioIpcInitParams init_params; > + init_params.pool_size = Preferences::GetUint(PREF_AUDIOIPC_POOL_SIZE, The Preferences API is main-thread only IIRC, so you'll need to pre-read via PrefChanged like the rest of the prefs in this file. ::: dom/media/MediaPrefs.h @@ +200,5 @@ > DECL_MEDIA_PREF("media.resume-bkgnd-video-on-tabhover", ResumeVideoDecodingOnTabHover, bool, false); > > // Enable sandboxing support for cubeb > DECL_MEDIA_PREF("media.cubeb.sandbox", CubebSandbox, bool, false); > + DECL_MEDIA_PREF("media.audioipc.pool_size", AudioIpcPoolSize, uint32_t, 4); These (like media.cubeb.sandbox) don't need to be here unless they're being used via the MediaPref API, which the current patch isn't doing.
Attachment #8959063 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 10•6 years ago
|
||
Thanks for the patch! The try push is still all orange though. It might be better if I just update audioipc to the bincode update and then you guys can do another update at your leisure to include the constructor signature change. Also right now the WR patch queue is stuck so I'm not sure when the bincode update will actually merge into WR. :/
Flags: needinfo?(bugmail)
Assignee | ||
Comment 11•6 years ago
|
||
WR @ 50c0cad255092f48784d9a142ea2069b121e7c13 https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6296c7223fb8fb2c14f536a6de9ae40b6916c79 https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5f117578cf6b1a07b4560850e9dabc01322c82d https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea680fb78e405f9a7f36f29c88a90f870ba9d080 https://treeherder.mozilla.org/#/jobs?repo=try&revision=24a5bf85814b59f010f36e9ddc1ebb92ed9d2d9a Green still
Assignee | ||
Comment 12•6 years ago
|
||
WR @ 511e9d12aa1ad57949bd6c8fe856e4b2a9e5fccc https://treeherder.mozilla.org/#/jobs?repo=try&revision=4050998d75ecaaeca2048be6e45d1893ce2a4d82 https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdeb3d9439a0dc969b47e2fd743c2fc595538448 Green I'll probably do an update tomorrow. Unless it lands tonight it doesn't look like bincode-1.0 will make it in this one.
Comment 13•6 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #10) > Thanks for the patch! The try push is still all orange though. It might be > better if I just update audioipc to the bincode update and then you guys can > do another update at your leisure to include the constructor signature > change. > > Also right now the WR patch queue is stuck so I'm not sure when the bincode > update will actually merge into WR. :/ Kats, I'm happy if you want to update to just the bincode update and :kinetik and I can update the API changes in another bug.
Assignee | ||
Comment 14•6 years ago
|
||
WR @ fefb2820f15d733cbddfcdac60ef10f616e83cc7 https://treeherder.mozilla.org/#/jobs?repo=try&revision=73a616c20849786f9a24d2475bc7e4b729c7fdfc https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b60e5fc4f3c673227b2e6ad4e38aa026768bbc9 Green WR @ 486ee5f3aefb0172c2c5703e19f833e63eb295b9 https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffc18f5a6585829ee73cb72e5fd56fbfd79936b6 https://treeherder.mozilla.org/#/jobs?repo=try&revision=40127f884bbba274f754542301c6eff38039e94d Green, except for R4 fuzz needed
Assignee | ||
Comment 15•6 years ago
|
||
Comment on attachment 8959063 [details] [diff] [review] Add prefs to control audioipc client thread pool. r?kinetik Obsoleting this patch
Attachment #8959063 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Alias: wr-future-update
Assignee: nobody → bugmail
No longer blocks: 1446233
Summary: Future webrender update bug → Update webrender to 486ee5f3aefb0172c2c5703e19f833e63eb295b9
Version: unspecified → 61 Branch
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 18•6 years ago
|
||
mozreview-review |
Comment on attachment 8959516 [details] Bug 1444946 - Update reftest annotations for changes from WR PR 2523. https://reviewboard.mozilla.org/r/228322/#review234150
Attachment #8959516 -
Flags: review?(jmuizelaar) → review+
Comment 19•6 years ago
|
||
mozreview-review |
Comment on attachment 8959515 [details] Bug 1444946 - Update webrender to commit 486ee5f3aefb0172c2c5703e19f833e63eb295b9. https://reviewboard.mozilla.org/r/228320/#review234152
Attachment #8959515 -
Flags: review?(jmuizelaar) → review+
Comment 20•6 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0cf3b5e216da Update webrender to commit 486ee5f3aefb0172c2c5703e19f833e63eb295b9. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/db3858c71406 Update reftest annotations for changes from WR PR 2523. r=jrmuizel
Comment 21•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0cf3b5e216da https://hg.mozilla.org/mozilla-central/rev/db3858c71406
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 22•6 years ago
|
||
Update from comment 20 brought big perf improvements! \o/ == Change summary for alert #12210 (as of Fri, 16 Mar 2018 12:12:27 GMT) == Improvements: 50% Resident Memory linux64-qr opt stylo 2,785,834,440.55 -> 1,404,398,213.31 34% Heap Unclassified linux64-qr opt stylo 798,375,154.22 -> 527,144,509.74 27% Explicit Memory linux64-qr opt stylo 1,089,027,660.77 -> 793,254,100.75 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12210
Comment 23•6 years ago
|
||
By Bug 1447245 Comment 1, this seems to be culprit of Bug 1447245.
You need to log in
before you can comment on or make changes to this bug.
Description
•