1445028 - about:preferences#general is broken if identity.fxaccounts.enabled=false on Firefox Developer Edition

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

From bug 1444564 comment 0,
> 'Firefox Developer Edition Updates' section doesn't work. 'Check for updates' 
> button causes error
> > TypeError: gAppUpdater is undefined  preferences:1:1
> It is because of bug 1434706.
> https://hg.mozilla.org/mozilla-central/diff/109cd0a34ffe/browser/components/preferences/in-content/main.js#l1.14

Comment 1

[Edouard Oger [:eoger]]

Sorry about that, patch incoming.

Comment 2

[Edouard Oger [:eoger]]

Attachment: Bug 1445028 - Hide sync-dev-edition-root properly if sync is disabled.

Review commit: https://reviewboard.mozilla.org/r/227416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227416/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8958468 [details]
Bug 1445028 - Hide sync-dev-edition-root properly if sync is disabled.

https://reviewboard.mozilla.org/r/227416/#review233206

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d6480b1c320
Hide sync-dev-edition-root properly if sync is disabled. r=jaws

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4d6480b1c320

Comment 6

[Edouard Oger [:eoger]]

Comment on attachment 8958468 [details]
Bug 1445028 - Hide sync-dev-edition-root properly if sync is disabled.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1434706
[User impact if declined]: about:preferences will be broken for users with Sync enabled even if not logged (aka 99% of the users) on Dev Edition.
[Is this code covered by automated tests?]: Don't think so.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: bug 1443593
[Is the change risky?]: No.
[Why is the change risky/not risky?]: These are fairly small changes.
[String changes made/needed]: -

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8958468 [details]
Bug 1445028 - Hide sync-dev-edition-root properly if sync is disabled.

regression fix for about:preferences on dev edition, beta60+, should be in 60.0b4

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5704da3fb8b7

Comment 9

[Ciprian Georgiu, Desktop QA]

I've reproduced this bug on DevEdition 60.0b2 (20180307142707) by setting the "identity.fxaccounts.enabled" pref to false and following the steps from comment 0.

I can no longer see this error: "TypeError: gAppUpdater is undefined  preferences:1:1", in the browser console after checking the updates via Check for updates button. Tested on DevEdition 60.0b5 (20180319175655) across platforms: Windows 10 x64, MacOS X 10.11 and Ubuntu 16.04 x64.

Comment 10

[Ciprian Georgiu, Desktop QA]

This bug is also verified as fixed, on DevEdition 61.0b10 (20180530184300) running Win 10 x64, macOS 10.13 and Ubuntu 16.04 x64.