1447490 - Stop using gcli commands for all toolbox optional buttons

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

A bunch of optional toolbox buttons are currently relying on gcli commands, whereas they could use regular actors to do that:

* Paintflashing
  https://searchfox.org/mozilla-central/source/devtools/client/definitions.js#514
  The real code that toggle the paint flashing, that should be moved to an actor is here:
  https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/paintflashing.js#46-78

* Screenshot
  https://searchfox.org/mozilla-central/source/devtools/client/definitions.js#569
  Relates to this whole module:
  https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/screenshot.js#80

* rulers
  https://searchfox.org/mozilla-central/source/devtools/client/definitions.js#576
  Relates to this piece of code:
  https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/rulers.js#67-94

* measure
  https://searchfox.org/mozilla-central/source/devtools/client/definitions.js#592
  Relates to a very similar piece of code to rulers, here:
  https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/measure.js#69-97

Note that gcli handles a bunch of client/server state synchronization and manage to keep the menu checkbox in the right state.

rulers and measure are both highlighters and may easily be converted to use:
toolbox.highlighterUtils.getHighlighterByType("RulersHighlighter|MeasuringToolHighlighter").show/hide()

Comment 1

[Alexandre Poirot [:ochameau]]

> * Screenshot

About screenshot, this would need coordination with bug 1447491 as it also involves the screenshot command.

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1447490 - replace GCLI toolbox buttons with highlighters and appropriate actors; r=ochameau

GCLI has been handling the state of our buttons as well as managing shared highlighters.
Since the gcli removal, we no longer share the rulers and measure with any other UI, so a location
for shared state is no longer needed.

Comment 3

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ea10bdf62fd3a1feaae082b9a372f672c660c9f

Patch takes care of ruler, measure, and paintflash.

Screenshots button has been handled in #1483173

Comment 4

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69b2370e153b545f80f379f80cf21a5dd730bea5

Comment 5

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=958cde9839bbd678525a80e6d2b977e7eda4ca18

Comment 6

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=89376ad26904d473d99d397d92559a2b21ac9a49

Comment 7

[Yulia Startsev [:yulia]]

the _correct_ try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=373b30cca4a6738f4ef0bf5aef07581bd89cb83b

Comment 8

[Alexandre Poirot [:ochameau]]

Comment on attachment 9001596 [details]
Bug 1447490 - replace GCLI toolbox buttons with highlighters and appropriate actors; r=ochameau

Alexandre Poirot [:ochameau] has approved the revision.

Comment 9

[Yulia Startsev [:yulia]]

latest try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d535a84840fc4945f8e8aac5278c75187b165655

Comment 10

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bc8a7943e2bc3a61e0f11972cdd5702f50bec7a&selectedJob=197218460

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/416ff8fc9760
replace GCLI toolbox buttons with highlighters and appropriate actors; r=ochameau

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/416ff8fc9760