1448404 - Upgrade Firefox 60 to use NSS 3.36.1

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Kai Engert (:KaiE:)]

We have a few regression bugs in NSS that should get fixed for Firefox 60, prior its release.

I suggest to fix them in a minor NSS 3.36.1 release (only selected bugfixes), and uplift it to the Firefox 60 Beta branch, in order to include it with both Firefox 60 and Firefox 60 ESR.

Comment 1

[Kai Engert (:KaiE:)]

The bugs so far are:
- bug 1447628
- bug 1278071

Comment 2

[Kai Engert (:KaiE:)]

try build of NSS_3_36_1_BETA1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1d34360fc46a6fdf489426394c2c5206c79e014

Comment 3

[Julien Cristau [:jcristau] (back April 22)]

Is there an ETA for 3.36.1?

Comment 4

[Kai Engert (:KaiE:)]

(In reply to Julien Cristau [:jcristau] from comment #3)
> Is there an ETA for 3.36.1?

It has been released today.

We're ready to uplift to beta.

Comment 5

[Kai Engert (:KaiE:)]

Attachment: 1448404-v1.patch

To update, execute the following commands:

sed -i 's/3.36,/3.36.1,/' old-configure.in
python client.py update_nss NSS_3_36_1_RTM

It will result in the attached changes.

Comment 6

[Kai Engert (:KaiE:)]

Comment on attachment 8966266 [details] [diff] [review]
1448404-v1.patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1447628, bug 1452670

[User impact if declined]: Deadlocks for smartcard users. Key file incompatibility with Windows.

[Is this code covered by automated tests?]: Yes.

[Has the fix been verified in Nightly?]: Yes

[Needs manual test from QE? If yes, steps to reproduce]:  No

[List of other uplifts needed for the feature/fix]: No

[Is the change risky?]: No

[Why is the change risky/not risky?]: Changes are limited to the small area of 
code that affects the bug.

[String changes made/needed]: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8966266 [details] [diff] [review]
1448404-v1.patch

Fix some regressions in NSS 3.36 shipping in Fx60. Approved for 60.0b11.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/83b358633328