1449904 - Rendering glitches/flickering for rotating element

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Magne Andersson]

Attachment: spin.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180328141001

Steps to reproduce:

The attached test case includes an element with border-radius and a dotted border. When its rotated using the rotate()-transform in an animation, significant rendering glitches appear. It occasionally causes some of the surrounding chrome to flicker as well.

I'm seeing this issue on a MacBook Pro (Early 2013) with Intel HD Graphics 4000 and a NVIDIA GeForce GT 650M, with both GPUs displaying the glitches.

Comment 1

[Magne Andersson]

Attachment: WebRender-rotating-flickering.webm

A screen recording showing the issue. Caution - includes rapid flickering.

Comment 2

[Darkspirit]

Attachment: Screenshot_20180329_151246.png

Comment 3

[Darkspirit]

Thin cross + sporadically appearing flickering white boxes.
mozregression --good 2017-12-05 --bad 2018-01-05 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://bug1449904.bmoattachments.org/attachment.cgi?id=8963545"
> 10:43.32 INFO: Last good revision: 3abc6abd34bf81eb3bd29f21630cbefa2f43947b
> 10:43.32 INFO: First bad revision: 9f8cde87eaa7a7b164c999a369b4835c7ec68e62
> 10:43.32 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3abc6abd34bf81eb3bd29f21630cbefa2f43947b&tochange=9f8cde87eaa7a7b164c999a369b4835c7ec68e62

2017-12-05
> 9f8cde87eaa7	Kartikaya Gupta — Bug 1422317 - Update reftest results from changes in WR PR 2150. r=jrmuizel
> 483371920adb	Kartikaya Gupta — Bug 1422317 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> 52277221fade	Kartikaya Gupta — Bug 1422317 - Update webrender to commit b7714b1d4348c00682b5643ea0e3f0b15adaeda5. r=jrmuizel

Regression range: https://github.com/servo/webrender/compare/e3dd85359580074f4ca4a554d9a3c85779f8de64...b7714b1d4348c00682b5643ea0e3f0b15adaeda5

-----

Partial fix: Searching for the moment when the thin cross went away.
mozregression --find-fix --bad 2018-01-05 --good 2018-03-28 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://bug1449904.bmoattachments.org/attachment.cgi?id=8963545"
> 10:26.61 INFO: First good revision: 8ccb0e9d9bbeeed7d7e4474849debd7d21b65971
> 10:26.61 INFO: Last bad revision: c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4
> 10:26.61 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4&tochange=8ccb0e9d9bbeeed7d7e4474849debd7d21b65971

2018-01-08
> 8ccb0e9d9bbe	Ethan Lin — Bug 1426116 - Update the reftest annotations after we fixed the webrender box shadow problem (WR PR 2261). r=kats
> ca6f08cff784	Kartikaya Gupta — Bug 1426116 - Update reftest results from WR PR 2262. r=jrmuizel
> a7f7b7350673	Kartikaya Gupta — Bug 1426116 - Update reftest results for changes from WR PR 2200. r=jrmuizel
> 39f6c70f793e	Kartikaya Gupta — Bug 1426116 - Regenerate FFI header and remove RGB8 references to go with changes in WR PR 2260. r=jrmuizel
> e37afa9046ed	Kartikaya Gupta — Bug 1426116 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> 7855af69185d	Kartikaya Gupta — Bug 1426116 - Update for changes in WR PR 2251. r=jrmuizel
> da9b75fc0866	Kartikaya Gupta — Bug 1426116 - Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e. r=jrmuizel

Fix range: https://github.com/servo/webrender/compare/1142dfc557c319119a5117450718c5b67a93cb9f...a422f907be948b92bf5c7003a01f7744391a795e

Comment 4

[Darkspirit]

Attachment: 2018-03-29_14-41-37.mp4

main profile, dark theme: It looks like a black(?) rotating rectangle is drawn on the penultimate tab, hiding parts of the tab title.

Comment 5

[Magne Andersson]

This case looks like another manifestation of the same issue, while showing the cause more clearly: https://rawgit.com/Zirro/03f0e2d19b087db29b1f069e014e3ee5/raw/0f32535d70e56185e01e4f9be860afc4dc4fec79/fireworks.html

The glitches seem to appear when the transformation extends the element outside the viewport. In the original test case, the flickering boxes don't show up if the element is given some margin.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Don't see if on Windows + Dell + Nvidia

Comment 7

[Darkspirit]

(In reply to Milan Sreckovic [:milan] (needinfo for best results) from comment #6)
> Don't see if on Windows + Dell + Nvidia
> 
> Priority: -- → P3

Win10 1803 (GeForce GTX 1060), 2560x1440 (Dell U2515H)
I see the white flickering box you can see in attachment 8963567 [details] and sometimes tab titles are partially disappearing in a flickering manner.

Comment 8

[Magne Andersson]

I can no longer reproduce these issues in either of the test cases with latest WebRender 

Comment 9

[Darkspirit]

mozregression --find-fix --bad 2018-05-01 --good 2018-06-12 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://bug1449904.bmoattachments.org/attachment.cgi?id=8963545'
> 15:39.09 INFO: First good revision: ebecd80e1816f33fab9cd4e62f3daecafe3d6ec8
> 15:39.09 INFO: Last bad revision: 70081a033f198ea3eceae6f85bee8c45abd8262f
> 15:39.09 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=70081a033f198ea3eceae6f85bee8c45abd8262f&tochange=ebecd80e1816f33fab9cd4e62f3daecafe3d6ec8

> ebecd80e1816	Kartikaya Gupta — Bug 1466549 - Update reftest annotation from WR PR 2795. r=Gankro
> 8fd78043032e	Kartikaya Gupta — Bug 1466549 - Update webrender to aff9f409f3d6a3518c38c1f7755657f564c1083a. r=Gankro

> WR @ 952521658aaf331e7b7382fb18ca1d8b7bfc9dc8
mozregression --repo try --launch 40544f7120e9f01c656464ec8903a915432740ff --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://bug1449904.bmoattachments.org/attachment.cgi?id=8963545'
good

Fix range: https://github.com/servo/webrender/compare/8e697f8cb1f1aab2e5f6b9b903eb7191340b10c5...952521658aaf331e7b7382fb18ca1d8b7bfc9dc8

presumably servo/webrender#2795