1461513 - Artifacts of broken dotted/dashed borders drawn on chrome.

Status: RESOLVED DUPLICATE of bug 1449904

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Attachment: history.png

This bug isn't exactly about https://github.com/servo/webrender/issues/2754 because I couldn't reproduce it like that.

A) 140% zoom: grey areas on the location bar background.
mozregression --good 2017-10-15 --bad 2017-12-15 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrendest.enabled:true gfx.webrender.layers-free:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
> 11:37.78 INFO: Last good revision: 1253b19c7200ca8552a57c46c0335171eab2280b
> 11:37.78 INFO: First bad revision: 4ecf1d9c1975c76b41a5f9fbf564e8693b26fcd5
> 11:37.78 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1253b19c7200ca8552a57c46c0335171eab2280b&tochange=4ecf1d9c1975c76b41a5f9fbf564e8693b26fcd5

> 4ecf1d9c1975	Kevin Chen — Bug 1409243 - Enable dotted and dashed border support for webrender; r=ethlin

---

B) Changed appearance: 140% zoom: Former grey areas are now normal location bar, but former normal areas are now just white and hide glyphs.
mozregression --good 2018-01-30 --bad 2018-03-30 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrendest.enabled:true gfx.webrender.layers-free:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
> 14:39.82 INFO: Last good revision: d49f13abd54ad351ee1665a639127f14b938bc25
> 14:39.82 INFO: First bad revision: 5eb19c81c7fd7d5ffbc3eac211cf20136c02c3d7
> 14:39.82 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d49f13abd54ad351ee1665a639127f14b938bc25&tochange=5eb19c81c7fd7d5ffbc3eac211cf20136c02c3d7

> 3a32ca63e380	Kartikaya Gupta — Bug 1439565 - Update webrender to commit 8a19316a733a484bf9bafb8257e3008b1418bfe4. r=jrmuizel
https://github.com/servo/webrender/compare/e8d2ffb404a85651fe08a6d09abbece9bd2b9182...8a19316a733a484bf9bafb8257e3008b1418bfe4

---

C) Changed appearance: Now it looks like the initial bug again.
mozregression --find-fix --bad 2018-04-01 --good 2018-04-16 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
> 7:04.39 INFO: First good revision: f0ef44027999330a69d31db01e654a22949e2726
> 7:04.39 INFO: Last bad revision: 9f436684f4f7425e7af421dec2ae39464ec34b2d
> 7:04.39 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9f436684f4f7425e7af421dec2ae39464ec34b2d&tochange=f0ef44027999330a69d31db01e654a22949e2726

> f20cbdbdc3ac	Kartikaya Gupta — Bug 1451453 - Update webrender to commit 092ada1154b72fe71d2f227a5df0239586d2323a. r=jrmuizel
https://github.com/servo/webrender/compare/941bf5ac998061689a1bcd18d417f1f315e41ae6...092ada1154b72fe71d2f227a5df0239586d2323a

---

D) Changed appearance: 140% zoom: text is visible, but it looks like a light-grey loading bar on 80% in the background.
mozregression --find-fix --bad 2018-04-17 --good 2018-04-30 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
> 7:55.47 INFO: First good revision: 25c5ae00eb5388349d20231d360c6b7710576afd
> 7:55.47 INFO: Last bad revision: 16a647445e5cd89ffbefb3f3a490acaaa4f8868e
> 7:55.47 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=16a647445e5cd89ffbefb3f3a490acaaa4f8868e&tochange=25c5ae00eb5388349d20231d360c6b7710576afd

> 2b40c075c18a	Kartikaya Gupta — Bug 1457241 - Update webrender to commit 4b65822a2f7e1fed246a492f9fe193ede2f37d74. r=jrmuizel

> WR @ 751236199b39bb8dac78522713133ca18c603fb3
mozregression --repo try --launch fd7c6d267128a62728e1a9c6afb2883b94bd7da4 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
C look

> WR @ b763b540bc80400bbd4b7ee24129f4cd98998682
mozregression --repo try --launch 91a8ffc2a53e5e4e70c7a2de3358bc5351cd0c02 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
D look

https://github.com/servo/webrender/compare/751236199b39bb8dac78522713133ca18c603fb3...b763b540bc80400bbd4b7ee24129f4cd98998682
Most likely https://github.com/servo/webrender/pull/2696.

---

A)
> mozregression --repo autoland --launch 4ecf1d9c1975c76b41a5f9fbf564e8693b26fcd5 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
B)
> mozregression --repo autoland --launch 5eb19c81c7fd7d5ffbc3eac211cf20136c02c3d7 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
C)
> mozregression --repo autoland --launch f0ef44027999330a69d31db01e654a22949e2726 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
D)
> mozregression --repo autoland --launch 25c5ae00eb5388349d20231d360c6b7710576afd --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'

Comment 1

[Darkspirit]

Martin touched it last in servo/webrender#2696.

Comment 2

[Darkspirit]

Attachment: 2018-05-15_01-46-55.mp4

Everything was good before bug 1409243 (last good: 1253b19c7200ca8552a57c46c0335171eab2280b).

Comment 3

[Darkspirit]

I think this test case is just a basic (and easier to reproduce) variant of bug 1449904.

Comment 4

[Darkspirit]

Attachment: Win10 1803 (GeForce GTX 1060), 2560x1440 (Dell U2515H).png

Comment 5

[Darkspirit]

mozregression --find-fix --bad 2018-05-01 --good 2018-06-12 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
> 10:59.16 INFO: First good revision: ebecd80e1816f33fab9cd4e62f3daecafe3d6ec8
> 10:59.16 INFO: Last bad revision: 70081a033f198ea3eceae6f85bee8c45abd8262f
> 10:59.16 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=70081a033f198ea3eceae6f85bee8c45abd8262f&tochange=ebecd80e1816f33fab9cd4e62f3daecafe3d6ec8

> ebecd80e1816	Kartikaya Gupta — Bug 1466549 - Update reftest annotation from WR PR 2795. r=Gankro
> 8fd78043032e	Kartikaya Gupta — Bug 1466549 - Update webrender to aff9f409f3d6a3518c38c1f7755657f564c1083a. r=Gankro

> WR @ 952521658aaf331e7b7382fb18ca1d8b7bfc9dc8
mozregression --repo try --launch 40544f7120e9f01c656464ec8903a915432740ff --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://rawgit.com/Zirro/c72becdcd5c05eb6547ad2cc9e5638aa/raw/dc6439f1d86c12430bc15c64afc914a68b32cc14/rounded-border.html'
good

Fix range: https://github.com/servo/webrender/compare/8e697f8cb1f1aab2e5f6b9b903eb7191340b10c5...952521658aaf331e7b7382fb18ca1d8b7bfc9dc8

presumably servo/webrender#2795

(But the dashed border still doesn't look like non-WR. I assume bug 1399485 is for that.)