1450448 - about:preferences#privacy>Site Data doesn't work if browser.cache.offline.enable=false

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[atlanto]

STR:
1. Set browser.cache.offline.enable to false in about:config
2. Restart firefox
3. Go to about:preferences#privacy -> Site Data

ER:
>Your stored site data is currently using ... MB of disk space
buttons enabled

AR:
>Calculating site data size…
buttons disabled

mozregression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=23eefaa8e71a10ec940f66f4d27ff32af9a0ce86&tochange=1bd9e6b07fc06336d9b4e43586850475648b905d

see also bug 795764, bug 1355795

Comment 1

[:Gijs (he/him)]

(In reply to atlanto from comment #0)
> STR:
> 1. Set browser.cache.offline.enable to false in about:config

Is having this pref really still valuable in 2018? Feels to me like it's the same kind of thing as turning frames off (which we removed in bug 1013457). Maybe the best way of ensuring this doesn't happen again is just to remove the pref. In any case, presumably setting the capacity to 0 would achieve the same thing (though I don't really understand what people's reason is for turning off the pref in the first place...).

Comment 2

[Johann Hofmann [:johannh]]

+1 for removing this pref

Comment 4

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
20180507191226

Reproducible regression. No point in leaving it unconfirmed.

Comment 5

[mr_whassup]

(In reply to :Gijs (he/him) from comment #1)

> (though I don't really understand what people's reason is for
> turning off the pref in the first place...).

It can be privacy related, I don't want sites and web applications to leave stuff on my local system, simple as that.

Comment 6

[Johann Hofmann [:johannh]]

I've noticed a bunch of people on social media and reddit run into this, so I'm bumping the priority. We can still decide to remove the pref later on, but we might want to fix the frontend problem first and possibly uplift to beta.

Comment 7

[Johann Hofmann [:johannh]]

Attachment: Bug 1450448 - Correctly handle non-initialized appCache in site data preferences.

Review commit: https://reviewboard.mozilla.org/r/244150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244150/

Comment 8

[:Gijs (he/him)]

Comment on attachment 8975942 [details]
Bug 1450448 - Correctly handle non-initialized appCache in site data preferences.

https://reviewboard.mozilla.org/r/244150/#review250110

r=me

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f41afd30127
Correctly handle non-initialized appCache in site data preferences. r=Gijs

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9f41afd30127

Comment 11

[Johann Hofmann [:johannh]]

Comment on attachment 8975942 [details]
Bug 1450448 - Correctly handle non-initialized appCache in site data preferences.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1348733
[User impact if declined]: Cookies and Site Data can't be managed and/or cleared in about:preferences when AppCache is disabled
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: See comment 0
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Absolutely not
[Why is the change risky/not risky?]: Adding a try-catch around a failing line of code.
[String changes made/needed]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8975942 [details]
Bug 1450448 - Correctly handle non-initialized appCache in site data preferences.

Simple patch which fixes the broken ability to manage cookies and site data if AppCache is disabled. Approved for 61.0b7.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab893afd788e

Comment 14

[Daniel Bodea [:danibodea]]

This issue is fixed in the latest Nightly (v62.0a1). 

Fix not yet landed in today's latest Firefox Beta (v61.0b6); Will check tomorrow in v61.0b7.

Comment 15

[Daniel Bodea [:danibodea]]

This issue is also validated in Firefox Beta v61.0b7. Uplift successful.

Comment 16

[Julien Cristau [:jcristau]]

Do you want to request uplift for 60.1esr?

Comment 17

[Johann Hofmann [:johannh]]

Comment on attachment 8975942 [details]
Bug 1450448 - Correctly handle non-initialized appCache in site data preferences.

[Approval Request Comment]
User impact if declined: Cookies and Site Data can't be managed and/or cleared in about:preferences when AppCache is disabled
Fix Landed on Version: 62 and uplifted to 61
Risk to taking this patch (and alternatives if risky):  Very low, we're just putting a try catch statement around some code, and it has baked successfully on Nightly and Beta
String or UUID changes made by this patch: None

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 8975942 [details]
Bug 1450448 - Correctly handle non-initialized appCache in site data preferences.

fix site data preferences ui when appcache is disabled, approved for 60.1esr

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/d6d4fa13e5c8

Comment 20

[Daniel Bodea [:danibodea]]

I have verified this issue on Windows 10, Ubuntu 16.04 and Mac OS X 10.12.6. This issue does not occur on Firefox ESR 60.0.2 CI build (ID:20180601011555). Uplift successful.