1450520 - flickering of Facebook blue bar

Status: VERIFIED FIXED

(Core :: Web Painting, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: recording of Facebook flickering

With a newly installed Firefox Nightly (2018-03-31) I'm getting flickering of the Facebook blue bar when mousing around the page.  See the attached video.

Comment 1

[Cameron McCormack (:heycam)]

Perhaps relatedly, I get similar flickering in the Bitwarden popup panel.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: recording of Bitwarden flickering

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Disable retained-dl better with overlay scrollbars

The previous attempt to disable retained-dl just for the scrolled frame didn't work, since we might have already decided not to rebuild OOF frames within the scrolled frame at the point that we added to the dirty area.

That results in the new list containing scrolled content, but not position:fixed content, and then the DAG no longer knows which is on top. It frequently gets it wrong, and things flicker.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cb041700c38
Disable retained display lists when we have overlay scrollbars, as the z-index of the scrollbar changes between paints. r=mstange

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for mochitest e-10s failures on layout/forms/test/test_bug1301290.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0cb041700c38f2f2a436252de179ac8ed6f299f3&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-searchStr=e10s&selectedJob=171409741

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=171409741&repo=mozilla-inbound&lineNumber=7939

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/1758267802e956446af295b0e6ef0b3bd4104a26

Comment 7

[Florens Verschelde :fvsch]

I think bug 1450434 might be a dupe of this one.

Comment 8

[Matt Woodrow (:mattwoodrow)]

The new patch in bug 1450360 should fix this.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

I'm still seeing this on espn.com today with m-c tip with the bar across the top showing scores.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Bug 1451971 was filed to track the ESPN issue.

Comment 13

[Timea Cernea [:tbabos][inactive]]

Unfortunately, I could not reproduce the issue after several attempts on different builds (20180403100105; 20180403170332; 201804032200400) as well as Latest Nightly 61.0a1 by checking the Facebook bar, Bitwarden popup panel as well as following the STR provided in the duplicate bug 1450911. 

Cameron: Can you please re-check the Facebook bar on the latest Nightly 61.0a1 build and confirm back the results? Any feedback regarding the flickering of the extensions (as you mentioned Bitwarden) would be also much appreciated.
Thank you.

Comment 14

[Cameron McCormack (:heycam)]

These are both fine now, thanks.

Comment 15

[Timea Cernea [:tbabos][inactive]]

Based on the feedback provided in Comment 14, I will close this issue as Verified Fixed.