Closed Bug 1455924 Opened 3 years ago Closed 2 years ago

Clean up Dark/Light theme CSS


(Firefox :: Theme, defect, P5)




Firefox 65
Tracking Status
firefox64 --- fixed
firefox65 --- fixed


(Reporter: ntim, Assigned: dao)


(Depends on 1 open bug)



(2 files, 1 obsolete file)

Some of it is covered by the theme work that has been done.
Priority: -- → P5
Duplicate of this bug: 1422510
Summary: Clean up compact theme CSS → Clean up Dark/Light theme CSS
Assignee: nobody → dao+bmo
Attachment #9020592 - Attachment is obsolete: true
Pushed by
Clean up Dark/Light theme CSS. r=ntim
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Blocks: 1503301
Blocks: 1503304
Blocks: 1503306
Comment on attachment 9020593 [details]
Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1368808

User impact if declined: I need this for bug 1503306, which I need for bug 1503022, which I'll want to uplift

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is pretty straightforward cleanup limited to our Dark and Light themes

String changes made/needed:
Attachment #9020593 - Flags: approval-mozilla-beta?
Comment on attachment 9020593 [details]
Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

[Triage Comment]
CSS fix-ups needed to unblock other work needed for 64. Approved for 64.0b6.
Attachment #9020593 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
Depends on: 1515331
You need to log in before you can comment on or make changes to this bug.