Clean up Dark/Light theme CSS

RESOLVED FIXED in Firefox 64

Status

()

defect
P5
normal
RESOLVED FIXED
Last year
6 months ago

People

(Reporter: ntim, Assigned: dao)

Tracking

(Depends on 1 bug)

unspecified
Firefox 65
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox64 fixed, firefox65 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Description

Last year
Some of it is covered by the theme work that has been done.
Comment hidden (mozreview-request)
Assignee

Updated

Last year
Priority: -- → P5
Reporter

Updated

Last year
Duplicate of this bug: 1422510
Assignee

Updated

8 months ago
Summary: Clean up compact theme CSS → Clean up Dark/Light theme CSS
Assignee

Updated

8 months ago
Assignee: nobody → dao+bmo
Attachment #9020592 - Attachment is obsolete: true

Comment 5

8 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/469e083ccd18
Clean up Dark/Light theme CSS. r=ntim

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/469e083ccd18
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee

Updated

8 months ago
Blocks: 1503301
Assignee

Updated

8 months ago
Blocks: 1503304
Assignee

Updated

8 months ago
Blocks: 1503306
Assignee

Comment 7

8 months ago
Comment on attachment 9020593 [details]
Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1368808

User impact if declined: I need this for bug 1503306, which I need for bug 1503022, which I'll want to uplift

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is pretty straightforward cleanup limited to our Dark and Light themes

String changes made/needed:
Attachment #9020593 - Flags: approval-mozilla-beta?
Comment on attachment 9020593 [details]
Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

[Triage Comment]
CSS fix-ups needed to unblock other work needed for 64. Approved for 64.0b6.
Attachment #9020593 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
Assignee

Updated

6 months ago
Depends on: 1515331
You need to log in before you can comment on or make changes to this bug.