1455924 - Clean up Dark/Light theme CSS

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P5)

Description

[Tim Nguyen :ntim]

Some of it is covered by the theme work that has been done.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1455924 - Cleanup compact theme CSS.

Review commit: https://reviewboard.mozilla.org/r/238756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238756/

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/469e083ccd18
Clean up Dark/Light theme CSS. r=ntim

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/469e083ccd18

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 9020593 [details]
Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1368808

User impact if declined: I need this for bug 1503306, which I need for bug 1503022, which I'll want to uplift

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is pretty straightforward cleanup limited to our Dark and Light themes

String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9020593 [details]
Bug 1455924 - Clean up Dark/Light theme CSS. r?ntim

[Triage Comment]
CSS fix-ups needed to unblock other work needed for 64. Approved for 64.0b6.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba949aea60af