1503306 - Properly set accentcolor and textcolor properties for Light and Dark themes

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

See https://phabricator.services.mozilla.com/D9998#inline-42762

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1503306 - Properly set accentcolor and textcolor properties for Light and Dark themes. r?ntim

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1f93e89556d
Properly set accentcolor and textcolor properties for Light and Dark themes. r=ntim

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e1f93e89556d

Comment 4

[PimpUigi]

Shouldn't the Dark Theme not get the accent color on the tabs bar though???
It makes sense with the Light Theme but then the Dark theme isn't really Dark anymore.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9021786 [details]
Bug 1503306 - Properly set accentcolor and textcolor properties for Light and Dark themes. r?ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1368808

User impact if declined: needed for bug 1503022

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): fairly straightforward cleanup

String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9021786 [details]
Bug 1503306 - Properly set accentcolor and textcolor properties for Light and Dark themes. r?ntim

theme/css fix, approved for 64.0b8

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/17c2c58a5328