1457787 - Remove feedIcon PNGs in favor of feed.svg

Status: RESOLVED DUPLICATE of bug 1477669

(Firefox :: Theme, enhancement, P3)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/search?q=feedIcon&case=false&regexp=false&path=

The jar.mn references + the files themselves can be removed.

The other references (CSS and JS) can be replaced with chrome://browser/skin/feed.svg

Comment 1

[Manish [:manishkk]]

what about these lines? 
https://searchfox.org/mozilla-central/source/browser/components/preferences/in-content/main.js#3207,3216,3225

I don't think so 'chrome://browser/skin/feed16.svg' will work?

Comment 2

[Tim Nguyen :ntim]

(In reply to Manish Kumar [:manishkk] from comment #1)
> what about these lines? 
> https://searchfox.org/mozilla-central/source/browser/components/preferences/
> in-content/main.js#3207,3216,3225
> 
> I don't think so 'chrome://browser/skin/feed16.svg' will work?

You can just use chrome://browser/skin/feed.svg

Comment 3

[Manish [:manishkk]]

(In reply to Tim Nguyen :ntim from comment #2)
> (In reply to Manish Kumar [:manishkk] from comment #1)
> > what about these lines? 
> > https://searchfox.org/mozilla-central/source/browser/components/preferences/
> > in-content/main.js#3207,3216,3225
> > 
> > I don't think so 'chrome://browser/skin/feed16.svg' will work?
> 
> You can just use chrome://browser/skin/feed.svg


but I think the correct path of 'feed.svg' is this-
https://searchfox.org/mozilla-central/search?q=path%3Afeed.svg&case=false&regexp=false&path=

Comment 4

[Tim Nguyen :ntim]

When Firefox is compiled, the url is changed to chrome://browser/skin/feed.svg.

If you type that link into your urlbar, you will see the correct icon appear.

Comment 5

[Manish [:manishkk]]

How can I test for these kinds of bugs? How can I ensure that what changes I did those are correct?
Any command?

Comment 6

[Tim Nguyen :ntim]

(In reply to Manish Kumar [:manishkk] from comment #5)
> How can I test for these kinds of bugs? How can I ensure that what changes I
> did those are correct?
> Any command?

The icon is used at different places in the UI:
- https://www.reddit.com/r/firefox/.rss
- about:preferences#general -> scroll down to "Applications"

You need to manually check if the icon is correctly replaced in both of these links.

Comment 7

[Jason Chapin]

Hi Tim,

Can I take this one too?

Thanks!

Comment 8

[Tim Nguyen :ntim]

Yeah, sure :) Please let me know if you have any questions.

Comment 9

[Jason Chapin]

So just to confirm, I should replace audoFeedIcon and videoFeedIcon with feed.svg as well?

Comment 10

[Tim Nguyen :ntim]

(In reply to Jason Chapin from comment #9)
> So just to confirm, I should replace audoFeedIcon and videoFeedIcon with
> feed.svg as well?

Yes.

Comment 11

[Jason Chapin]

I hit a snag, as part of bug 1491243 feed.svg was removed. Should I add it back, or how should I proceed if not?
thanks!
-jason

Comment 12

[Tim Nguyen :ntim]

(In reply to Jason Chapin from comment #11)
> I hit a snag, as part of bug 1491243 feed.svg was removed. Should I add it
> back, or how should I proceed if not?
> thanks!
> -jason

Hmm, it looks like bug 1477669 would also remove feedIcon.png/audioFeedIcon.png/videoFeedIcon.png, so I'm going to dupe to that one.

Let me know if you need help finding another good-first-bug. Sorry :(

Comment 13

[Jason Chapin]

NP, it was a learning experience at least :)
If you know of another good-first-bug please send it my way thanks!

Comment 14

[Tim Nguyen :ntim]

(In reply to Jason Chapin from comment #13)
> NP, it was a learning experience at least :)
> If you know of another good-first-bug please send it my way thanks!

You can try bug 1491614, bug 1457782 or bug 1451715.

You can look at this list if none of those 3 bugs interest you: https://codetribute.mozilla.org/projects/ff