1462923 - Tools -> Add-on Options not opening

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[vtol]

TB 62.0a1 (2018-05-19) (64-bit)
W10 1709 b16299.431

Tying to open Tools -> Add-on Options does nothing but producing this error :

"undefined mailWindowOverlay.js:3764:5
initAddonPrefsMenu chrome://messenger/content/mailWindowOverlay.js:3764:5
onpopupshowing chrome://messenger/content/messenger.xul:1:1"

Comment 1

[Wayne Mery (:wsmwk)]

Probably all related.

Comment 2

[Jorg K (CEST = GMT+2)]

Add-on options doesn't work for me and I see this in the debug console:

JavaScript strict warning: chrome://mozapps/content/preferences/fontbuilder.js,
line 46: ReferenceError: reference to undefined property "l10n"

Likely related to bug 1460721.

Comment 3

[:aceman]

I see none of the reported errors, but I can see the Addon options menuitem does not work, it does not even produce the "no addons found" item.

It seems the arguments to AddonManager.getAddonsByTypes() have changed and you now have to call it as:
let addons = await AddonManager.getAddonsByTypes(["extension"]);

So the initAddonPrefsMenu() function in mailWindowOverlay.js needs rewriting.

What would be a proper bootstrapped addon I can test it on?

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: [e-mail]

I use "Shrunked Image Resizer" 4.4.5 (attached, not on AMO) and "Single Domain" (https://addons.mozilla.org/nn-NO/thunderbird/addon/single-domain/).

Comment 5

[vtol]

Majority of extentions are not yet (marked for) compatibiity with TB62 and I am not sure which are properly bootstrapped. I would have thought Enigmail perhaps, though to be installed manually

Comment 6

[Jorg K (CEST = GMT+2)]

Not depending on the l10n and font chooser stuff from bug 1460721 according to comment #3. Just a "simple" M-C interface change that we didn't detect in any test.

Comment 7

[:aceman]

There is also a single occurrence of the old usage of AddonManager.getAddonsByTypes() in Seamonkey which needs to be converted at:
https://dxr.mozilla.org/comm-central/rev/51678c5b0b3edd827c57a70f1c5baf02d44acead/suite/common/viewApplyThemeOverlay.js#17

Comment 8

[:aceman]

Attachment: 1462923.patch

This fixes the call to the AddonManager.getAddonsByTypes() to use the new style and also adds a test for the Add-on options menu.
Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4109d3b43113b7dc6607dfcb2878d384bc64c6a4

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8981060 [details] [diff] [review]
1462923.patch

Review of attachment 8981060 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking this, but sadly you have a test failure now:
INFO -  SUMMARY-UNEXPECTED-FAIL | test-addons-mgr.js | test-addons-mgr.js::test_addon_prefs
INFO -    EXCEPTION: Timeout waiting for the content tab page to load.
INFO -      at: utils.js line 406
INFO -         TimeoutError utils.js:406 13
INFO -         waitFor utils.js:444 11

The simpler test worked:
https://hg.mozilla.org/try-comm-central/rev/c9f9e49c5b66b8769798ca2d5596666aef479dd3

In the next round, please fix the following nits.

Also, make it "Add-on Options" in the commit message and include the M-C bug we're following here. So:
Port bug xxx - fix arguments to AddonManager.getAddonsByTypes() to make Tools->Add-on Options work again. r=jorgk

::: mail/test/mozmill/content-tabs/test-addons-mgr.js
@@ +39,5 @@
>  }
> +
> +/**
> + * Bug 1462923
> + * Check if the "Tools->Addon Options" menu item works and shows our addon.

Nit. Add-on Options.

@@ +66,5 @@
> +  let tab = mc.tabmail.currentTabInfo;
> +  wait_for_content_tab_load(tab, "chrome://mozmill/content/prefs.xul", 10000);
> +  mc.tabmail.closeTab(tab);
> +}
> +// The test operates the main menu which is not accessible from mozmill on Mac.

Nit: Inconsistent spelling of MozMill.

Comment 10

[Jorg K (CEST = GMT+2)]

Attachment: c9f9e49c5b66b8769798ca2d5596666aef479dd3.patch - earlier version from try

(In reply to Jorg K (GMT+2) (bustage-fix and urgent reviews only) from comment #9)
> Also, ... include the M-C bug we're following here.
Bug 1454202 which already landed on mozilla61. So this will need beta uplift.

I'll land the working part now, if you want to enhance the test further, please send another short patch.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fbbf9402b861
Port bug 1454202: fix arguments to AddonManager.getAddonsByTypes() to make Tools->Add-on Options work again. r=jorgk DONTBUILD

Comment 12

[Jorg K (CEST = GMT+2)]

This will be ready for today's Daily. Landed after adding a comment from the other version.

Comment 13

[Jorg K (CEST = GMT+2)]

Comment on attachment 8981072 [details] [diff] [review]
c9f9e49c5b66b8769798ca2d5596666aef479dd3.patch - earlier version from try

Uplift to TB 61 beta, note that the landed version is slightly different.

Comment 14

[Jorg K (CEST = GMT+2)]

I guess wait_for_content_tab_load() didn't work since you forgot to add "option 3". I'll leave it to you to decide whether you want to do that or perhaps check for a window that opened.

Comment 15

[:aceman]

That may be the case. The mozmill prefs no longer open in a tab as I removed the optionsType=3 as you wanted :) But locally I had mozmill still with that directive so the test passes locally.
Can you try adding it back into install.rdf and re-pushing to try?

Comment 16

[Jorg K (CEST = GMT+2)]

Attachment: 1462923-follow-up.patch

Here you go, works locally. It happens to fast, that you can't see it.

Comment 17

[:aceman]

Comment on attachment 8981094 [details] [diff] [review]
1462923-follow-up.patch

Thanks.

Comment 18

[vtol]

62.0a1 (2018-05-28) (64-bit) is working for me. It seems to have cured bug #1462920 as well

Comment 19

[:aceman]

Attachment: 1462923-follow-up.patch v2

Check if the prefs dialog opens.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b9d4533863b6faaebc8079930adcf7739a583920

Comment 20

[Jorg K (CEST = GMT+2)]

Comment on attachment 8981262 [details] [diff] [review]
1462923-follow-up.patch v2

Works for me, thanks.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d6ef5265865e
Follow-up: Check that add-on options dialog really opens. r=jorgk

Comment 22

[Adam Roach [:abr]]

This seems to be an issue on Release 60 as well. Surely this is the kind of fix that gets uplifted to release?

Comment 23

[Jorg K (CEST = GMT+2)]

What is an issue on TB 60 ESR? "Tools -> Add-on Options" should be working there. It went broken in Thunderbird 62, which was never released, and also fixed there. No need to uplift anything.

If there is an issue in TB 60 ESR, please file a new bug and CC me.