1464312 - (bmo-undo-inactive) Write script to undo the INACTIVE changes on bugs

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

This is a single-purpose utility that specifically reverts the changes made by the bulk change in bug 1453539.

It's going to edit the bug history, unless the bug history has changed since the automation user last updated the bug.

Considering the consequences for a mistake here, we'll copy the prod DB to staging and have a test run there.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: PR

Comment 2

[Kris Maglione [:kmag]]

Please skip these components when you revert:

Toolkit: Add-on Manager
Toolkit: WebExtensions: *
Core: XPConnect

I've already re-triaged all of the INACTIVE bugs in these components and don't want to have to do it again.

Thanks

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: exclude list for kmag

This is what you expect to be excluded, correct?

Comment 4

[Dylan Hardison [:dylan] (he/him)]

And for marco, I'm excluding every bug in a component that you are the triage owner for,
which as a priority of P4 or P5. Correct?

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8980765 [details]
exclude list for kmag

Yup. Thanks.

Comment 6

[Marco Bonardo [:mak]]

(In reply to Dylan Hardison [:dylan] (he/him) from comment #4)
> And for marco, I'm excluding every bug in a component that you are the
> triage owner for,
> which as a priority of P4 or P5. Correct?

untriaged too, I can add those to my usual triage list.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

The actual running of the script will be tracked in a new bug (being written now)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Dylan, which components ended up being excluded from the revert script?  I was just checking and there were various Core bugs that were excluded because someone had commented on them after the INACTIVE resolution.  I reopened all the ones that were not in Core:XPConnect, but I'm not sure what components were excluded in the other products...

Comment 10

[David Lawrence [:dkl]]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #9)
> Dylan, which components ended up being excluded from the revert script?  I
> was just checking and there were various Core bugs that were excluded
> because someone had commented on them after the INACTIVE resolution.  I
> reopened all the ones that were not in Core:XPConnect, but I'm not sure what
> components were excluded in the other products...

https://github.com/mozilla-bteam/bmo/blob/master/scripts/undo.pl#L29

    AND NOT (
        triage_owner.login_name = '[e-mail]'
        AND bugs.priority IN ('P4', 'P5', '--')
    )
    AND NOT (
        product.name = 'Toolkit' AND component.name = 'Add-ons Manager'
    )
    AND NOT (
        product.name = 'Toolkit' AND component.name LIKE 'WebExtensions%'
    )
    AND NOT (
        product.name = 'Core' AND component.name = 'XPConnect'
    )

Comment 11

[Boris Zbarsky [:bzbarsky]]

Thank you.

So it looks like there are 18 bugs that are not in XPConnect, not the WebExtensions* components, not in Add-ons Manager, and don't have Marco as triage owner that were not reverted.

Spot-checking a few, it's not clear to me why they were not reverted.  For example, why was bug 1007527 not reverted?  Or bug 1147136?  I can obviously just reopen these 18 bugs, but kind of want to understand what happened with them.

Comment 12

[David Lawrence [:dkl]]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #11)
> Thank you.
> 
> So it looks like there are 18 bugs that are not in XPConnect, not the
> WebExtensions* components, not in Add-ons Manager, and don't have Marco as
> triage owner that were not reverted.
> 
> Spot-checking a few, it's not clear to me why they were not reverted.  For
> example, why was bug 1007527 not reverted?  Or bug 1147136?  I can obviously
> just reopen these 18 bugs, but kind of want to understand what happened with
> them.

Yes there were some (21) errors during the rollback process that we will need to deal with manually. Here is the list:

Error updating 1334986: skipping because most recent change newer than automation change
Error updating 1267494: skipping because most recent change newer than automation change
Error updating 1255928: skipping because most recent change newer than automation change
Error updating 1167352: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1164963: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1164017: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1157052: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1151960: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1147136: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1146594: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1144767: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1134902: DBD::mysql::db do failed: Unknown column 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at scripts/undo.pl line 106.
Error updating 1094959: skipping because most recent change newer than automation change
Error updating 1071311: skipping because most recent change newer than automation change
Error updating 1007527: DBD::mysql::db do failed: Unknown column 'cf_tracking_b2g' in 'where clause' [for Statement "UPDATE bugs SET cf_tracking_b2g = ? WHERE bug_id = ? AND cf_tracking_b2g = ?"] at scripts/undo.pl line 106.
Error updating 919711: skipping because most recent change newer than automation change
Error updating 909025: DBD::mysql::db do failed: Unknown column 'cf_status_seamonkey223' in 'where clause' [for Statement "UPDATE bugs SET cf_status_seamonkey223 = ? WHERE bug_id = ? AND cf_status_seamonkey223 = ?"] at scripts/undo.pl line 106.
Error updating 660069: skipping because most recent change newer than automation change
Error updating 646721: skipping because most recent change newer than automation change
Error updating 581877: skipping because most recent change newer than automation change
Error updating 344674: skipping because most recent change newer than automation change

Comment 18

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #12)
> Error updating 1334986: skipping because most recent change newer than
> automation change
> Error updating 1267494: skipping because most recent change newer than
> automation change
> Error updating 1255928: skipping because most recent change newer than
> automation change
> Error updating 1167352: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1164963: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1164017: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1157052: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1151960: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1147136: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1146594: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1144767: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1134902: DBD::mysql::db do failed: Unknown column
> 'cf_blocking_fennec' in 'where clause' [for Statement "UPDATE bugs SET
> cf_blocking_fennec = ? WHERE bug_id = ? AND cf_blocking_fennec = ?"] at
> scripts/undo.pl line 106.
> Error updating 1094959: skipping because most recent change newer than
> automation change
> Error updating 1071311: skipping because most recent change newer than
> automation change
> Error updating 1007527: DBD::mysql::db do failed: Unknown column
> 'cf_tracking_b2g' in 'where clause' [for Statement "UPDATE bugs SET
> cf_tracking_b2g = ? WHERE bug_id = ? AND cf_tracking_b2g = ?"] at
> scripts/undo.pl line 106.
> Error updating 919711: skipping because most recent change newer than
> automation change
> Error updating 909025: DBD::mysql::db do failed: Unknown column
> 'cf_status_seamonkey223' in 'where clause' [for Statement "UPDATE bugs SET
> cf_status_seamonkey223 = ? WHERE bug_id = ? AND cf_status_seamonkey223 = ?"]
> at scripts/undo.pl line 106.
> Error updating 660069: skipping because most recent change newer than
> automation change
> Error updating 646721: skipping because most recent change newer than
> automation change
> Error updating 581877: skipping because most recent change newer than
> automation change
> Error updating 344674: skipping because most recent change newer than
> automation change

These have all already been addressed by [e-mail] so these are good as they are.

dkl