1470506 - ctrl + click on job failures doesn't add it to the pinboard anymore

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Steps to reproduce:
1. Open treeherder, e.g. https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=82a9a1027e2be734ae8c6488f54c251181a962dc&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
2. Press the ctrl key and click on a failure.
Actual result on both production and stage: Nothing happens.
Expected result: failure added to classification pinboard (like when one presses the space key).
This works in a TH tab which I opened earlier today.

Comment 1

[Ed Morley [:emorley]]

I can reproduce locally. Bisecting shows this to be from bug 1450022.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Other regressions reported:
- Bottom box not resizable
- No scrollbars for bug suggestions area shown.
Let me know if you revert or those need new bugs.

Comment 3

[Ed Morley [:emorley]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #2)
> - Bottom box not resizable

This is bug 1468623.

> - No scrollbars for bug suggestions area shown.

There isn't a bug for this one yet - would you mind filing?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Ed Morley [:emorley] from comment #3)
> > - No scrollbars for bug suggestions area shown.
> 
> There isn't a bug for this one yet - would you mind filing?
Filed bug 1470517 - not sure if that is the behavior described by Ryan on IRC.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3711

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/04d248e4aeaf32eab55a3a89b378b418390760e0
Bug 1470506 - Fix ctrl+click to toggle pin job (#3711)