Open Bug 1471704 Opened 2 years ago Updated 29 days ago

Enable tiling on Linux for P-OMTP

Categories

(Core :: Graphics: Layers, enhancement, P3)

enhancement

Tracking

()

REOPENED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted][MemShrink:P2])

Attachments

(3 files)

This will need to wait to see what issues we get enabling OMTP on linux.

In the meantime, here is a try run [1]. I see no issues, just the expected unexpected-pass/fail reftest changes.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f7615c829f88d8bf68942b6e90d5a084bee800b
OMTP has been enabled on linux for a bit and there are no obvious issues. I'll let it sit for the rest of this week and then put up a patch to enable tiling.
Another try run to make sure nothing has changed [1]. I'll put up the patch soon.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c58ba036f6035c09a4129fc1148ed9b8704edf76&selectedJob=188118882
Comment on attachment 8992437 [details]
Bug 1471704 - Enable tiling on Linux.

https://reviewboard.mozilla.org/r/257302/#review264322
Attachment #8992437 - Flags: review?(nical.bugzilla) → review+
Comment on attachment 8992438 [details]
Bug 1471704 - Reftest annotation changes for tiling on linux.

https://reviewboard.mozilla.org/r/257304/#review264326
Attachment #8992438 - Flags: review?(nical.bugzilla) → review+
One other change, I ran into an assertion firing on try that seems to be related to a bad refcounting definition in CaptureTiledPaintState.
Comment on attachment 8992653 [details]
Bug 1471704 - Correct the refcounting definition for CaptureTiledPaintState.

https://reviewboard.mozilla.org/r/257520/#review264404
Attachment #8992653 - Flags: review?(nical.bugzilla) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/065a16bd6b0a
Correct the refcounting definition for CaptureTiledPaintState. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd6762c91fb
Enable tiling on Linux. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d9e6cdd630
Reftest annotation changes for tiling on linux. r=nical
It seems my try runs were only running linux64 and missed these failures. They look fuzzy to me. I'll update the reftest annotation patch.
Flags: needinfo?(rhunt)
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3369ced88432
Correct the refcounting definition for CaptureTiledPaintState. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e5f747ee223
Enable tiling on Linux. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/72725d9980b3
Reftest annotation changes for tiling on linux. r=nical
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f91522b88724
Reftest annotation changes for tiling on linux with webrender: set background-position tests as passing. r=me
Depends on: 1477444
Depends on: 1477226
Depends on: 1479498
Depends on: 1480139
If this was disabled in 1480139 for causing things (like 1477226), is it going to be re-enabled in 63?
Flags: needinfo?(rhunt)
No, there are no immediate plans to re-enable this. Someone would need to get the time to sort through the crashes, and there are higher priority things that need to be done.
Status: RESOLVED → REOPENED
Flags: needinfo?(rhunt)
Resolution: FIXED → ---
Per 1480139, comment 8 it looks like this was a memory win.
Whiteboard: [gfx-noted] → [gfx-noted][MemShrink]
Depends on: 1485712
This was a pretty big memory win, it would be nice to see it resurrected.
Whiteboard: [gfx-noted][MemShrink] → [gfx-noted][MemShrink:P2]

All the blockers have been solved. Time to resurrect this!

You need to log in before you can comment on or make changes to this bug.