1471704 - Enable tiling on Linux for P-OMTP

Status: REOPENED

(Core :: Graphics: Layers, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

This will need to wait to see what issues we get enabling OMTP on linux.

In the meantime, here is a try run [1]. I see no issues, just the expected unexpected-pass/fail reftest changes.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f7615c829f88d8bf68942b6e90d5a084bee800b

Comment 1

[Ryan Hunt [:rhunt]]

OMTP has been enabled on linux for a bit and there are no obvious issues. I'll let it sit for the rest of this week and then put up a patch to enable tiling.

Comment 2

[Ryan Hunt [:rhunt]]

Another try run to make sure nothing has changed [1]. I'll put up the patch soon.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c58ba036f6035c09a4129fc1148ed9b8704edf76&selectedJob=188118882

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1471704 - Enable tiling on Linux.

Review commit: https://reviewboard.mozilla.org/r/257302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257302/

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 1471704 - Reftest annotation changes for tiling on linux.

Review commit: https://reviewboard.mozilla.org/r/257304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257304/

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8992437 [details]
Bug 1471704 - Enable tiling on Linux.

https://reviewboard.mozilla.org/r/257302/#review264322

Comment 6

[Nicolas Silva [:nical]]

Comment on attachment 8992438 [details]
Bug 1471704 - Reftest annotation changes for tiling on linux.

https://reviewboard.mozilla.org/r/257304/#review264326

Comment 7

[Ryan Hunt [:rhunt]]

Attachment: Bug 1471704 - Correct the refcounting definition for CaptureTiledPaintState.

Review commit: https://reviewboard.mozilla.org/r/257520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257520/

Comment 8

[Ryan Hunt [:rhunt]]

Comment on attachment 8992437 [details]
Bug 1471704 - Enable tiling on Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257302/diff/1-2/

Comment 9

[Ryan Hunt [:rhunt]]

Comment on attachment 8992438 [details]
Bug 1471704 - Reftest annotation changes for tiling on linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257304/diff/1-2/

Comment 10

[Ryan Hunt [:rhunt]]

One other change, I ran into an assertion firing on try that seems to be related to a bad refcounting definition in CaptureTiledPaintState.

Comment 11

[Nicolas Silva [:nical]]

Comment on attachment 8992653 [details]
Bug 1471704 - Correct the refcounting definition for CaptureTiledPaintState.

https://reviewboard.mozilla.org/r/257520/#review264404

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/065a16bd6b0a
Correct the refcounting definition for CaptureTiledPaintState. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd6762c91fb
Enable tiling on Linux. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d9e6cdd630
Reftest annotation changes for tiling on linux. r=nical

Comment 13

[Andreea Pavel [:apavel]]

Backed out for failing css/css-transforms/transform3d-preserve3d-013.html

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e4d9e6cdd6307bd42b176d3e2f0ba66b7244aa38

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188592881&repo=mozilla-inbound&lineNumber=23285

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/5196c06ae5add254243c580b4489db7453809468

Comment 14

[Ryan Hunt [:rhunt]]

It seems my try runs were only running linux64 and missed these failures. They look fuzzy to me. I'll update the reftest annotation patch.

Comment 15

[Ryan Hunt [:rhunt]]

Here's a try run with updated reftest assertions.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=add553ef47fda5ffd979633628895ddc0a24477e

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3369ced88432
Correct the refcounting definition for CaptureTiledPaintState. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e5f747ee223
Enable tiling on Linux. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/72725d9980b3
Reftest annotation changes for tiling on linux. r=nical

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3369ced88432
https://hg.mozilla.org/mozilla-central/rev/3e5f747ee223
https://hg.mozilla.org/mozilla-central/rev/72725d9980b3

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f91522b88724
Reftest annotation changes for tiling on linux with webrender: set background-position tests as passing. r=me

Comment 19

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/f91522b88724

Comment 20

[David Durst [:ddurst]]

If this was disabled in 1480139 for causing things (like 1477226), is it going to be re-enabled in 63?

Comment 21

[Ryan Hunt [:rhunt]]

No, there are no immediate plans to re-enable this. Someone would need to get the time to sort through the crashes, and there are higher priority things that need to be done.

Comment 22

[(Out until Dec 9) Eric Rahm [:erahm]]

Per 1480139, comment 8 it looks like this was a memory win.

Comment 23

[(Out until Dec 9) Eric Rahm [:erahm]]

This was a pretty big memory win, it would be nice to see it resurrected.

Comment 24

[Olivier Duclos]

All the blockers have been solved. Time to resurrect this!