Closed
Bug 1471704
Opened 6 years ago
Closed 3 years ago
Enable tiling on Linux for P-OMTP
Categories
(Core :: Graphics: Layers, enhancement, P3)
Core
Graphics: Layers
Tracking
()
RESOLVED
WONTFIX
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: rhunt, Assigned: rhunt)
References
Details
(Whiteboard: [gfx-noted][MemShrink:P2])
Attachments
(3 files)
This will need to wait to see what issues we get enabling OMTP on linux. In the meantime, here is a try run [1]. I see no issues, just the expected unexpected-pass/fail reftest changes. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f7615c829f88d8bf68942b6e90d5a084bee800b
Assignee | ||
Comment 1•6 years ago
|
||
OMTP has been enabled on linux for a bit and there are no obvious issues. I'll let it sit for the rest of this week and then put up a patch to enable tiling.
Assignee | ||
Comment 2•6 years ago
|
||
Another try run to make sure nothing has changed [1]. I'll put up the patch soon. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c58ba036f6035c09a4129fc1148ed9b8704edf76&selectedJob=188118882
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8992437 [details] Bug 1471704 - Enable tiling on Linux. https://reviewboard.mozilla.org/r/257302/#review264322
Attachment #8992437 -
Flags: review?(nical.bugzilla) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8992438 [details] Bug 1471704 - Reftest annotation changes for tiling on linux. https://reviewboard.mozilla.org/r/257304/#review264326
Attachment #8992438 -
Flags: review?(nical.bugzilla) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•6 years ago
|
||
One other change, I ran into an assertion firing on try that seems to be related to a bad refcounting definition in CaptureTiledPaintState.
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8992653 [details] Bug 1471704 - Correct the refcounting definition for CaptureTiledPaintState. https://reviewboard.mozilla.org/r/257520/#review264404
Attachment #8992653 -
Flags: review?(nical.bugzilla) → review+
Comment 12•6 years ago
|
||
Pushed by rhunt@eqrion.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/065a16bd6b0a Correct the refcounting definition for CaptureTiledPaintState. r=nical https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd6762c91fb Enable tiling on Linux. r=nical https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d9e6cdd630 Reftest annotation changes for tiling on linux. r=nical
Comment 13•6 years ago
|
||
Backed out for failing css/css-transforms/transform3d-preserve3d-013.html Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e4d9e6cdd6307bd42b176d3e2f0ba66b7244aa38 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188592881&repo=mozilla-inbound&lineNumber=23285 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/5196c06ae5add254243c580b4489db7453809468
Flags: needinfo?(rhunt)
Assignee | ||
Comment 14•6 years ago
|
||
It seems my try runs were only running linux64 and missed these failures. They look fuzzy to me. I'll update the reftest annotation patch.
Flags: needinfo?(rhunt)
Assignee | ||
Comment 15•6 years ago
|
||
Here's a try run with updated reftest assertions. https://treeherder.mozilla.org/#/jobs?repo=try&revision=add553ef47fda5ffd979633628895ddc0a24477e
Comment 16•6 years ago
|
||
Pushed by rhunt@eqrion.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/3369ced88432 Correct the refcounting definition for CaptureTiledPaintState. r=nical https://hg.mozilla.org/integration/mozilla-inbound/rev/3e5f747ee223 Enable tiling on Linux. r=nical https://hg.mozilla.org/integration/mozilla-inbound/rev/72725d9980b3 Reftest annotation changes for tiling on linux. r=nical
Comment 17•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3369ced88432 https://hg.mozilla.org/mozilla-central/rev/3e5f747ee223 https://hg.mozilla.org/mozilla-central/rev/72725d9980b3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 18•6 years ago
|
||
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/f91522b88724 Reftest annotation changes for tiling on linux with webrender: set background-position tests as passing. r=me
Comment 19•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f91522b88724
Comment 20•6 years ago
|
||
If this was disabled in 1480139 for causing things (like 1477226), is it going to be re-enabled in 63?
Flags: needinfo?(rhunt)
Assignee | ||
Comment 21•6 years ago
|
||
No, there are no immediate plans to re-enable this. Someone would need to get the time to sort through the crashes, and there are higher priority things that need to be done.
Status: RESOLVED → REOPENED
Flags: needinfo?(rhunt)
Resolution: FIXED → ---
Comment 22•6 years ago
|
||
Per 1480139, comment 8 it looks like this was a memory win.
Whiteboard: [gfx-noted] → [gfx-noted][MemShrink]
Comment 23•6 years ago
|
||
This was a pretty big memory win, it would be nice to see it resurrected.
Whiteboard: [gfx-noted][MemShrink] → [gfx-noted][MemShrink:P2]
Comment 24•5 years ago
|
||
All the blockers have been solved. Time to resurrect this!
Updated•3 years ago
|
Status: REOPENED → RESOLVED
Closed: 6 years ago → 3 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•