Enable tiling on Linux for P-OMTP

RESOLVED FIXED in Firefox 63

Status

()

Core
Graphics: Layers
P3
normal
RESOLVED FIXED
24 days ago
23 hours ago

People

(Reporter: rhunt, Assigned: rhunt)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

24 days ago
This will need to wait to see what issues we get enabling OMTP on linux.

In the meantime, here is a try run [1]. I see no issues, just the expected unexpected-pass/fail reftest changes.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f7615c829f88d8bf68942b6e90d5a084bee800b
(Assignee)

Comment 1

12 days ago
OMTP has been enabled on linux for a bit and there are no obvious issues. I'll let it sit for the rest of this week and then put up a patch to enable tiling.
(Assignee)

Comment 2

5 days ago
Another try run to make sure nothing has changed [1]. I'll put up the patch soon.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c58ba036f6035c09a4129fc1148ed9b8704edf76&selectedJob=188118882
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

5 days ago
mozreview-review
Comment on attachment 8992437 [details]
Bug 1471704 - Enable tiling on Linux.

https://reviewboard.mozilla.org/r/257302/#review264322
Attachment #8992437 - Flags: review?(nical.bugzilla) → review+

Comment 6

5 days ago
mozreview-review
Comment on attachment 8992438 [details]
Bug 1471704 - Reftest annotation changes for tiling on linux.

https://reviewboard.mozilla.org/r/257304/#review264326
Attachment #8992438 - Flags: review?(nical.bugzilla) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 10

4 days ago
One other change, I ran into an assertion firing on try that seems to be related to a bad refcounting definition in CaptureTiledPaintState.

Comment 11

4 days ago
mozreview-review
Comment on attachment 8992653 [details]
Bug 1471704 - Correct the refcounting definition for CaptureTiledPaintState.

https://reviewboard.mozilla.org/r/257520/#review264404
Attachment #8992653 - Flags: review?(nical.bugzilla) → review+

Comment 12

4 days ago
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/065a16bd6b0a
Correct the refcounting definition for CaptureTiledPaintState. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd6762c91fb
Enable tiling on Linux. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d9e6cdd630
Reftest annotation changes for tiling on linux. r=nical
(Assignee)

Comment 14

4 days ago
It seems my try runs were only running linux64 and missed these failures. They look fuzzy to me. I'll update the reftest annotation patch.
Flags: needinfo?(rhunt)

Comment 16

3 days ago
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3369ced88432
Correct the refcounting definition for CaptureTiledPaintState. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e5f747ee223
Enable tiling on Linux. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/72725d9980b3
Reftest annotation changes for tiling on linux. r=nical

Comment 17

3 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3369ced88432
https://hg.mozilla.org/mozilla-central/rev/3e5f747ee223
https://hg.mozilla.org/mozilla-central/rev/72725d9980b3
Status: NEW → RESOLVED
Last Resolved: 3 days ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

Comment 18

2 days ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f91522b88724
Reftest annotation changes for tiling on linux with webrender: set background-position tests as passing. r=me

Updated

23 hours ago
Depends on: 1477444
You need to log in before you can comment on or make changes to this bug.