1473178 - about:newaddon is broken

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Geoff Lankow (:darktrojan)]

When a new addon is detected, Thunderbird should open a tab at about:newaddon?id=xyz@abc, but instead the "The address isn't valid" page is shown.

Comment 1

[Richard Marti (:Paenglab)]

This was removed in bug 1331521 three month ago in Add-ons Manager. Do we have code that points to this page?

Comment 2

[Jorg K (CEST = GMT+2)]

Try DXR? https://dxr.mozilla.org/comm-central/search?q=about%3Anewaddon&redirect=false

Yields:
mail/components/mailGlue.js
191 { contentPage: "about:newaddon?id=" + aAddon.id,

Fix welcome ;-) - Fortunately not affecting TB 60.

Comment 3

[Geoff Lankow (:darktrojan)]

I was about to post a patch removing the code which loads this non-existent page, but perhaps it would be better to restore the non-existent page instead, given that:

* Most of our extensions are going to continue to be legacy extensions for the time being.
* Creating a UI for webextension permissions is going to be difficult. Perhaps about:newaddon would even be a good starting point.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1473178-about-newaddon-2.diff

Reinstates about:newaddon, as it was before removal in https://hg.mozilla.org/mozilla-central/rev/c85fefa9248c . I've made some changes to handle our legacy extensions.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1473178-about-newaddon-diff.diff

These are the differences between the code that was removed from m-c, and the code I'm adding to c-c.

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 8995024 [details] [diff] [review]
1473178-about-newaddon-2.diff

I don't know who should review this. Feel free to pass it on.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995025 [details] [diff] [review]
1473178-about-newaddon-diff.diff

This patch looks somewhat less frightening, however, for a qualified review you'd need to understand all the bits, like what's the story with the listener, etc. Philipp would be the only reviewer who knows this stuff. So would you like to pile it into his queue?

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995024 [details] [diff] [review]
1473178-about-newaddon-2.diff

I couldn't win Aceman, so it will need to be Philipp.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8995024 [details] [diff] [review]
1473178-about-newaddon-2.diff

Review of attachment 8995024 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks fine. I'm not really happy about resurrecting removed code, but it seems this is reasonable.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7a59c0ecec8e
Reinstate about:newaddon. r=philipp DONTBUILD