1473927 - Load textbox.css and numberbox.css as document stylesheets

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[:Paolo Amadini]

This is part of the work tracked in bug 1470830.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1473927 - Load "textbox.css" as a document stylesheet.

Review commit: https://reviewboard.mozilla.org/r/255392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255392/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8990350 [details]
Bug 1473927 - Load "textbox.css" as a document stylesheet.

https://reviewboard.mozilla.org/r/255392/#review262258

Comment 3

[:Paolo Amadini]

Comment on attachment 8990350 [details]
Bug 1473927 - Load "textbox.css" as a document stylesheet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255392/diff/1-2/

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1473927 - Load textbox.css and numberbox.css as document stylesheets. r?paolo

Comment 5

[Dão Gottwald [:dao]]

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=75571297ea6e65b688d193c6aaa879dc51709ae0&newProject=try&newRev=357ab7505318411a2fdcf06382e50f82e152f66b

Comment 6

[:Paolo Amadini]

Ah, so what happened here is that only the second part of the patch in bug 1473928 landed, so the other bug only deals with the stylesheet clean up, but does not convert it to a document stylesheet. Updating the summary to reflect that we are doing it in this bug now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1f939f4f3b
Load textbox.css and numberbox.css as document stylesheets. r=paolo

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82b600b76a38
Load textbox.css and numberbox.css as document stylesheets. r=paolo

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This got backed out for build bustage (orphaned file pattern for the removed file):

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee7654dbc546241723d810176f476d0a74fc5c9b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=retry%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&group_state=expanded&revision=4b1f939f4f3be1dd74f069083032bc1ebd9ea2ff

Relanded it with the file pattern removed: https://hg.mozilla.org/integration/mozilla-inbound/rev/82b600b76a387c9740bfc88195c01fa2ec7d0163

Comment 10

[Arthur Iakab [arthur_iakab]]

The reland was backed out do to marionette failures.

Backed out changeset 82b600b76a38 (bug 1473927)for marionette failures on test_element_state_chrome.py CLOSED TREE
Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/30099402136048f69b93ac578acda6397b59f368
Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=204072478&revision=82b600b76a387c9740bfc88195c01fa2ec7d0163
Failure log:https://treeherder.mozilla.org/logviewer.html#?job_id=204074911&repo=mozilla-inbound

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96b560cb7df3
Load textbox.css and numberbox.css as document stylesheets. r=paolo

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/96b560cb7df3