STR: 1. Visit about:tabcrashed EXPECTED RESULTS Page content should be vertically centered. ACTUAL RESULTS Page content is not vertically centered -- it's just snapped to the top. This is a recent regression, with this regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b42a4a801685e9aa379c96b8741a4f03bc200da1&tochange=2835f9a114459f3328682b6301e2330783c350fc ...which just contains one commit: https://hg.mozilla.org/integration/autoland/rev/2835f9a11445 trisha — Bug 1463755 - Update the design of certificate error pages r=johannh It looks like that commit was meant to adjust one sort of error page, but it had fallout that broke other error pages (?)
about:restartrequired is similarly broken (snapped to the top) in current Nightly, and was working (centered) 10 days ago. I'm assuming it was broken by the same change.
Summary: about:tabcrashed page's content is no longer vertically centered → Various about: error pages' contents are no longer vertically centered (about:tabcrashed, about:restartrequired, ...)
status-firefox62: --- → unaffected
status-firefox63: --- → affected
tracking-firefox63: --- → ?
Assignee: nobody → guptatrisha97
Comment on attachment 8992685 [details] [diff] [review] bug1475025.patch Review of attachment 8992685 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but you can also remove the captive portal adjustment now, I think: https://searchfox.org/mozilla-central/source/browser/base/content/aboutNetError.js#181 r=me with that fixed :) Thanks!
Attachment #8992685 - Flags: review?(jhofmann) → review+
Attachment #8992685 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/b28ca0001c8e Vertically center the various error pages r=johannh
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
status-firefox61: --- → unaffected
status-firefox-esr52: --- → unaffected
status-firefox-esr60: --- → unaffected
[Clarifying summary to make it clearer how this differed from new bug 1476944 which is also about these pages' vertical centering]
Summary: Various about: error pages' contents are no longer vertically centered (about:tabcrashed, about:restartrequired, ...) → Various about: error pages' contents are no longer vertically centered (and instead are snapped to top) (about:tabcrashed, about:restartrequired, ...)
I have reproduced this bug with Nightly 63.0a1 (2018-07-11) on Windows 10, 64 Bit! This bug's fix is verified with latest Nightly! Build ID 20180730100211 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
QA Whiteboard: [bugday-20180725]
7 months ago
Depends on: 1483642
Marking as GFV since it's an easy thing to verify.
Whiteboard: [good first verify]
The issue is no longer reproducible on Firefox 63.0b10 (build ID). Tests were performed under Windows 10x64, [testday-20180928]
You need to log in before you can comment on or make changes to this bug.