1475025 - Various about: error pages' contents are no longer vertically centered (and instead are snapped to top) (about:tabcrashed, about:restartrequired, ...)

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit about:tabcrashed

EXPECTED RESULTS
Page content should be vertically centered.

ACTUAL RESULTS
Page content is not vertically centered -- it's just snapped to the top.


This is a recent regression, with this regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b42a4a801685e9aa379c96b8741a4f03bc200da1&tochange=2835f9a114459f3328682b6301e2330783c350fc

...which just contains one commit:
https://hg.mozilla.org/integration/autoland/rev/2835f9a11445
trisha — Bug 1463755 - Update the design of certificate error pages r=johannh

It looks like that commit was meant to adjust one sort of error page, but it had fallout that broke other error pages (?)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering (centered)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of current/broken rendering (not centered)

Comment 3

[Daniel Holbert [:dholbert]]

about:restartrequired is similarly broken (snapped to the top) in current Nightly, and was working (centered) 10 days ago.  I'm assuming it was broken by the same change.

Comment 5

[Trisha Gupta [:trisha]]

Attachment: bug1475025.patch

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8992685 [details] [diff] [review]
bug1475025.patch

Review of attachment 8992685 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but you can also remove the captive portal adjustment now, I think: https://searchfox.org/mozilla-central/source/browser/base/content/aboutNetError.js#181

r=me with that fixed :)

Thanks!

Comment 7

[Trisha Gupta [:trisha]]

Attachment: bug1475025.patch

Done, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b28ca0001c8e
Vertically center the various error pages r=johannh

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b28ca0001c8e

Comment 10

[Daniel Holbert [:dholbert]]

[Clarifying summary to make it clearer how this differed from new bug 1476944 which is also about these pages' vertical centering]

Comment 11

[Md Maruf Rahman]

I have reproduced this bug with Nightly 63.0a1 (2018-07-11) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180730100211
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Comment 12

[Cristian Fogel [:cfogel]]

Marking as GFV since it's an easy thing to verify.

Comment 13

[Shweta]

The issue is no longer reproducible on Firefox 63.0b10 (build ID). Tests were performed under Windows 10x64,


[testday-20180928]