1476224 - Update the Tracking Protection section in the main menu for Content Blocking

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

Design spec is here:

https://mozilla.invisionapp.com/share/VSMVD99JK6D#/screens/301705296

63 is introducing a new "content blocking" mode that takes the place of tracking protection and demotes it to a category of content blocking. This will be behind a pref for now, which means the UI has to be able to fit both for the old TP content as well as the new Content Blocking.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1476224 - Update the Tracking Protection section in the main menu for Content Blocking. r=nhnt11

Comment 2

[Johann Hofmann [:johannh]]

Note that this depends on the changes from bug 1476218, so it's probably best to review that one first.

Thanks!

Comment 3

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b28a509be039874a11479ebf2bed0117f540ae62

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8998680 [details]
Bug 1476224 - Update the Tracking Protection section in the main menu for Content Blocking. r=nhnt11

Nihanth Subramanya [:nhnt11] has approved the revision.

Comment 5

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d37900b25bf2e7164ed13e3d6e88bd1bec4e87b

Comment 6

[Johann Hofmann [:johannh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7e288a6599d1f8e7bec7e4f9f764e73812371fb
Bug 1476224 - Update the Tracking Protection section in the main menu for Content Blocking. r=nhnt11

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d7e288a6599d

Comment 8

[Darkspirit]

Content Blocking is enabled by default, but doesn't do anything in non-private Mode by default.

The main menu entry recommended users to enable Tracking Protection. Now the term "Tracking Proctection" is again only present on about:preferences#privacy and less accessible.
It should be changed back to flip Tracking Protection, as it currently rather advertises to disable Content Blocking (which might not sound well to everyone; bug 1481233 comment 2).

The identity panel's "Add Blocking" link sounds like a feature to manually add blacklist rules and not to enable TP itself.
The identity panel's "Disable Blocking For This Site" button does not disable anything by default, as Content Blocking is enabled without function.

Comment 9

[Johann Hofmann [:johannh]]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> Content Blocking is enabled by default, but doesn't do anything in
> non-private Mode by default.

That will be fixed when we enable FastBlock (e.g. in bug 1480443 for Nightly)

> It should be changed back to flip Tracking Protection, as it currently
> rather advertises to disable Content Blocking (which might not sound well to
> everyone; bug 1481233 comment 2).
> 
> The identity panel's "Add Blocking" link sounds like a feature to manually
> add blacklist rules and not to enable TP itself.
> The identity panel's "Disable Blocking For This Site" button does not
> disable anything by default, as Content Blocking is enabled without function.

Thank you for your feedback, I'll forward it to the UX team.

Comment 10

[Darkspirit]

Firefox 62 has been released on 2018-09-05.
Look what has happened since then ("Always On Tracking Protection"): https://data.firefox.com/dashboard/usage-behavior
This bug will likely regress latest achievement. I haven't found any explanation or feedback from UX (bug 1490388 comment 1). :-/