1477506 - Lightning disappears from sight and its presence can only be seen in add-ons manager and options. Ugly workaround: Disable, restart, enable, restart

Status: RESOLVED FIXED

(MailNews Core :: XUL Replacements, defect)

Description

[mgrandfield]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180721100146

Steps to reproduce:

Install: Thunderbird Daily 63.0a1 (2018-07-21) 64-bit.
Goto: Tools/Add-ons/Extensions and ENABLE Lightning
Restart Thunderbird (prompted)




Actual results:

On initial (prompted) Restart, Lightning is enabled; "Events and Tasks" and its drop down items are accessible from the Menu Bar; "View;" includes Today Pane, Calendar and Tasks; and these items are available from the Hamburger drop down.

Exit Thunderbird.

Restart Tunderbird and "Events and Tasks", Today Pane etc., and Hamburger items are gone.

Goto: Tools/Add-ons/Extensions and DISABLE Lightning
Restart Thunderbird

Goto: Tools/Add-ons/Extensions and ENABLE Lightning
Restart Thunderbird 

"Events and Tasks" etc are now available again (until the next time that Thunderbird is exited and restarted).


Expected results:

The Lightning related menu items should remain enabled long as the Lightning add-on is enabled.

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for using Daily, it can be a bumpy ride. As you may know, we're still in the process of bringing back Lightning after months of outage.

Comment 2

[Jorg K (CEST = GMT+2)]

Then again, I can't reproduce this. Do you have any other add-ons installed that may interfere?

Comment 3

[mgrandfield]

Lightning 6.5a1 {e2fda1a4-762b-4020-b5ad-a41df1933103} is the only add-on installed... and no plugins have been installed. I am seeing the same error on both of my computers, which are running Win10 x64 Build 17713 Pre-release.

Comment 4

[Jorg K (CEST = GMT+2)]

Richard, can you reproduce with your Daily? I used a local build and cannot reproduce.

Comment 5

[Richard Marti (:Paenglab)]

"Events and Tasks" is always here, also after multiple restarts.

Comment 6

[mgrandfield]

Thank you for checking this (and assume you have checked using the windows Daily). I will try to identify why my setup is causing this.

Comment 7

[Jorg K (CEST = GMT+2)]

Looks like there are STR in bug 1449487 comment #9.

Comment 8

[WaltS48 [:walts48]]

(In reply to Jorg K (GMT+2) from comment #7)
> Looks like there are STR in bug 1449487 comment #9.

Thanks for posting that link.

Another thing I just noticed in testing some more.

When a user first installs and opens a release version or 60 beta, they are informed that "Thunderbird now contains calendaring functionality by integrating the Lightning extension" with the options to click the Learn More, Disable, Keep or close x buttons.

In Daily that doesn't appear until after you go to Add-ons Manager, Enable Lightning and restart Daily.

Comment 9

[Geoff Lankow (:darktrojan)]

Okay, it looks like this is a startup bug, and bug 1477956 should fix it. That should be fixed soon.

Comment 10

[mgrandfield]

Has Bug 1477956 landed? As of Build ID: 20180811100311 the Calendar bug is still present.

Comment 11

[Jorg K (CEST = GMT+2)]

No.

Comment 12

[Geoff Lankow (:darktrojan)]

I found a way to reproduce this reliably, and the underlying bug.

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: 1477506-overlay-always-1.diff

What appears to be happening is that in some cases a document will have fired chrome-document-interactive, but not yet be in the interactive state. We're missing these because we add the listener for chrome-document-interactive after enumerating existing windows.

This appears to be related to the system load at the time, as I've managed to trigger it by drastically reducing what Lightning does at start-up.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f5dc07feb56e
In overlay loader, add window creation listener before enumerating existing windows; r=Fallen

Comment 15

[Jorg K (CEST = GMT+2)]

Someone will need to manage uplifts here, if necessary.

Comment 16

[Geoff Lankow (:darktrojan)]

I don't think there's a pressing need to uplift this.

Comment 17

[Jorg K (CEST = GMT+2)]

So this is not the bug that after some upgrades or whatever else, the Calendar totally disappears from sight and its presence can only be seen in the options? That's happening in TB 68 so any remedy would be appreciated.

Comment 18

[Worcester12345]

(In reply to Jorg K (GMT+2) from comment #17)

So this is not the bug that after some upgrades or whatever else, the Calendar totally disappears from sight and its presence can only be seen in the options? That's happening in TB 68 so any remedy would be appreciated.

That is in the first post here, which started the bug. So, yes.

Comment 19

[Jorg K (CEST = GMT+2)]

Geoff, you still think this shouldn't be fixed in TB 68. Am I missing something?

Comment 20

[Geoff Lankow (:darktrojan)]

I'm missing the dozens of duplicates of this bug saying that it is still happening and not in fact fixed by bug 1477956.

I'm currently working on something which hasn't yet landed but would cause this bug to reappear if it did land. So I fixed it again.

Comment 21

[Jorg K (CEST = GMT+2)]

Hi Geoff,

I find your answer quite confusing. Are you saying that there aren't dozens of (duplicate) bugs that complain that Lightning is vanishing? That's likely since there aren't many users on TB 68/69 beta.

The second sentence is sadly slightly derailed since I don't understand what "this bug" and "it" are referring to. Is "this bug" meaning "this bug here", bug 1477506, or the other guy, bug 1477956? And what is "it"?

As the case may be, we have the following severe quality issue in TB 68, and I'm happy to file another bug if this bug here doesn't fix it.

STR:
Have TB 68 beta or ESR installed with Calendar. Make sure it's the distro add-on, well none at ATN so far, so it must be.
Remove Calendar, close the add-on manager tab, restart a few times to make sure it's really gone.

Reset pref extensions.installedDistroAddon.{e2fda1a4-762b-4020-b5ad-a41df1933103} to bring Calendar back following:
https://support.mozilla.org/en-US/kb/calendar-updates-issues-thunderbird#w_lightning-disappears-after-a-thunderbird-update-release-and-beta-versions
Restart. Now Calendar is broken. It's present in the options, but there is no other sight of it. To make it work again, you need to disable it, restart, enable it, restart. This is no fluke and 100% reproducible.

If you want to put users through this, please let me know. I'd like to ship a working product. So I'd like to know: Does this bug here fix this issue or not? It's hard to test on Daily since Daily has different rules for distro add-ons.

Comment 22

[Jorg K (CEST = GMT+2)]

Here's a try build of TB 68 ESR for Windows/Linux where I will test whether the patch fixes the issue I described in comment #21:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=74799f404a2b387b3082d746ae4df326a339a944

I've just noticed that this is not a Calendar bug, so uplift doesn't need Calendar approval. If it doesn't fix the issue, I'll file a new bug.

Comment 23

[Geoff Lankow (:darktrojan)]

Uplift the patch.

Comment 24

[Jorg K (CEST = GMT+2)]

Comment on attachment 9080260 [details] [diff] [review]
1477506-overlay-always-1.diff

[Approval Request Comment]
Regression caused by (bug #): The whole de-XUL overlay, overlay loader and Lightning shebang.
User impact if declined: Very confusing behaviour, even harder to bring Lightning back after it got list, see STR in comment #21.
Testing completed (on c-c, etc.): Tested on a try build, seems to work.

Wayne, how do you feel about taking this straight to TB 68.0 ESR without beta exposure? I think the benefit outweighs the risk. Let's decide this now so we don't have discussions when it comes to releasing. I can live without the fix since I know the workaround. But we have enough Lightning problems and destroying the published way to get it back once it's lost is not a good idea IMHO.

Comment 25

[Jorg K (CEST = GMT+2)]

Oops, forgot the NI, Wayne, see comment #24.

Comment 26

[Jorg K (CEST = GMT+2)]

TB 69 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/cfe5da4d82fe0fe9aff0e4cf551f891d46d331ae

Comment 27

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/b44675bb5542878c0b9c57bfbdfca215684d128e