1480532 - Remove “Reload All Tabs” from Tab context menu

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Amy Lee [:amylee] UX]

Attachment: Tab Context Menu.png

Now that we have multi-select and an updated overflow menu in the works that would have a reload all tabs option, we no longer need a "reload all tabs" option in the context menu. See spec.

Comment 1

[Alice0775 White]

Hi, I want to confirmation.
When I choose "Select All Tabs", then, dose tab context menu dinamically change to "Multi-selected Tabs" context menu" without extra right click?

I mean
1. Right click on a tab
2. Choose "Select All Tabs"
   ---- then the context menu will change to "Multi-selected tabs" dynamically. i.e. "Reload Tabs" will appear on the context-menu without any extra operation.
3. Choose "Reload Tabs"


(Anyway, I use the "Reload All Tabs" very often, This bug is so sad)

Comment 2

[Ben Thayer]

(In reply to Alice0775 White from comment #1)
> Hi, I want to confirmation.
> When I choose "Select All Tabs", then, dose tab context menu dinamically
> change to "Multi-selected Tabs" context menu" without extra right click?
> 
> I mean
> 1. Right click on a tab
> 2. Choose "Select All Tabs"
>    ---- then the context menu will change to "Multi-selected tabs"
> dynamically. i.e. "Reload Tabs" will appear on the context-menu without any
> extra operation.
> 3. Choose "Reload Tabs"
> 
> 
> (Anyway, I use the "Reload All Tabs" very often, This bug is so sad)

As it stands, you are correct, there will be another right click. After a button press, the context menu automatically closes. The "Reload Tabs" option is going to be the first option though, so hopefully it's not too much extra effort. However... it might be worth discussing the benefit of leaving the menu open after pressing the "Select All Tabs" button in the context menu. I'll bring it up on bug 1480456, might be worth opening another bug.

Comment 3

[Amy Lee [:amylee] UX]

Hi, 

I'm proposing we implement a shortcut for "Select All Tabs" and removing it from the context menu which is native to MacOS, Windows, and Linux. That way it removes the need to open the context menu twice and it's one less item in the context menu. We also have a "reload tabs" that reloads all your current tabs in the overflow menu in this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1480542. That means you click once in the overflow menu and click again to select "Reload Tabs"

Comment 4

[Ben Thayer]

Attachment: Bug 1480532 - Remove Reload All Tabs from context menu r=dao

MozReview-Commit-ID: Ix4oJH1oWvU

Comment 5

[Dão Gottwald [:dao]]

As far as I can tell neither the Select All Tabs option nor the updated overflow menu are implemented yet, so it seems we're not yet ready to move forward here.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Hey Ben, would you still like to work on this? I've implemented Select All Tabs now so this bug can be worked on. I have looked at your patch and I saw a couple things we should change. We will need to add a string for "Reload Tabs", and we should add a menuitem to the overflow menu[1]. The "Reload Tabs" string should be used if the contextTab is multiselected.

Also, "Reload All Tabs" is referenced by the toolbar-context-menu which you can see if you right click on the tab toolbar overflow buttons. For this item, we should use the string "Reload Selected Tabs" (which would not change based on multiselection) since there is no tab context in this case.

[1] https://searchfox.org/mozilla-central/source/browser/base/content/browser-allTabsMenu.inc.xul

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

I'll work on this since we need to get this fixed in the next couple days.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1480532 - Remove 'Reload All Tabs' from tab context menu. r?Felipe

I left off the part about adding Reload Tabs to the All Tabs menu since the specs don't mention how this would appear with the New Container Tab menuitem and the Tab Manager project has been split off from the multiselect tabs project.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99483ca5d3c6
Remove 'Reload All Tabs' from tab context menu. r=Felipe

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/99483ca5d3c6

Comment 11

[Damira Akh]

Verified 

Build ID 	20181017101626
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Comment 12

[kiril]

As a Front End Software Engineer and a UX/UI expert I'd suggest the following context menu:

Reload
Mute
Pin
Duplicate
Bookmark
---
All Tabs ->
            Reload
            Mute
            Pin
            Bookmark
Move Tab ->
            Move to Start
            Move to End
            Move to New Window
Send Tab(18 Tabs) to Device ->
            Firefox on PC-NAME
            ---
            Send to All Devices
---
Close Tab Options ->
            Close Tabs to the Right
            Close Other Tabs
Undo Close Tab
Close Tab

            


This makes the "Select All Tabs" option redundant and saves quite a few clicks.

Comment 13

[Dão Gottwald [:dao]]

(In reply to kiril from comment #12)
> As a Front End Software Engineer and a UX/UI expert I'd suggest the
> following context menu:
> 
> Reload
> Mute
> Pin
> Duplicate
> Bookmark
> ---
> All Tabs ->
>             Reload
>             Mute
>             Pin
>             Bookmark
> Move Tab ->
>             Move to Start
>             Move to End
>             Move to New Window
> Send Tab(18 Tabs) to Device ->
>             Firefox on PC-NAME
>             ---
>             Send to All Devices
> ---
> Close Tab Options ->
>             Close Tabs to the Right
>             Close Other Tabs
> Undo Close Tab
> Close Tab
> 
>             
> 
> 
> This makes the "Select All Tabs" option redundant and saves quite a few
> clicks.

Better file a new bug on this proposal, or morph bug 1500515 to evaluate this.

Comment 14

[Cristian Fogel [:cfogel]]

Verified with 64.0b8 and 65.0a1 (2018-11-11) on Win10, macOS10.13, Ubuntu16.04.