148169 - use nsISafeOutputStream to save local (non LDAP replicated) addressbooks (.mab files)

Status: RESOLVED WONTFIX

(MailNews Core :: Address Book, defect)

Description

[(not reading, please use [e-mail] instead)]

Comment 1

[(not reading, please use [e-mail] instead)]

we should use bnesse's code to back up local addressbooks.  Right now, local
addressbooks are .mab files (mork addressbook files).  If they get corrupt, the
user can lose their local addressbook.  (Unlike .msf files, mork summary files
for mail boxes, which can be rebuilt.)

We wouldn't back up replicated LDAP addressbooks (which are .mab files, but are
typically larger.  But they can be rebuilt from the LDAP server).

Comment 2

[(not reading, please use [e-mail] instead)]

1.1 is passed

Comment 3

[Brant Gurganus]

By the definitions on <http://bugzilla.mozilla.org/bug_status.html#severity> and
<http://bugzilla.mozilla.org/enter_bug.cgi?format=guided>, crashing and dataloss
bugs are of critical or possibly higher severity.  Only changing open bugs to
minimize unnecessary spam.  Keywords to trigger this would be crash, topcrash,
topcrash+, zt4newcrash, dataloss.

Comment 4

[Art Wildman]

Personal Data is very critical to users & needs to be backed up, easy to locate
& portable. Please consider Backing up Personal Addressbooks in a way that can
be integrated with future Profile Migration/Sharing/Mobility issues.

7067   	 All profile contents should use cross-platform formats   	
17048 	Roaming access - keep bookmarks/cookies/history/etc in a central repository 	
17457 	Need formalized way to "import" a profile 	
17917 	Add "smart" roaming bookmarks (etc.) with sync capabilities 	
31732 	Make Deployment of Roaming Profiles Easier in LAN/WAN Environments 	
55309 	Need an option to store migrated profiles in a user's choice of location 
65960 	Set user profile location via registry key (network drive) 	
66259 	Profiles should be transportable (movable) 	
124048 	Roaming - Funding - Sync during runtime

Comment 5

[[e-mail]]

nsSafeSaveFile has been removed - nsISafeOutputStream replaces it. changing summary.

Comment 8

[Wayne Mery (:wsmwk)]

what is potential for getting this into 3.x?
If this will solve lots of dataloss issues then this is perhaps overdue.

other potential dupes:
 Bug 299346 -  address book deleted when opening TBird - 2nd x in a month *(which itself has many dups)*
 Bug 366457 -  Address Book Corruption / deletion - Possible memory dump appended to original abook.mab file
 Bug 394797 -  the entries in the address book in one of our accounts were deleted when the latest version of Thunderbird was downloaded and installed 
 Bug 435110 -  Address Book - Now Empty

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #8)
> what is potential for getting this into 3.x?
> If this will solve lots of dataloss issues then this is perhaps overdue.

From what I can tell in a 1-minute glance, the guts of the code to save the mork databases is buried deep in the mork code and is using stdio functions rather than the xpcom provided classes. Therefore I think doing this would require too much work for the 3.0.x branch so definitely not blocking on that.

Personally I'd probably hold off on this for 3.1 as well pending what we decide to do wrt the address book once we get the roadmap for it together.

Comment 10

[David :Bienvenu]

blocking - per standard8's comments.

Comment 11

[Wayne Mery (:wsmwk)]

I would guess we are no longer going to care about this given v78's AB rewrite