1482479 - Update SEARCH_SHORTCUTS and top_sites.json to support the 9 desired search urls

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ed Lee :Mardak]

Bug 1482125 is adding aliases to certain known search engine identifiers by prefix. These correspond to plugin xml files:

https://searchfox.org/mozilla-central/source/browser/components/search/searchplugins

```
$ ls -1 {google,amazondotcom,amazondotcom-de,amazon-en-GB,amazon-france,amazon-jp,amazon-it,twitter,wikipedia,ebay,bing,ddg,yandex,baidu}*
amazon-en-GB.xml
amazon-france.xml
amazon-it.xml
amazon-jp.xml
amazondotcom-de.xml
amazondotcom-de.xml
amazondotcom.xml
baidu.xml
bing.xml
ddg.xml
ebay-at.xml
ebay-au.xml
ebay-be.xml
ebay-ca.xml
ebay-ch.xml
ebay-de.xml
ebay-es.xml
ebay-fr.xml
ebay-ie.xml
ebay-it.xml
ebay-nl.xml
ebay-uk.xml
ebay.xml
google-2018.xml
google.xml
twitter-ja.xml
twitter.xml
wikipedia-NN.xml
wikipedia-NO.xml
wikipedia-af.xml
wikipedia-an.xml
wikipedia-ar.xml
wikipedia-as.xml
wikipedia-ast.xml
wikipedia-az.xml
wikipedia-be-tarask.xml
wikipedia-be.xml
wikipedia-bg.xml
wikipedia-bn.xml
wikipedia-br.xml
wikipedia-bs.xml
wikipedia-ca.xml
wikipedia-crh.xml
wikipedia-cy.xml
wikipedia-cz.xml
wikipedia-da.xml
wikipedia-de.xml
wikipedia-dsb.xml
wikipedia-el.xml
wikipedia-eo.xml
wikipedia-es.xml
wikipedia-et.xml
wikipedia-eu.xml
wikipedia-fa.xml
wikipedia-fi.xml
wikipedia-fr.xml
wikipedia-fy-NL.xml
wikipedia-ga-IE.xml
wikipedia-gd.xml
wikipedia-gl.xml
wikipedia-gn.xml
wikipedia-gu.xml
wikipedia-he.xml
wikipedia-hi.xml
wikipedia-hr.xml
wikipedia-hsb.xml
wikipedia-hu.xml
wikipedia-hy.xml
wikipedia-ia.xml
wikipedia-id.xml
wikipedia-is.xml
wikipedia-it.xml
wikipedia-ja.xml
wikipedia-ka.xml
wikipedia-kab.xml
wikipedia-kk.xml
wikipedia-km.xml
wikipedia-kn.xml
wikipedia-kr.xml
wikipedia-lij.xml
wikipedia-lo.xml
wikipedia-lt.xml
wikipedia-ltg.xml
wikipedia-lv.xml
wikipedia-mk.xml
wikipedia-ml.xml
wikipedia-mr.xml
wikipedia-ms.xml
wikipedia-my.xml
wikipedia-ne.xml
wikipedia-nl.xml
wikipedia-oc.xml
wikipedia-or.xml
wikipedia-pa.xml
wikipedia-pl.xml
wikipedia-pt.xml
wikipedia-rm.xml
wikipedia-ro.xml
wikipedia-ru.xml
wikipedia-si.xml
wikipedia-sk.xml
wikipedia-sl.xml
wikipedia-sq.xml
wikipedia-sr.xml
wikipedia-sv-SE.xml
wikipedia-ta.xml
wikipedia-te.xml
wikipedia-th.xml
wikipedia-tl.xml
wikipedia-tr.xml
wikipedia-uk.xml
wikipedia-ur.xml
wikipedia-uz.xml
wikipedia-vi.xml
wikipedia-wo.xml
wikipedia-zh-CN.xml
wikipedia-zh-TW.xml
wikipedia.xml
yandex-az.xml
yandex-by.xml
yandex-en.xml
yandex-kk.xml
yandex-ru.xml
yandex-tr.xml
```

Instead of doing a searchIdentifier regex, we probably should match an exact identifier against Services.search.getEngines()

Comment 1

[Ed Lee :Mardak]

Actually, after chatting with k88hudson, we might only need the 9 entries: google, amazon, twitter, wikipedia, ebay, bing, ddg, yandex, baidu. The "url" can be a dummy amazon.com token instead of the localized one as it won't be exposed as a link with bug 1482473.

Comment 2

[Ed Lee :Mardak]

Missing packaged top sites: bing, ddg, yandex, baidu

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4320

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/b11729905f7caf76bf724cb87afef27a90ae8306
Fix Bug 1482479 - Update SEARCH_SHORTCUTS and top_sites.json to support the 9 desired search urls

https://github.com/mozilla/activity-stream/commit/8a130e922558e6cde742ef329e4db303e5f49cbb
Merge pull request #4320 from rlr/bug1482479/update-shortcuts-icons

Fix Bug 1482479 - Update SEARCH_SHORTCUTS and top_sites.json to support the 9 desired search urls

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/322c3cf43fe8

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a