Closed
Bug 1483380
Opened 3 years ago
Closed 3 years ago
Update test262 and test262 skipped files
Categories
(Core :: JavaScript Engine, enhancement, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
11.70 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
1.09 MB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
2.41 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
We want Object.fromEntries tests for free. No reason not to update everything.
Assignee | ||
Comment 1•3 years ago
|
||
Attachment #9001273 -
Flags: review?(andrebargull)
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 years ago
|
||
Attachment #9001274 -
Flags: review?(andrebargull)
Comment 3•3 years ago
|
||
Comment on attachment 9001273 [details] [diff] [review] Update test262 skipped files Review of attachment 9001273 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for taking care of the update! ::: js/src/tests/jstests.list @@ +380,5 @@ > > +# Dependent on evalInWorker, setSharedArrayBuffer, and getSharedArrayBuffer; plus: > +# https://bugzilla.mozilla.org/show_bug.cgi?id=1349863 - Enable test262 agent tests in browser > +# https://bugzilla.mozilla.org/show_bug.cgi?id=1470490 - Rename Atomics.wake to Atomics.notify > +skip script test262/built-ins/Atomics/notify/bad-range.js Make this |skip include test262/built-ins/Atomics/notify/jstests.list| to simply skip the whole directory. @@ +471,5 @@ > # https://bugzilla.mozilla.org/show_bug.cgi?id=1406171 > skip script test262/built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js > > +# https://bugzilla.mozilla.org/show_bug.cgi?id=1469019 > +skip script test262/built-ins/Object/fromEntries/to-property-key.js Tip: The importer allows to specify which test262 features [1] are not supported [2], so by adding "Object.fromEntries" [3] to this list, the importer would have marked all Object.fromEntries tests as skipped automatically. :-) [1] https://github.com/tc39/test262/blob/master/CONTRIBUTING.md#features [2] https://searchfox.org/mozilla-central/rev/2466b82b729765fb0a3ab62f812c1a96a7362478/js/src/tests/test262-update.py#21-36 [3] https://github.com/tc39/test262/blob/60b9467630a7b4899058e3ad74eb88c3ecb08a40/features.txt#L10-L12 @@ +506,2 @@ > # https://bugzilla.mozilla.org/show_bug.cgi?id=1473229 > +skip script test262/intl402/RelativeTimeFormat/prototype/formatToParts/en-us-numeric-always.js |skip include test262/intl402/RelativeTimeFormat/prototype/formatToParts/jstests.list| here, too.
Attachment #9001273 -
Flags: review?(andrebargull) → review+
Comment 4•3 years ago
|
||
Comment on attachment 9001274 [details] [diff] [review] Update test262 from upstream Review of attachment 9001274 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #9001274 -
Flags: review?(andrebargull) → review+
Assignee | ||
Updated•3 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•3 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/94913c7ee691dd715b62b7d29fa20c2ba4fb59a9 Bug 1483380 - Update test262 skipped files. r=anba https://hg.mozilla.org/integration/mozilla-inbound/rev/6c418727a06c221810fde75f0cff02d3d7fca15c Bug 1483380 - Update test262 from upstream. r=anba
Assignee | ||
Comment 6•3 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e6e2f78eabeeca21f60ad0058119975bd984e90 Follow-up to bug 1483380 - Disable slow tests in SM(cgc). r=red
Assignee | ||
Comment 7•3 years ago
|
||
These tests loop over every Unicode code point: for (let codePoint = 0; codePoint < 0x10FFFF; codePoint++) { // split strings to avoid a super long one; chunks[codePoint % totalChunks] += String.fromCodePoint(codePoint); } With compacting zeal enabled, this is too slow; we disable such tests.
Assignee | ||
Updated•3 years ago
|
Attachment #9001789 -
Attachment description: Follow-up to - Disable slow tests in SM(cgc) → Follow-up - Disable slow tests in SM(cgc)
Attachment #9001789 -
Flags: review?(sphink)
Updated•3 years ago
|
Attachment #9001789 -
Flags: review?(sphink) → review+
Comment 8•3 years ago
|
||
Backed out for failing spidermonkey cgc Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6c418727a06c221810fde75f0cff02d3d7fca15c Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194410536&repo=mozilla-inbound&lineNumber=122577 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/f106f2468612f4b903505585efdbb7019feb049b
Flags: needinfo?(jorendorff)
Assignee | ||
Comment 9•3 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d48a7757fda9c97d342328d9d5c960f1f27a163 Bug 1483380 - Update test262 skipped files. r=anba https://hg.mozilla.org/integration/mozilla-inbound/rev/3e060afdccb23b692fc4f58e6b41bda88550d443 Bug 1483380 - Update test262 from upstream. r=anba
Comment 10•3 years ago
|
||
Backed out 2 changesets (Bug 1483380) for frequent cgx and arm64 failures First failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5fcbe08fb321a5076f56c380b554c63068efbb00&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&filter-searchStr=spidermonkey%20builds&selectedJob=194457922 Later did some retriggers and all of them are green: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&fromchange=635d66906fe414e547522e7993a5e58662a77377&filter-searchStr=spidermonkey%20builds%20&selectedJob=194474487 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a0c5138ce9ec748d54931643fffcbf378b47948
Comment 11•3 years ago
|
||
Filed a test262 PR to reduce the time needed to complete the new RegExp tests: https://github.com/tc39/test262/pull/1683
Assignee | ||
Comment 12•3 years ago
|
||
Looks like I copied the failing tests from a single changeset, rather than making a list of all tests that had the loop in them. I can fix this and reland today.
Comment 13•3 years ago
|
||
https://github.com/tc39/test262/pull/1683 was accepted and merged, so updating our local test262 copy to include the changes from that PR should allow us to unskip the RegExp tests for cgc.
Assignee | ||
Comment 14•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae4d04847752f059042f32f6650d4aaee7ab5594
Assignee | ||
Comment 15•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c88a373c703c4f20c87f768cb71b515c8a78738
Assignee | ||
Comment 16•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=03a2b72aa7fcd5fd3d408e2d782f83de59def705
Assignee | ||
Comment 17•3 years ago
|
||
Comment 12 was wrong anyway. The failures were SM(arm64), not SM(cgc). In the interest of ending this comedy of errors, I sent two different things to try server: 1. Another set of changes to jstests.list to try to get this set of patches working without updating our local test262 copy again <https://treeherder.mozilla.org/#/jobs?repo=try&revision=5020d37b1094f0b81160ad4fca2e2ae1a2612078> (that try run also includes Object.fromEntries, bug 1469019) 2. Updating our local test262 copy again and removing the "slow test" entries. (link in comment 16)
Assignee | ||
Comment 18•3 years ago
|
||
Both things came back nice and green. I will land #1, as those parts have review and risk conflict with Waldo. #2 --> bug 1484728
Assignee | ||
Comment 19•3 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/317099325f4cefc3ff2af73d479f1689a9f9e8e5 Bug 1483380 - Update test262 skipped files. r=anba https://hg.mozilla.org/integration/mozilla-inbound/rev/66a2d0d0f6ed7ea7cc0060e3005016aeb66cc575 Bug 1483380 - Mark some test262 tests slow. r=sfink https://hg.mozilla.org/integration/mozilla-inbound/rev/d206778940ef0d89ecf8f2fe74e09c1d04f42128 Bug 1483380 - Update test262 from upstream. r=anba
Comment 20•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/317099325f4c https://hg.mozilla.org/mozilla-central/rev/66a2d0d0f6ed https://hg.mozilla.org/mozilla-central/rev/d206778940ef
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(jorendorff)
You need to log in
before you can comment on or make changes to this bug.
Description
•