Closed Bug 1483380 Opened 2 years ago Closed 2 years ago

Update test262 and test262 skipped files

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We want Object.fromEntries tests for free. No reason not to update everything.
Attachment #9001273 - Flags: review?(andrebargull)
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Attachment #9001274 - Flags: review?(andrebargull)
Comment on attachment 9001273 [details] [diff] [review]
Update test262 skipped files

Review of attachment 9001273 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of the update!

::: js/src/tests/jstests.list
@@ +380,5 @@
>  
> +# Dependent on evalInWorker, setSharedArrayBuffer, and getSharedArrayBuffer; plus:
> +# https://bugzilla.mozilla.org/show_bug.cgi?id=1349863 - Enable test262 agent tests in browser
> +# https://bugzilla.mozilla.org/show_bug.cgi?id=1470490 - Rename Atomics.wake to Atomics.notify
> +skip script test262/built-ins/Atomics/notify/bad-range.js

Make this |skip include test262/built-ins/Atomics/notify/jstests.list| to simply skip the whole directory.

@@ +471,5 @@
>  # https://bugzilla.mozilla.org/show_bug.cgi?id=1406171
>  skip script test262/built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js
>  
> +# https://bugzilla.mozilla.org/show_bug.cgi?id=1469019
> +skip script test262/built-ins/Object/fromEntries/to-property-key.js

Tip:
The importer allows to specify which test262 features [1] are not supported [2], so by adding "Object.fromEntries" [3] to this list, the importer would have marked all Object.fromEntries tests as skipped automatically. :-)

[1] https://github.com/tc39/test262/blob/master/CONTRIBUTING.md#features
[2] https://searchfox.org/mozilla-central/rev/2466b82b729765fb0a3ab62f812c1a96a7362478/js/src/tests/test262-update.py#21-36
[3] https://github.com/tc39/test262/blob/60b9467630a7b4899058e3ad74eb88c3ecb08a40/features.txt#L10-L12

@@ +506,2 @@
>  # https://bugzilla.mozilla.org/show_bug.cgi?id=1473229
> +skip script test262/intl402/RelativeTimeFormat/prototype/formatToParts/en-us-numeric-always.js

|skip include test262/intl402/RelativeTimeFormat/prototype/formatToParts/jstests.list| here, too.
Attachment #9001273 - Flags: review?(andrebargull) → review+
Comment on attachment 9001274 [details] [diff] [review]
Update test262 from upstream

Review of attachment 9001274 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #9001274 - Flags: review?(andrebargull) → review+
Priority: -- → P1
These tests loop over every Unicode code point:

    for (let codePoint = 0; codePoint < 0x10FFFF; codePoint++) {
        // split strings to avoid a super long one;
        chunks[codePoint % totalChunks] += String.fromCodePoint(codePoint);
    }

With compacting zeal enabled, this is too slow; we disable such tests.
Attachment #9001789 - Attachment description: Follow-up to - Disable slow tests in SM(cgc) → Follow-up - Disable slow tests in SM(cgc)
Attachment #9001789 - Flags: review?(sphink)
Attachment #9001789 - Flags: review?(sphink) → review+
Filed a test262 PR to reduce the time needed to complete the new RegExp tests: https://github.com/tc39/test262/pull/1683
Looks like I copied the failing tests from a single changeset, rather than making a list of all tests that had the loop in them. I can fix this and reland today.
https://github.com/tc39/test262/pull/1683 was accepted and merged, so updating our local test262 copy to include the changes from that PR should allow us to unskip the RegExp tests for cgc.
Comment 12 was wrong anyway. The failures were SM(arm64), not SM(cgc).

In the interest of ending this comedy of errors, I sent two different things to try server:

1.  Another set of changes to jstests.list to try to get this set of patches working without updating our local test262 copy again <https://treeherder.mozilla.org/#/jobs?repo=try&revision=5020d37b1094f0b81160ad4fca2e2ae1a2612078> (that try run also includes Object.fromEntries, bug 1469019)

2.  Updating our local test262 copy again and removing the "slow test" entries. (link in comment 16)
Both things came back nice and green. I will land #1, as those parts have review and risk conflict with Waldo.

#2 --> bug 1484728
Flags: needinfo?(jorendorff)
You need to log in before you can comment on or make changes to this bug.