Open Bug 1486277 Opened 2 years ago Updated 2 years ago

Add regression test for videocontrols in a content privileged HTML page

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: bgrins, Unassigned)

References

Details

Given Bug 1486220 (caused by changing createElement to createXULElement) broke videocontrols, we should make sure we have a test that would fail if that change were to re-land. My current guess is that (1) that particular caller showed up on the radar in Bug 1485426 because we do some videocontrols test in a XUL doc and (2) we only test videocontrols in chrome privileged documents.
We ran tests on mochitest plain so they should be in content.

Bug 1486220 didn't say what breaks, but reading the code it should have been caught by

https://searchfox.org/mozilla-central/source/toolkit/content/tests/widgets/xbl/test_videocontrols_vtt.html

?
BTW, <html:video controls> has too work in both privileged XUL/HTML and unprivileged HTML. Would the change in bug 1486220 make sure of that?
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #1)
> We ran tests on mochitest plain so they should be in content.
> 
> Bug 1486220 didn't say what breaks, but reading the code it should have been
> caught by
> 
> https://searchfox.org/mozilla-central/source/toolkit/content/tests/widgets/
> xbl/test_videocontrols_vtt.html

OK, maybe we just need to add some extra checks to that one. The breakage is that you can click on video controls (i.e. seek) but it doesn't do anything to the video. Bug 1486260 and Bug 1486237 have more details.

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #2)
> BTW, <html:video controls> has too work in both privileged XUL/HTML and
> unprivileged HTML. Would the change in bug 1486220 make sure of that?

Bug 1486220 is just reverting the change from Bug 1485426, so the behavior should be restored to what it was doing previously.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.