1489834 - Send Tab to Device page action button tooltips says "sendToDevice-title"

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1483167 +++

Still seeing this in the current nightly.

Comment 1

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #0)
> +++ This bug was initially created as a clone of Bug #1483167 +++
> 
> Still seeing this in the current nightly.

Does this also affect 63?

Comment 2

[Dão Gottwald [:dao]]

Not seeing it there.

Comment 3

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #2)
> Not seeing it there.

Odd... do we think this re-regressed since bug 1483167?

Comment 4

[:Gijs (he/him)]

Ni for comment #3...

Comment 5

[Mike Conley (:mconley) (:⚙️)]

FWIW, assuming the STR are to first add the Send Tab to Device pageAction to the Address Bar in order to see the tooltip, I'm not seeing this on the latest Windows, macOS or Linux Nightlies.

Comment 6

[Drew Willcoxon :adw]

I see it.  I'm not sure what the problem is yet.  I verified that the other actions are fixed.

Comment 7

[Drew Willcoxon :adw]

The value of the sendToDevice-title attribute on the panel is "", so that's probably why.

Comment 8

[Dão Gottwald [:dao]]

Bug 1470555 has also caused another regression (bug 1489754). Feel free to back it out unless the fix here is easy.

Comment 9

[Mike Taylor [:miketaylr]]

Drew, do we think this is an easy fix or should we just back it out?

Comment 10

[Drew Willcoxon :adw]

Yes, this should be an easy fix, and I'm hoping to have a patch ready today.

Comment 11

[Dão Gottwald [:dao]]

FYI, phabricator decided to post the patch for this in bug 1470555.

Comment 12

[Drew Willcoxon :adw]

Attachment: Bug 1489834 - Fix the Send Tab to Device page action title and tooltip

Bug 1470555 moved the title from a dtd to a properties file, so we can and should now set the action's title directly when the action is created in PageActions.jsm.  But it's a PluralForm string, so we need to jump through that hoop.

Comment 13

[Jason Duell]

Drew: looks like this just needs update from jaws' comment on patch?

Comment 14

[Drew Willcoxon :adw]

Yes, I updated the patch just now.  Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fba73975801884ec151f81db3cef7d7a86ccf451

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9008770 [details]
Bug 1489834 - Fix the Send Tab to Device page action title and tooltip

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 16

[Drew Willcoxon :adw]

There were some weird, unrelated-looking failures on that last try push.  Here's another one with a fresh tree: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8613e6817abd0235546329a90aff0e0d0a50500

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fab03252db7
Fix the Send Tab to Device page action title and tooltip r=jaws

Comment 18

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2fab03252db7