1490720 - Track Changes: Log changes to CSS declarations coming from the Inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Razvan Caliman [:rcaliman]]

All CSS changes occurring in the Inspector panel pass through StyleRuleActor. This is a good place to monitor atomic changes (proxy RuleRewriter methods) and pass them onward to the ChangesActor introduced by Bug 1468754.

This implementation explicitly handles on they Inspector and its tools. The Style Editor is not covered in this implementation.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1490720 - Log changes to CSS declarations from StyleRuleActor. r=pbro

MozReview-Commit-ID: 9J4zBcSxYwj

Comment 2

[Patrick Brosset <:pbro>]

I'm starting to look at this change now. This is the main architecture part for supporting track changes in the inspector. So I want to be careful reviewing this.

I was going to say that it would make things clearer if we could remove the non-authored CSS handling code before doing this.
The authored CSS project was done by tromey in bug 984880 which landed in 2015, in Firefox 44. So in terms of backward compat, we don't need to worry about it anymore and can get rid of it.

However, after looking at that part again, I realized that we don't only have it for backwards compat reasons, but also to handle the element inline style rule, and to handle rules that have been modified by CSSOM dynamically.

So it looks like we do have to keep on using the 2 logics (authored and non-authored), and therefore both the RuleRewriter and RuleModificationList.

Comment 3

[Patrick Brosset <:pbro>]

(In reply to Patrick Brosset <:pbro> from comment #2)
> However, after looking at that part again, I realized that we don't only
> have it for backwards compat reasons, but also to handle the element inline
> style rule
That's incorrect. We only use it for handling rules that have been changed by CSSOM.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 9008457 [details]
Bug 1490720 - Log changes to CSS declarations from StyleRuleActor. r=pbro

Patrick Brosset <:pbro> has approved the revision.

Comment 5

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=be2db94637e06d0d6c12da772a35cdefd4411636

Comment 6

[Razvan Caliman [:rcaliman]]

Another Try after fixing error thrown for XUL documents: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8819cfcdf57d0857acd8334bb252fd402e5caa1f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c34c45253ef
Log changes to CSS declarations from StyleRuleActor. r=pbro

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4c34c45253ef