Closed Bug 1493145 Opened 2 years ago Closed 2 years ago

[CSD] Enable round corners by default

Categories

(Core :: Widget: Gtk, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

(Keywords: feature)

Attachments

(1 file, 1 obsolete file)

Fix at Bug #1489097 is not enough as it's not propagated to js code.

Let's set mozilla.widget.use-argb-visuals when it's not set by user to propagate the settings to browser/themes/linux/browser.css.
It might be better to introduce a media query for this similar to -moz-gtk-csd-available.
browser/themes/linux/browser.css enables transparent background only when mozilla.widget.use-argb-visuals is set.
We need to set mozilla.widget.use-argb-visuals when it's not set by user to propagate it to browser.css.
(In reply to Martin Stránský [:stransky] from comment #2)
> Created attachment 9010929 [details]
> Bug 1493145 - [CSD] Enable round corners by default - propagate
> mozilla.widget.use-argb-visuals, r=jhorak
> 
> browser/themes/linux/browser.css enables transparent background only when
> mozilla.widget.use-argb-visuals is set.
> We need to set mozilla.widget.use-argb-visuals when it's not set by user to
> propagate it to browser.css.

This means that if you move with your profile from a desktop environment where we use ARGB by default to one where we don't, or vice versa, Firefox will be in the wrong state.
Replace mozilla.widget.use-argb-visuals pref by -moz-gtk-csd-transparent-background media query at browser.css
to draw transparent background. The media query is set by toolkit code and enabled when compatible
window manager is detected.
Attachment #9010929 - Attachment is obsolete: true
Summary: [CSD] Enable round corners by default - propagate mozilla.widget.use-argb-visuals → [CSD] Enable round corners by default
Attachment #9010929 - Attachment is obsolete: false
Comment on attachment 9011436 [details]
Bug 1493145 - [CSD] Enable round corners by default by -moz-gtk-csd-transparent-background media query, r=dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9011436 - Flags: review+
Attachment #9010929 - Attachment is obsolete: true
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9bde1b9b0810
[CSD] Enable round corners by default by -moz-gtk-csd-transparent-background media query, r=dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9bde1b9b0810
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1501161

This is happening again after updating to Firefox 65.0 in Fedora 29.

https://imgur.com/a/mt44aHs

Yes, it was reverted due to video playback regression (Bug 1516224) and fixed again in Firefox 66 (Bug 1521012).

This is happening again in Ubuntu 19.04 with Firefox 67.0.1

You need to log in before you can comment on or make changes to this bug.