1493145 - [CSD] Enable round corners by default

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Fix at Bug #1489097 is not enough as it's not propagated to js code.

Let's set mozilla.widget.use-argb-visuals when it's not set by user to propagate the settings to browser/themes/linux/browser.css.

Comment 1

[Dão Gottwald [:dao]]

It might be better to introduce a media query for this similar to -moz-gtk-csd-available.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1493145 - [CSD] Enable round corners by default - propagate mozilla.widget.use-argb-visuals, r=jhorak

browser/themes/linux/browser.css enables transparent background only when mozilla.widget.use-argb-visuals is set.
We need to set mozilla.widget.use-argb-visuals when it's not set by user to propagate it to browser.css.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=13b3ff4c118914b22a54782ce50ed87396bec790

Comment 4

[Dão Gottwald [:dao]]

(In reply to Martin Stránský [:stransky] from comment #2)
> Created attachment 9010929 [details]
> Bug 1493145 - [CSD] Enable round corners by default - propagate
> mozilla.widget.use-argb-visuals, r=jhorak
> 
> browser/themes/linux/browser.css enables transparent background only when
> mozilla.widget.use-argb-visuals is set.
> We need to set mozilla.widget.use-argb-visuals when it's not set by user to
> propagate it to browser.css.

This means that if you move with your profile from a desktop environment where we use ARGB by default to one where we don't, or vice versa, Firefox will be in the wrong state.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1493145 - [CSD] Enable round corners by default by -moz-gtk-csd-transparent-background media query, r=dao

Replace mozilla.widget.use-argb-visuals pref by -moz-gtk-csd-transparent-background media query at browser.css
to draw transparent background. The media query is set by toolkit code and enabled when compatible
window manager is detected.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64d3e98afcb168b2c8cdabe52c0427fc52809106

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 9011436 [details]
Bug 1493145 - [CSD] Enable round corners by default by -moz-gtk-csd-transparent-background media query, r=dao

Dão Gottwald [::dao] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bde1b9b0810
[CSD] Enable round corners by default by -moz-gtk-csd-transparent-background media query, r=dao

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9bde1b9b0810

Comment 10

[fmuro]

This is happening again after updating to Firefox 65.0 in Fedora 29.

https://imgur.com/a/mt44aHs

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Yes, it was reverted due to video playback regression (Bug 1516224) and fixed again in Firefox 66 (Bug 1521012).

Comment 12

[carlosjosepita]

This is happening again in Ubuntu 19.04 with Firefox 67.0.1