1521012 - visible (non-transparent) gray square corners are now sticking out from curved titlebar corners, on Ubuntu 18.10

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

STR:

1. Start Firefox, in Ubuntu 18.10
2. Drag the window over a dark background, and look at the upper left and upper right corners of the titlebar.

EXPECTED RESULTS:
Corners should be rounded.

ACTUAL RESULTS:
Corners are rounded, but there's a gray area jutting out beyond the rounded edge, "filling in the square" so to speak.

See attached screenshot.

This is a regression from bug 1490344. [confirmed via mozregression]

(You may notice that the "x" icon is mispositioned, too -- I filed that separately as bug 1521010.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: reference screenshot (from before the regression)

Comment 2

[Daniel Holbert [:dholbert]]

I'm using Ubuntu 18.10 with the default theme (Yaru).

Comment 3

[Martin Stránský [:stransky] (ni? me)]

It's caused by Bug 1516224 - we disabled transparent background on Basic compositor due to this, I'll look at it. We should disable the default hidden titlebar (bug 1490344) for the upcoming beta if it's not fixed in time.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I think I have a fix for it so we can leave the system titlebar disabled.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=113abb4a989b016053c696bfc0b036cd29cf3ec0

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1521012 - [Linux/GNOME] Use X shape mask to draw transparent corners when we draw to titlebar, r=lsalzman

To support rounded corners of Gtk+ titlebar themes (Adwaita, Radiance..) in GNOME we need to use X shape mask
as fully transparent toplevel window causes various issues (like Bug 1516224).

We draw mShell as transparent and mContainer as non-transparent with shape mask applied. The shape mask
is generated only when titlebar rendering is enabled and it's generated from GtkHeaderBar Widget
to match the exact look.

We use existing mTransparencyBitmap for the shape mask where mTransparencyBitmapForTitlebar controls
whether it's a general shape mask or our specialised shape for titlebar only.

This is already enabled for GNOME environment by default. So there's a new preference
widget.default-hidden-titlebar added to easily disable it if any issue appears
during testing.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6188fc9a7df2611bc332dab9cac9bf67160efb3

Comment 8

[Daniel Varga [:dvarga]]

Hi, landing failed with the following message:

On Wed, January 23, 2019, 1:00 PM GMT+2, by [e-mail].
Revisions: D17283 diff 54116
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpDBvk69\npatching file widget/gtk/nsWindow.cpp\nHunk #3 FAILED at 3234\n1 out of 10 hunks FAILED -- saving rejects to file widget/gtk/nsWindow.cpp.rej\nabort: patch failed to apply', '')

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

I'll update the formatting.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64d38928ff5a
[Linux/GNOME] Use X shape mask to draw transparent corners when we draw to titlebar, r=lsalzman

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Marking as 65-affected since bug 1521473 was 65-affected

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/64d38928ff5a

Comment 15

[Ionuț Goldan [:igoldan]]

Noticed a perf improvement! \0/

== Change summary for alert #18853 (as of Wed, 23 Jan 2019 14:09:39 GMT) ==

Improvements:

3% sessionrestore linux64 pgo e10s stylo 315.38 -> 307.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=18853

Comment 16

[carlosjosepita]

This is happening again in Ubuntu 19.04 with Firefox 67.0.1