1500147 - Add telemetry for about:addons interactions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

There's a new link between about:addons and about:preferences, it would be good to know how much this is being used to tell if users are coming to about:addons from about:preferences.

Comment 1

[Mark Striemer [:mstriemer]]

We would also like to collect usage data for the different pages in about:addons.

Comment 2

[Mark Striemer [:mstriemer]]

We also track the enable/disable/uninstall events for add-ons and it might be nice to know where the interaction took place, list view vs detail view vs something else.

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: data-review.txt

Comment 4

[Mark Striemer [:mstriemer]]

Comment on attachment 9021602 [details]
data-review.txt

Merging this request with the other one.

Comment 5

[Mark Striemer [:mstriemer]]

Comment on attachment 9021602 [details]
data-review.txt

Accidentally closed this instead of the other multilingual one. Requesting review again.

Comment 6

[Chris H-C :chutten]

Comment on attachment 9021602 [details]
data-review.txt

Preliminary note: please by all means reuse the bug in which the code is added for the data review. That way code and review are in the same place.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?**

N/A expires in 70

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mstriemer is responsible for renewing or removing this collection before its expiry in Firefox 70.

---
Result: datareview+

Comment 7

[Mark Striemer [:mstriemer]]

Attachment: Bug 1500147 - Part 1: Record telemetry for about:addons pages r?rpl

Comment 8

[David Durst [:ddurst]]

Just noting here that we could take this in 65 (and if we can land, we should, because more data is better to inform UX changes early in Q1 and Q2).

Comment 9

[Mark Striemer [:mstriemer]]

Attachment: Bug 1500147 - Part 2: Record LWT telemetry in customize mode r?rpl

Comment 10

[Mark Striemer [:mstriemer]]

Attachment: Bug 1500147 - Part 3: Record add-on manager telemetry for page/browser actions r?rpl

Comment 11

[Chris H-C :chutten]

A note that this will require a new Data Collection Review since the expiry has changed. Please also note any other changes to the collection that may have happened during review.

Comment 12

[Mark Striemer [:mstriemer]]

Attachment: data-review.txt

Updating data review request to be more specific about what is being collected. Updated monitoring to version 73 to match the other addonsManager category telemetry.

Comment 13

[Chris H-C :chutten]

Comment on attachment 9040753 [details]
data-review.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file ([Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml)) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/a, this collection expires in Firefox 73.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mstriemer is responsible for renewing or removing the collection before expiry in Firefox 73.

---
Result: datareview+

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dec5ea7cb93f
Part 1: Record telemetry for about:addons pages r=rpl,janerik
https://hg.mozilla.org/integration/autoland/rev/0a5e45e57834
Part 2: Record LWT telemetry in customize mode r=rpl
https://hg.mozilla.org/integration/autoland/rev/286129ec63de
Part 3: Record add-on manager telemetry for page/browser actions r=rpl

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dec5ea7cb93f
https://hg.mozilla.org/mozilla-central/rev/0a5e45e57834
https://hg.mozilla.org/mozilla-central/rev/286129ec63de

Comment 16

[Mark Striemer [:mstriemer]]

Attachment: aatelemetry-beta.patch

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: We are working on updating about:addons and would like telemetry on which features are currently being used. Including this will allow us to determine usage of more features before those changes are made.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Telemetry only changes that are wrapped in try statements to avoid any errors.
• String changes made/needed:

Comment 17

[Mark Striemer [:mstriemer]]

There's a minor conflict rebasing these patches to beta (async was added to an unrelated function next to a change). I've included a patch with the rebased commits.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

I would rather not uplift new telemetry in late beta, can this ride with 67?
If you feel strongly about it, we can give it a try, though.