Closed Bug 1501792 Opened 2 years ago Closed 2 years ago

Port changes from bug 1458314 to Thunderbird


(Thunderbird :: Installer, task)

Not set


(Not tracked)

Thunderbird 65.0


(Reporter: robert.strong.bugs, Assigned: Paenglab)




(1 file, 2 obsolete files)

Bug 1458314 changes the update directory on Windows.
Attached patch 1501792-installer-location.patch (obsolete) — Splinter Review
Robert, many thanks to file the bug. Please could you check this is correct and we need no other changes?

This is a direct port of
Assignee: nobody → richard.marti
Attachment #9019819 - Flags: review?(jorgk)
Attachment #9019819 - Flags: feedback?(robert.strong.bugs)
Robert, while you're here, could you please cast an eye onto bug 1501940. Something wrong with this test:
Checking. I *think* the directory under ProgramData is different due to Thunderbird not defining vendor or something similar and will comment later today.
Comment on attachment 9019819 [details] [diff] [review]

In bug 1501940 comment #1 I did a try with this patch:

It doesn't fix the test failure which we understand better now, see bug 1501940 comment #4.

That said, looking at the log file
we can see the path used:
so I don't think the patch is correct. If anything, we should create a "Thunderbird" directory, since that's where updates are placed, for example:
That's a live example from updating TB 52.8 to TB 52.9.1.
Attachment #9019819 - Flags: review?(jorgk)
Attached patch 1501792-installer-location.patch (obsolete) — Splinter Review
I'll try "Thunderbird" as directory instead of "Mozilla".
Attachment #9019819 - Attachment is obsolete: true
Attachment #9019819 - Flags: feedback?(robert.strong.bugs)
Thunderbird is correct but the test is failing for a different reason than the installer change.
OK, I'll take a patch with "Thunderbird".
Attachment #9020407 - Flags: review?(jorgk)
Comment on attachment 9020407 [details] [diff] [review]

OK, thanks.
Attachment #9020407 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
I'm investigating the test failure and I think I will need to put the Thunderbird update directory under Mozilla since other fixes could be exploited. Removing checkin-needed
checkin-needed removed.
Keywords: checkin-needed
I have a fix for the test failure and should have it fixed by no later than Monday.
Thank you very much Robert. Please let's discuss the test failure in bug 1501940. So are you saying that something like
isn't needed for C:\ProgramData\Thunderbird?
Correct, it isn't needed for C:\ProgramData\Thunderbird. We are going to go with C:\ProgramData\Mozilla since the complexity of doing C:\ProgramData\Thunderbird would make it easy to exploit without there being a way to mitigate the exploit.
Okay, like this?
Attachment #9020407 - Attachment is obsolete: true
Attachment #9020571 - Flags: review?(jorgk)
Attachment #9020571 - Flags: feedback?(robert.strong.bugs)
Comment on attachment 9020571 [details] [diff] [review]
1501792-installer-location.patch v3

That is correct but I haven't had a chance to go through the patches in bug 1458314 to verify that there aren't more changes needed.
Attachment #9020571 - Flags: feedback?(robert.strong.bugs) → feedback+
Comment on attachment 9020571 [details] [diff] [review]
1501792-installer-location.patch v3

Thanks, rs=jorgk, pending comment #16. It's really hard for me to review since I know nothing about this, see my incorrect comment #7 as a proof :-(

Maybe in the future we can r? the M-C expert directly as I frequently do when porting M-C changes in DOM, Netwerk, etc.
Attachment #9020571 - Flags: review?(jorgk) → review+
Robert, after landing of bug 1502681 which fixed our test failures, is still something needed or should this bug be okay to land?
Flags: needinfo?(robert.strong.bugs)
I scanned the changes today and the patch should suffice for the changes in bug 1458314
Flags: needinfo?(robert.strong.bugs)
Pushed by
Port bug 1458314 to TB: Move the update directory to an installation specific location. rs=jorgk f=rstrong
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: defect → task
You need to log in before you can comment on or make changes to this bug.