See bug 1471403 comment #16 (quote): ... the API for <notificationbox> is going to change. Rather than going from XBL -> Custom Element it's going from XBL -> JS class that builds the DOM. And the element will only contain notifications instead of containing notifications and children. Parts 1 and Part 5 are probably the most relevant changesets to TB. Alternatively you can temporarily restore the <notification> and <notificationbox> bindings and continue to bind them to the DOM nodes.
Summary: Port bug 1471403 - Migrate <notificationbox> to a Custom Element → Port bug 1471403 - Migrate <notificationbox> to a JS class or copy binding
Well for better or worse, the notificationbox binding is already copied at https://searchfox.org/comm-central/source/common/bindings/notificationbox.xml ... due to Bug 1487087 - Restore the button[type="menu-button"] bindings which were removed in bug 1457218. So I would guess not directly pending bustage, but we should look into it.
Summary: Port bug 1471403 - Migrate <notificationbox> to a JS class or copy binding → Port bug 1471403 - Migrate <notificationbox> to a JS class
Actually, the LW theme issue may come from bug 1506411 (bug 1506411 comment #3). We'll see whether it's fixed now.
Seems to do it.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9024282 - Flags: review?(jorgk)
Thanks, that will fix all tests? Let's see: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a36a6a2ac9d6d09275f6f0b821bc2a5531bb3059
Comment on attachment 9024282 [details] [diff] [review] bug1505288_notificationbox_js.patch Thanks. I guess the code is copied from somewhere, so I don't have to read it line by line. That hasn't fixed the LW Theme failures, so I need to file a new bug for it.
Attachment #9024282 - Flags: review?(jorgk) → review+
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/d55eedb42e08 adapt comm-central to notification box for changes in bug 1471403 (Migrate <notificationbox> to a JS class). r=jorgk
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Filed bug 1506470 for the LW theme failures.
(In reply to Jorg K (GMT+1) from comment #6) > I guess the code is copied from somewhere, yeah direct copy of what <notification> was in toolkit before the change.
You need to log in before you can comment on or make changes to this bug.