1507817 - Menus with wayland enabled missing shadows

Status: RESOLVED DUPLICATE of bug 1738084

(Core :: Widget: Gtk, defect, P2)

Description

[Asif Youssuff]

Attachment: wayland.png

Noticed that in GNOME 3 and the "Yaru" (Ubuntu) theme, enabling Wayland causes borders around context menus to not appear. This makes the menu hard to see on white backgrounds. 

See screenshots.

Comment 1

[Asif Youssuff]

Attachment: xwayland.png

Comment 2

[Asif Youssuff]

This also applies to the normal Firefox menus in the menu bar as well.

Comment 3

[Asif Youssuff]

...but not the hamburger menu, at least using Yaru.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

That's very interesting, thanks.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

We may use a wrong window type on Wayland/popup as we did some magic here to place popus correctly.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

When testing with Radiance theme, the popups is apparently missing shadows, but the border itself is here.

Comment 7

[Asif Youssuff]

This is no longer an issue.

Comment 8

[Kestrel]

After upgrading from Ubuntu 18.10 to 19.04 the context menus now have borders but still do not have shadows. Adwaita and Yaru themes have very subtle shadows but they are more noticeable with Ambiance and Radiance.

Comment 9

[Christian Stadelmann]

(In reply to Asif Youssuff from comment #7)

This is no longer an issue.

Which version are you referring to? I'm still not seeing any shadows under menus on 66.0.3 (Fedora 29) and 68 alpha (firefox-flatpak.mojefedora.cz).

Comment 10

[Christian Stadelmann]

Note: In my case (since a few months), the border is visible, but the shadow is not.

Comment 11

[Asif Youssuff]

I started to use the Plata theme, and I see this issue on the latest nightly on Ubuntu Eoan. It is really obvious with this theme because there are no borders around the menus.

Comment 12

[Berend De Schouwer]

I see this using the Materia theme. Materia has the following section in gtk.css; which causes the bug.

#MozillaGtkWidget menu {
border: none;
}

This is probably there for the X11 version of Firefox. Please check if the other themes have a similar section.

Comment 13

[Christian Stadelmann]

(In reply to Berend De Schouwer from comment #12)

I see this using the Materia theme. Materia has the following section in gtk.css; which causes the bug.

#MozillaGtkWidget menu {
border: none;
}

This is probably there for the X11 version of Firefox. Please check if the other themes have a similar section.

At least with the default Gtk Adwaita theme, the border is present, but the shadow is not. See also my comment #9.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Looks like X11 Firefox is also missing the shadows....can you confirm?
Thanks.

Comment 15

[Asif Youssuff]

Attachment: wayland-materia-context.png

Comment 16

[Asif Youssuff]

Attachment: xorg-materia-context.png

Martin, I used the Materia theme (mentioned in comment 12) and confirmed that the Xorg session shows a shadow, while the Wayland session does not. I am not able to confirm your observation.

Comment 17

[Martin Stránský [:stransky] (ni? me)]

IMHO the shadow itself is painted as a part of window but I was referring to additional border shaping - for instance Adwaita has rounded corners on popup windows and we don't paint that on both X11 and Wayland.

We may be able to produce default window shadows on Wayland too.

Comment 18

[Robert Mader [:rmader]]

I think bug 1708136 is related here.

Comment 19

[Asif Youssuff]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #17)

IMHO the shadow itself is painted as a part of window but I was referring to additional border shaping - for instance Adwaita has rounded corners on popup windows and we don't paint that on both X11 and Wayland.

We may be able to produce default window shadows on Wayland too.

I had previously filed the rounding thing to bug 1560482.

Comment 20

[Robert Mader [:rmader]]

Like bug 1708136 this should work in latest nightly. Please reopen if it doesn't for you.