1708136 - Autocomplete panels don't get shadows on WebRender / Wayland on Linux

Status: RESOLVED DUPLICATE of bug 1738084

(Toolkit :: Themes, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Spun off bug 1706154, see the discussion there. It seems GTK only draws shadows on known opaque surfaces, and only on X11, so both WebRender (which always uses alpha visuals) and Wayland (which never decorates the popup) don't show shadows.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1708136 - Draw autocomplete panel shadows ourselves on Linux. r=mak

Use the same setup as arrow panels.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Dao, is something like this (I've only tested on Linux, needs work on Windows / macOS) what you had in mind? If so I can probably get it green etc...

https://hg.mozilla.org/try/rev/1c0432ffb21dd9f5db313728c71352e9e4fbb61d

Comment 3

[Dão Gottwald [:dao]]

Yeah, that looks promising.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1708136 - Make the arrowpanel code more generic. r=dao

Share the concept of a panel content with all other menupopups / panels.

This avoids importing global.css in the shadow tree, and renames the
arrowcontent part to just "content", since we want to introduce a
"content" part for other panels.

This shouldn't change behavior but makes bug 1708136 a matter of
tweaking a couple CSS rules and fixing up test failures.

Comment 5

[Phabricator Automation]

Comment on attachment 9219563 [details]
Bug 1708136 - Make the arrowpanel code more generic. r=dao

Revision D113990 was moved to bug 1708735. Setting attachment 9219563 [details] to obsolete.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

This should work now.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(Duping to the right bug)