Closed Bug 1512889 Opened 11 months ago Closed 11 months ago
Invisible button text color in permission settings dialog
The buttons should probably use color: inherit; since we use alpha backgrounds.
Assignee: nobody → matthias
Status: NEW → ASSIGNED
Attachment #9030357 - Attachment description: Bug 1512889 - Changed button colour to inherit. r=ntim → Bug 1512889 - Changed button colour to inherit. r=dao
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c7669fa6352b Changed button colour to inherit. r=dao
Comment on attachment 9030357 [details] Bug 1512889 - Changed button colour to inherit. r=dao [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1511394 User impact if declined: See comment 0 Is this code covered by automated tests?: No Has the fix been verified in Nightly?: No Needs manual test from QE?: Yes If yes, steps to reproduce: See comment 0 List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): One line CSS change String changes made/needed: no
Attachment #9030357 - Flags: approval-mozilla-beta?
This change is also regressing about:debugging, the selected category no longer has the selected color. Could we try to fix this before requesting for an uplift?
(In reply to Julian Descottes [:jdescottes][:julian] from comment #6) > This change is also regressing about:debugging, the selected category no > longer has the selected color. Could we try to fix this before requesting > for an uplift? As mentioned in bug 1514058, bug 1473922 is the regressing bug, not this one.
Comment on attachment 9030357 [details] Bug 1512889 - Changed button colour to inherit. r=dao [Triage Comment] Minor CSS tweak, approved for 65.0b5.
Attachment #9030357 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I have reproduced this issue using an affected Nightly build (2018-12-09), and following the info from comment 0. This is verified as fixed on Beta 65.0b5 (20181214002557) - downloaded from https://tools.taskcluster.net and latest Nightly 66.a1 (20181214054322). I can confirm that the buttons from permissions settings are using color: inherit, I have checked via Browser Toolbox. Tested on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.