1518536 - Consider dropping iteratorUtils.jsm / fixIterator

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[Mark Banner (:standard8)]

fixIterator is now largely obsolete - arrays, nsISimpleEnumerators, nsIArrays can all be handled with for..of.

toArray(fixIterator(...)) could probably be replaced with [...directory.addressLists.enumerate()]

Hence, it seems like iteratorUtils.jsm should probably be deprecated/removed.

xref the discussion on bug 729069

Comment 1

[Jorg K (CEST = GMT+2)]

Aceman loves it ;-)

Comment 2

[:aceman]

Yes it was useful in the past so that our code and also addons didn't need to worry about what kind of array/enumerator they got (especially when we changed the object/interface in base TB).
If this can be accomplished with for..of now, then fixIterator may be unneeded.

What about the internal handling of QueryInterface() and queryElementAt(). Do we still need to specify interface for nsIArray elements?

Also, fixIterator returns a generator function so we would need to investigate whether we use that property of it (outside of for..of). And we don't know about addons.

Comment 3

[Magnus Melin [:mkmelin]]

We're almost there.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1518536 - remove most of iteratorUtils.jsm usage. r=benc

Comment 5

[Ben Campbell]

Needs a checkin-needed?
(or is there some phab-based way of doing it?)

Comment 6

[Magnus Melin [:mkmelin]]

Will land it later today.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/78900bb22fe4
remove most of iteratorUtils.jsm usage. r=benc

Comment 8

[Magnus Melin [:mkmelin]]

There's now only a few cases left, which need .idl adjustments (I think) before they can be addressed.

Comment 9

[Magnus Melin [:mkmelin]]

Bug 1685484 would fix some, it seems.

Comment 10

[Ben Campbell]

Attachment: Bug 1518536 - Remove redundant fixIterator use in MsgComposeCommands. r?mkmelin

Comment 11

[Ben Campbell]

Attachment: Bug 1518536 - Use JS arrays rather than nsIArray in attachment-* event payloads. r?mkmelin

Depends on D112669

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/72373036e9cf
Remove redundant fixIterator use in MsgComposeCommands. r=mkmelin
https://hg.mozilla.org/comm-central/rev/1c635a22ed37
Use JS arrays rather than nsIArray in attachment-* event payloads. r=mkmelin

Comment 13

[Ben Campbell]

Attachment: Bug 1518536 - Remove iteratorUtils.jsm. r?mkmelin

Depends on D112663

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/12bc6e1f0064
Remove iteratorUtils.jsm. r=mkmelin