Closed Bug 1519012 Opened 6 years ago Closed 6 years ago

Move most PGO-related configure flags back to toolchain.configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

LLVM_PROFDATA needs the toolchain search dir, per bug 1515579.

Also, most of the options actually don't do anything useful with artifact builds. In fact, the only one that artifact builds would need is MOZ_PGO.

LLVM_PROFDATA needs the toolchain search dir, per bug 1515579. Also, most of the options actually don't do anything useful with artifact builds. In fact, the only one that artifact builds would need is MOZ_PGO. So we move to options back to where they were in toolchain.configure, except MOZ_PGO, that we move to the top-level moz.configure (because we don't need a separate file for one option).

Gah, the old location doesn't work, because bug 1507344 moved it to somewhere too early.

Blocks: 1519040
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/d74ea4096863 Move most PGO-related configure flags back to toolchain.configure. r=froydnj
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: