1519631 - Port bug 1519548: Introduce browser.in-content.dark-mode preference on about:preferences

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Firefox is on implementing the dark theme on about:preferences and later on about:addons. Maybe we can follow this.

But first we'd need to port bug 1347204.

Comment 1

[Richard Marti (:Paenglab)]

Porting bug 1347204 looks not too hard, except the https://hg.mozilla.org/mozilla-central/rev/57eb4ec50bfb#l2.1 part.

Geoff, would you have a solution how we could implement this part in TB?

Comment 2

[Tim Nguyen :ntim]

Note that it still depends on the reviewers whether bug 1519548 will ship or not. You shouldn't spend too much effort until it actually lands :)

(In reply to Richard Marti (:Paenglab) from comment #1)

Porting bug 1347204 looks not too hard, except the https://hg.mozilla.org/mozilla-central/rev/57eb4ec50bfb#l2.1 part.

Geoff, would you have a solution how we could implement this part in TB?

Note that this code heavily changed in bug 1483664 and bug 1474163.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1519631-dark-mode-in-content.patch

Port of https://hg.mozilla.org/mozilla-central/rev/119fa544fa30 plus this patch makes the categories readable in dark mode and ports some styles from bug 1544025.

For testing with a light platform theme you can set "browser.in-content.dark-mode" to "true" and create "ui.systemUsesDarkTheme" with the value "1". A restart of TB is needed.

We need the pref "browser.in-content.dark-mode" with the "browser" in it because CSS code in toolkit checks for this and wouldn't work with a different name.

Comment 5

[Richard Marti (:Paenglab)]

Until bug 1544025 lands, the dialogs aren't completely dark.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9058927 [details] [diff] [review]
1519631-dark-mode-in-content.patch

Review of attachment 9058927 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9058927 [details] [diff] [review]
1519631-dark-mode-in-content.patch

Review of attachment 9058927 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/app/profile/all-thunderbird.js
@@ +816,5 @@
>  // We don't support yet language pack download from ATN
>  pref("intl.multilingual.downloadEnabled", false);
> +
> +// Dark in-content pages
> +pref("browser.in-content.dark-mode", false);

Do we really have to call this "browser"? Usually we adapt pref names. Here we'd call it "messenger".

Comment 8

[Richard Marti (:Paenglab)]

Yes, see last sentence of comment 4.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e9de114375d8
Port bug 1519548: Introduce browser.in-content.dark-mode preference on about:preferences. r=mkmelin