The devtools panel tabs are missing
Categories
(DevTools :: Framework, defect)
Tracking
(Not tracked)
People
(Reporter: jlast, Unassigned)
Details
Attachments
(2 files)
panel tabs.jpg
I'm filing this bug on behalf of @RReverser
-
FF devtools is missing its tab strip. I don't understand why it disappeared or how to bring it back (I'm on dev edition and it happened like few days ago).
-
Ctrl+Shift+I seemingly stopped working on pages. So weird.
-
Hmm, restarted with addons disabled and both issues are gone. Wonder what could mess it up that badly...
-
But now disabled all add-ons manually one-by-one and, even with all of them disabled, it still occurs. What else does that safe mode affect?
|
Reporter | |
Comment 1•7 years ago
|
||
|
|
Reporter | |
Comment 2•7 years ago
|
||
This seems to be the relevant issue -- https://searchfox.org/mozilla-central/source/devtools/startup/devtools-startup.js#582-591
|
||
Comment 3•7 years ago
|
||
Could it be related to a localized build missing a string?
Is it on an english version of Firefox or some other language?
|
||
Comment 4•7 years ago
|
||
In reply to Alexandre Poirot [:ochameau] from comment #3)
Could it be related to a localized build missing a string?
Is it on an english version of Firefox or some other language?
Actually just opened Bugzilla to comment that, based on a pretty much wild guess, I removed English (GB) language pack I had, restarted and the issue went away. Now I installed it back and it's still not there, so I guess the language pack got updated or something?
Is there a way to prevent this sort of issues in the future even if a string is missing?
|
||
Comment 5•7 years ago
|
||
Normally a missing string should not be a problem, as it should fallback to the default string defined for the english US locale.
I believe the faulty string here is accessibilityF12.commandkey
Retrieved at https://hg.mozilla.org/mozilla-central/file/0e8109eaef4b/devtools/startup/devtools-startup.js#l176
It was recently added to the enGB bundle.
https://hg.mozilla.org/l10n-central/en-GB/diff/e79766c5b54c/devtools/startup/key-shortcuts.properties
This original bug that added the string was Bug 1434888, which was then uplifted to dev-edition.
What I still don't understand is why the localization would not fallback to the default value in the en US locale.
Maybe Flod would know? It looks like a non en-US dev-edition build with an en-GB language pack installed (& enabled) failed to localize a newly uplifted string from Bug 1434888. Does that sound possible?
|
||
Comment 6•7 years ago
|
||
Maybe Flod would know? It looks like a non en-US dev-edition build with an en-GB language pack installed (& enabled) failed to localize a newly uplifted string from Bug 1434888. Does that sound possible?
Yes, that sounds possible. And not just for a missing translation, but for any locale.
Scenario:
- User installs language pack for 65b1. At this point, there's no trace of string X.
- String X is uplifted and a new beta released, the language pack installed is still compatible with 65, but we end up missing that string completely.
It doesn't matter if it was translated or not, the build system (and language pack) simply doesn't know about it.
This should be fixed by updating the language pack though, which is generated and uploaded to AMO as part of the build process.
|
|
||
Comment 7•7 years ago
|
||
Thanks for the answer Flod! And yes it looks like updating the language pack fixed the issue.
To answer the previous question from RReverser, I don't think you can do much to prevent this from happening on DevEdition, but uplifting localization changes is normally rare.
|
|
||
Comment 8•7 years ago
|
||
Closing as fixed as the language pack has now been updated and there is no action on DevTools side.
|
|
||
Comment 9•6 years ago
|
||
This seems to be a recurring problem, e.g. for the last week I'm seeing an empty Debugger panel in latest Firefox Dev Edition on my both laptops.
And this is the message in the browser console:
Error: "No localization found for [toggleCondPanel.breakpoint.key]"
getStr resource://devtools/shared/l10n.js:111
componentDidMount resource://devtools/client/debugger/new/src/components/Editor/index.js:316
commitLifeCycles resource://devtools/client/shared/vendor/react-dom.js:11391
commitAllLifeCycles resource://devtools/client/shared/vendor/react-dom.js:12348
commitRoot resource://devtools/client/shared/vendor/react-dom.js:12492
completeRoot resource://devtools/client/shared/vendor/react-dom.js:13417
performWorkOnRoot resource://devtools/client/shared/vendor/react-dom.js:13362
performWork resource://devtools/client/shared/vendor/react-dom.js:13281
performSyncWork resource://devtools/client/shared/vendor/react-dom.js:13253
requestWork resource://devtools/client/shared/vendor/react-dom.js:13153
scheduleWork$1 resource://devtools/client/shared/vendor/react-dom.js:13022
scheduleRootUpdate resource://devtools/client/shared/vendor/react-dom.js:13566
updateContainerAtExpirationTime resource://devtools/client/shared/vendor/react-dom.js:13581
updateContainer resource://devtools/client/shared/vendor/react-dom.js:13608
render resource://devtools/client/shared/vendor/react-dom.js:13853
legacyRenderSubtreeIntoContainer resource://devtools/client/shared/vendor/react-dom.js:13965
unbatchedUpdates resource://devtools/client/shared/vendor/react-dom.js:13478
legacyRenderSubtreeIntoContainer resource://devtools/client/shared/vendor/react-dom.js:13961
render resource://devtools/client/shared/vendor/react-dom.js:14012
renderPanel resource://devtools/client/debugger/new/src/utils/bootstrap.js:73
bootstrapApp resource://devtools/client/debugger/new/src/utils/bootstrap.js:121
onConnect resource://devtools/client/debugger/new/src/client/index.js:97
...
Without knowing about this particular issue already, it would be extremely hard to understand what's going on and why Debugger panel is missing.
Hence, instead of relying on language packs being strictly up-to-date, could there be some graceful handling of missing localisations that would keep everything else working?
|
|
||
Comment 10•6 years ago
|
||
Just to be sure it's the same problem, I've switched my Firefox language temporarily to English (US) and Debugger panel did re-appear.
|
|
||
Comment 11•6 years ago
|
||
I'm confused. That string is from bug 1538164, which only landed in 68 (not DevEdition yet).
Regarding brittle code around missing translation, bug 1464132 is still on file.
|
|
||
Comment 12•6 years ago
|
||
It seems it was also uplifted to 67 via https://bugzilla.mozilla.org/show_bug.cgi?id=1539813
|
|
||
Comment 13•6 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #11)
I'm confused. That string is from bug 1538164, which only landed in 68 (not DevEdition yet).
Regarding brittle code around missing translation, bug 1464132 is still on file.
That other bug seems to be open for almost a year now, and the last comment there is a question whether it's still reproducible. I suppose that means no one is really working on a fix?
Description
•