1521277 - Port bug 1241885: Total MozMill faiure on 2019-01-19 on Linux only

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

All Z's a orange, it looks like about all MozMill tests have failed.

https://taskcluster-artifacts.net/G5o2TzmdQ4aH9pXVHALfhg/0/public/logs/live_backing.log

EXCEPTION: Added Task did not appear
EXCEPTION: Expression "[0]" returned null. Anonymous == false
EXCEPTION: Expression "{"flex":"1"}" returned null. Anonymous == false
EXCEPTION: Timed out waiting for window open!
EXCEPTION: Timeout exceeded for waitForElement Lookup: /id("messengerWindow")/id("tabmail-container")/id("tabmail")/id("tabmail-tabbox")/id("tabpanelcontainer")/id("calendarTabPanel")/id("calendarContent")/id("calendarDisplayDeck")/id("calendar-view-box")/id("view-deck")/id("day-view")/anon({"anonid":"mainbox"})/anon({"anonid":"scrollbox"})/anon({"anonid":"daybox"})/[0]/anon({"anonid":"boxstack"})/anon({"anonid":"bgbox"})/[8]/
EXCEPTION: Timeout happened before event 'monthchange' was fired.
EXCEPTION: Timeout waiting for modal dialog to open.
EXCEPTION: Timeout waiting for the content tab to open
EXCEPTION: You need to specify a tab!
EXCEPTION: folder is undefined
EXCEPTION: folderA is undefined
EXCEPTION: mc.folderDisplay is null
EXCEPTION: nextTab is undefined
EXCEPTION: parent.messengerBundle is null
EXCEPTION: swc is null
EXCEPTION: this._rowMap is null
EXCEPTION: this.tabmail is undefined
EXCEPTION: waitFor: Timeout exceeded for '() => eid("day-view").getNode().orient == "horizontal"'

JavaScript error: chrome://messenger/content/accountUtils.js, line 357: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMailSession.topmostMsgWindow]
JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 124: TypeError: gFolderDisplay is null

Looks like something is wrong with tabmail.

M-C last good: 3aa256c255f664c500714c34a3b9e353e5
M-C first bad: 57dc8bbbc38f79ce532feb8947b40311e9
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3aa256c255f664c500714c34a3b9e353e5&tochange=57dc8bbbc38f79ce532feb8947b40311e9

Comment 1

[Jorg K (CEST = GMT+2)]

Wow, Mac opt is 100% green and Windows hasn't even run yet. So we're looking for a Linux issue here. So this?
5433228bc018 Tim Nguyen — Bug 1241885 - Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding. r=dao,bzbarsky,stransky

Comment 2

[Jorg K (CEST = GMT+2)]

OK, looks like we need to follow this:
https://hg.mozilla.org/mozilla-central/rev/5433228bc018#l1.13

Comment 3

[Jorg K (CEST = GMT+2)]

Richard, there might be more porting necessary. I'll port one hunk now and get it landed. Can you please take a look at the rest.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1521277-remove-WindowDraggingUtils.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e1982e53702a
Port bug 1241885: Remove reference to WindowDraggingUtils.jsm. rs=bustage-fix DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

This will need more work, see:
https://searchfox.org/comm-central/rev/1b47c29d1d04a793f658b3cb6a1295de9f949c02/common/bindings/toolbar.xml#510

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1521277-remove-WindowDraggingUtils-2.patch

Culling some more. I think the entire binding can go, but I won't touch the CSS.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c79237b13f9a
Port bug 1241885: Remove reference to WindowDraggingUtils.jsm, take 2. rs=bustage-fix DONTBUILD

Comment 9

[Richard Marti (:Paenglab)]

You'd better used bug 1521213 which was for this.

Comment 10

[Jorg K (CEST = GMT+2)]

Well, next time you CC me.

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 9037738 [details] [diff] [review]
1521277-remove-WindowDraggingUtils.patch

OK, Richard had the same patch, so it must be good.

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: 1521213-moz-window-dragging.patch

Richard's patch from bug 1521213.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e50aae192485
Port bug 1241885: Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding. r=jorgk DONTBUILD

Comment 15

[Jorg K (CEST = GMT+2)]

Sorry for the mess, but next time, please let me know in advance.